Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fix tabs shown/hidden when tags selected/unselected
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: fix tabs shown/hidden when tags selected/unselected
......................................................................
webadmin: fix tabs shown/hidden when tags selected/unselected
Fixed tab show logic so that when a tag is selected, only Hosts, VMs, and Users
tabs are visible. When no tag is selected, tabs behave as if System node is
selected.
Change-Id: I6cace6daecef58ee2726a22e880d5c31e03e275f
Bug-Url:…
[View More] https://bugzilla.redhat.com/1006282
Bug-Url: https://bugzilla.redhat.com/996594
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
1 file changed, 19 insertions(+), 14 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cace6daecef58ee2726a22e880d5c31e03e275f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Allowed non-draggable NetworkItemPanel
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Allowed non-draggable NetworkItemPanel
......................................................................
webadmin: Allowed non-draggable NetworkItemPanel
It seems that so far setting draggable to false did nothing, the item
would still be draggable; for some reason calling
setDraggable(Element.DRAGGABLE_FALSE) adds the draggable property to
an element and sets it to true!
Added some code to disable the "…
[View More]draggable skin" and the actual drag
operation when an item has been constructed as non-draggable. Also,
changed bonds to be draggable explicitly, as they have been draggable
all this time and I've heard no complaints.
Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96
Bug-Url: https://bugzilla.redhat.com/990612
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
2 files changed, 20 insertions(+), 17 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Changed Boolean argument to boolean
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Changed Boolean argument to boolean
......................................................................
webadmin: Changed Boolean argument to boolean
There was no reason to ever pass null rather than true or false, and
no code called these constructors with a null value.
Change-Id: Ib99896c52b950dcf56891c5e6e2e8b7b760bc830
Bug-Url: https://bugzilla.redhat.com/990612
Signed-off-by: Lior Vernia <lvernia(…
[View More]a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib99896c52b950dcf56891c5e6e2e8b7b760bc830
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: support the newly-tagged vdsm-4.13
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: support the newly-tagged vdsm-4.13
......................................................................
core: support the newly-tagged vdsm-4.13
vdsm-4.13 would be part of oVirt-3.3.1.
Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.…
[View More]sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19973
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: shceduling: destination host isn't guaranteed
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: shceduling: destination host isn't guaranteed
......................................................................
core: shceduling: destination host isn't guaranteed
when migrating VM to a specific host, or running once VM on
a specific host, and the specified host isn't suitable for running the VM,
another host could be selected. this patch fixes that, and
the operation would fail.
Change-Id: …
[View More]I6894c0d8d42bd57026ccc36b52d9d266add14384
Bug-Url: https://bugzilla.redhat.com/999630
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
7 files changed, 41 insertions(+), 3 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6894c0d8d42bd57026ccc36b52d9d266add14384
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: remove disabled external scheduler plugin
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: remove disabled external scheduler plugin
......................................................................
engine: remove disabled external scheduler plugin
Added a new command to remove disabled external policy units
Added a new dialog to show all policy units, in this dialog, disabled
external policy units can be removed.
Change-Id: Ia03da19368b75b125aa3ea144b36016feddcb08c
Bug-Url: https://bugzilla.…
[View More]redhat.com/1014700
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveExternalPolicyUnitCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/parameters/RemoveExternalPolicyUnitParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ClusterPolicyListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ManagePolicyUnitModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/scheduling/ManagePolicyUnitPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ClusterPolicyModelProvider.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_external_policy.png
M packaging/dbscripts/policy_unit_sp.sql
24 files changed, 508 insertions(+), 4 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia03da19368b75b125aa3ea144b36016feddcb08c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: disable when external scheduler is down
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: disable when external scheduler is down
......................................................................
core: disable when external scheduler is down
- When we are unable perform discovery on the external
scheduler, mark all external policy units as disabled.
Change-Id: I2cd7aa42f85f261f9e55e057b52d7dc4c5738252
Bug-Url: https://bugzilla.redhat.com/1014700
Signed-off-by: Noam Slomianko <nslomian(a)…
[View More]redhat.com>
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
2 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19968
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cd7aa42f85f261f9e55e057b52d7dc4c5738252
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Resized edit DC network dialog
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Resized edit DC network dialog
......................................................................
webadmin: Resized edit DC network dialog
It was too small, changed the size to be exactly like the normal edit
network dialog.
Change-Id: I5777d41bb6b353128eaf35ccbc2f8a5f98388f1d
Bug-Url: https://bugzilla.redhat.com/996612
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/…
[View More]modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditDataCenterNetworkPopupView.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/19988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5777d41bb6b353128eaf35ccbc2f8a5f98388f1d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Resized edit DC network dialog
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Resized edit DC network dialog
......................................................................
webadmin: Resized edit DC network dialog
It was too small, changed the size to be exactly like the normal edit
network dialog.
Change-Id: I5777d41bb6b353128eaf35ccbc2f8a5f98388f1d
Bug-Url: https://bugzilla.redhat.com/996612
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/…
[View More]modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditDataCenterNetworkPopupView.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/19985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5777d41bb6b353128eaf35ccbc2f8a5f98388f1d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[master]: core: RemoveVM - clear snapshot_id from detached disks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: RemoveVM - clear snapshot_id from detached disks
......................................................................
core: RemoveVM - clear snapshot_id from detached disks
Clearing snapshot_id from detached disk images
when removing a VM.
Change-Id: I03fe42fd16067ceda87027b96948e746d0045229
RelatedTo-Bug-Url: https://bugzilla.redhat.com/1015170
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M …
[View More]backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03fe42fd16067ceda87027b96948e746d0045229
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months