Change in ovirt-engine[master]: frontend: ignore "class too big" findbug on ApplicationConst...
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: frontend: ignore "class too big" findbug on ApplicationConstants
......................................................................
frontend: ignore "class too big" findbug on ApplicationConstants
Add to excluded warnings filter the "class too big" warning
generated on ApplicationConstants class.
Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/exclude-filters.xml
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: rest: fix rsdl for cloud-init parameters
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: rest: fix rsdl for cloud-init parameters
......................................................................
rest: fix rsdl for cloud-init parameters
fix error with brackets in cloud init parameters for run vm rsdl
definition.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990572
Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: core: rename method to lowercase in BaseHandler
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: rename method to lowercase in BaseHandler
......................................................................
core: rename method to lowercase in BaseHandler
Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IObjectDescriptorContainer.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: Add support for maintenance mode reporting
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add support for maintenance mode reporting
......................................................................
Add support for maintenance mode reporting
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034323
Change-Id: Ib21774d33fd50bc1da47a60b6fd48859ca27cfda
Signed-off-by: Martin Sivak <mars(a)montik.net>
---
M src/ovirt_hosted_engine_setup/vm_status.py
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib21774d33fd50bc1da47a60b6fd48859ca27cfda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: webadmin: Add icons to bootable and shareable columns
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Add icons to bootable and shareable columns
......................................................................
webadmin: Add icons to bootable and shareable columns
Up until now Bootable and Shareable columns in Add Virtual Disk
window missed headers. This patch adding their icons as headers.
Change-Id: I776739681d9ae47d6d7dc92115dc7269e2495127
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
1 file changed, 16 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I776739681d9ae47d6d7dc92115dc7269e2495127
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: webadmin: Rename checkboxes in edit vm disk window
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Rename checkboxes in edit vm disk window
......................................................................
webadmin: Rename checkboxes in edit vm disk window
Change-Id: I741272e243a0a2e9f82f9ddbc3aa8a59cb92ed45
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I741272e243a0a2e9f82f9ddbc3aa8a59cb92ed45
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eldan Hildesheim <info(a)eldanet.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: select GlusterFS storage type in New Storage Domain
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: select GlusterFS storage type in New Storage Domain
......................................................................
webadmin: select GlusterFS storage type in New Storage Domain
In a GlusterFS Data Center, when creating a second
storage domain, GlusterFS Storage type is not selected
by default.
This is fixed now.
Change-Id: Id32c2c11da506da073bde9bed0328d408bd9e53e
Bug-Url: https://bugzilla.redhat.com/1005832
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Kanagaraj M: Verified
--
To view, visit http://gerrit.ovirt.org/21968
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id32c2c11da506da073bde9bed0328d408bd9e53e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors
......................................................................
frontend: ignore in findbugs EventArgs unconfirmed cast errors
Ignore in findbugs errors related to casting EventArgs.
The casting is safe in this case, and a future refactoring
will make findbug warning resolved in any case.(RFE #1034844)
This is patch #6 following
http://gerrit.ovirt.org/#/c/21903/
Change-Id: Ifa2b17e7af8e599234648ba6319b272f092679d5
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
M frontend/webadmin/modules/webadmin/exclude-filters.xml
3 files changed, 45 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa2b17e7af8e599234648ba6319b272f092679d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: build: ovirt-hosted-engine-setup-1.0.0-0.10.beta5
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.10.beta5
......................................................................
build: ovirt-hosted-engine-setup-1.0.0-0.10.beta5
Change-Id: I1b07e8d2d9c2ab5f610212d6640874b34f02037b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Greg Padgett: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/21967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b07e8d2d9c2ab5f610212d6640874b34f02037b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: webadmin: select GlusterFS storage type in New Storage Domain
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: select GlusterFS storage type in New Storage Domain
......................................................................
webadmin: select GlusterFS storage type in New Storage Domain
In a GlusterFS Data Center, when creating a second
storage domain, GlusterFS Storage type is not selected
by default.
This is fixed now.
Change-Id: Id32c2c11da506da073bde9bed0328d408bd9e53e
Bug-Url: https://bugzilla.redhat.com/1005832
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id32c2c11da506da073bde9bed0328d408bd9e53e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months