March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Drop support for IE6-7
by vszocs＠redhat.com 29 Mar '13

29 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Drop support for IE6-7 ...................................................................... webadmin,userportal: Drop support for IE6-7 This patch removes "ie6" user agent from default GWT compilation, which also means less permutations to compile and faster builds in general. Change-Id: I5820bfe4147d5429714ed6388bcc8d62ecb4e40c Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5820bfe4147d5429714ed6388bcc8d62ecb4e40c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Remove '__gwt_historyFrame' iframe
by vszocs＠redhat.com 29 Mar '13

29 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Remove '__gwt_historyFrame' iframe ...................................................................... webadmin,userportal: Remove '__gwt_historyFrame' iframe This iframe is needed only for IE6-7 support. Since we support IE9+, having this iframe within GWT host page is just redundant. Change-Id: I5b5946a536fbc441cb6dca75f8dc36760164b534 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b5946a536fbc441cb6dca75f8dc36760164b534 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: UI-plugins MainTabActionButton CommandLocation
by vszocs＠redhat.com 29 Mar '13

29 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: UI-plugins MainTabActionButton CommandLocation ...................................................................... webadmin: UI-plugins MainTabActionButton CommandLocation Add ability to set button location using addMainTabActionButton API. For example: addMainTabActionButton('Host', 'My Button', { location: 'OnlyFromContext' }); Supported values for 'location': * OnlyFromContext * OnlyFromToolBar * ContextAndToolBar (default) Change-Id: I034be5af1b2dcbaad4bfce9784d74410a92fb4be Signed-off-by: Daniel Erez <derez(a)redhat.com> Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/CommandLocation.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsObjectWithProperties.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java 10 files changed, 51 insertions(+), 9 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I034be5af1b2dcbaad4bfce9784d74410a92fb4be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in otopi[master]: system: reboot: chdir to / as daemon
by Alon Bar-Lev 29 Mar '13

29 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: system: reboot: chdir to / as daemon ...................................................................... system: reboot: chdir to / as daemon Change-Id: I4865c0b9bbd03fbf00ec7237b60ff4354fd5d88d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/system/reboot.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4865c0b9bbd03fbf00ec7237b60ff4354fd5d88d Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Add a configure option to disable SSO
by bazulay＠redhat.com 28 Mar '13

28 Mar '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Add a configure option to disable SSO ...................................................................... agent: Add a configure option to disable SSO We don't support SSO on all systems, therefore we should at least make it possible to build the guest agent daemon for those systems Change-Id: Ic00e4c781a47194bbf6eda62fe3b4f1f107bbbbe Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M Makefile.am M configure.ac 2 files changed, 25 insertions(+), 3 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00e4c781a47194bbf6eda62fe3b4f1f107bbbbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Added myself to AUTHORS
by bazulay＠redhat.com 28 Mar '13

28 Mar '13

Barak Azulay has submitted this change and it was merged. Change subject: Added myself to AUTHORS ...................................................................... Added myself to AUTHORS Change-Id: I541d0ecdf6e623210c5ecd89cdb694cb90e199c2 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M AUTHORS 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I541d0ecdf6e623210c5ecd89cdb694cb90e199c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove redundant check from setter in StorageDomain
by lhornyak＠redhat.com 28 Mar '13

28 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove redundant check from setter in StorageDomain ...................................................................... engine: remove redundant check from setter in StorageDomain checking if the status the same or the old value was null is not needed in setters Change-Id: I0deb82036c08869a0def80fd1d5bc50885c5e5bc Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0deb82036c08869a0def80fd1d5bc50885c5e5bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: update DiskImageDynamic on RemoveSnapshot
by derez＠redhat.com 28 Mar '13

28 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: core: update DiskImageDynamic on RemoveSnapshot ...................................................................... core: update DiskImageDynamic on RemoveSnapshot * Fetching image's size on endSuccessfully of RemoveSnapshotSingleDiskCommand. * Updating DiskImageDynamic with the retrieved value. Change-Id: Ie124fb42c34860ee349e91172e0248a2d824b127 Bug-Url: https://bugzilla.redhat.com/923864 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie124fb42c34860ee349e91172e0248a2d824b127 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Control UI plugin dynamic tab alignment
by vszocs＠redhat.com 28 Mar '13

28 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Control UI plugin dynamic tab alignment ...................................................................... webadmin: Control UI plugin dynamic tab alignment This patch improves the existing UI plugin API for handling dynamic tabs. (1) Function improved: addMainTab New signature: addMainTab(label, historyToken, contentUrl [, options]) Example usage: // Tab is left-aligned by default addMainTab('Foo Tab', 'foo-tab', 'http://www.foo.com/'); // Tab is right-aligned via options object addMainTab('Foo Tab', 'foo-tab', 'http://www.foo.com/', { alignRight: true }); (2) Function improved: addSubTab New signature: addSubTab(entityTypeName, label, historyToken, contentUrl [, options]) Example usage: // Tab is left-aligned by default addSubTab('VirtualMachine', 'Bar Tab', 'bar-tab', 'http://www.bar.com/'); // Tab is right-aligned via options object addSubTab('VirtualMachine', 'Bar Tab', 'bar-tab', 'http://www.bar.com/', { alignRight: true } ); Signed-off-by: Spenser Shumaker <sshumake(a)redhat.com> Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> Change-Id: Icd6929538fd106d0c54d162dfd21f8946254ce5f --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabProxy.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/DynamicTab.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/DynamicTabData.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/TabOptions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/DynamicUrlContentTabProxy.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/DynamicUrlContentTabProxyFactory.java 8 files changed, 69 insertions(+), 29 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd6929538fd106d0c54d162dfd21f8946254ce5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: UI plugin dialog API improved
by vszocs＠redhat.com 28 Mar '13

28 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: UI plugin dialog API improved ...................................................................... webadmin: UI plugin dialog API improved This patch improves the existing UI plugin API for handling dialogs. (0) Minor dialog / UI plugin infrastructure improvements (1) Function improved: showDialog New signature: showDialog(title, dialogToken, contentUrl, width, height [, options]) Example usage: showDialog('My Dialog', 'my-dialog', 'http://www.foobar.com/', '800px', '600px', { // Default value = empty array (no buttons) buttons: [ { label: 'Do stuff', onClick: function() { alert('Bump!'); } } ], // Default value = false resizeEnabled: true, // Default value = true closeIconVisible: true, // Default value = true closeOnEscKey: true } ); The implementation now uses WebAdmin's GWTP dialog infrastructure via non-singleton DynamicUrlContentPopupPresenterWidget component so that multiple dynamic dialog instances can be shown at a time if necessary. (2) New function: setDialogContentUrl New signature: setDialogContentUrl(dialogToken, contentUrl) Example usage: setDialogContentUrl('my-dialog', 'http://www.example.com/') (3) New function: closeDialog New signature: closeDialog(dialogToken) Example usage: closeDialog('my-dialog') Change-Id: I4654a25bed7122c45d432e3860ed710fa4ca3dd9 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AbstractDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PluginModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/DialogButtonInterface.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/DialogOptions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsArrayHelper.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsInterfaceObject.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsObjectWithProperties.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/CloseDynamicPopup.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/DynamicUrlContentPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/SetDynamicPopupContentUrl.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/DynamicUrlContentPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/DynamicUrlContentPopupView.ui.xml 19 files changed, 495 insertions(+), 54 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4654a25bed7122c45d432e3860ed710fa4ca3dd9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0