Change in ovirt-engine[master]: webadmin: Select english when browser is other locale
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Select english when browser is other locale
......................................................................
webadmin: Select english when browser is other locale
- Fixed ability to select English (which was default) when
the browser default was a different locale. Selecting
English would reset to the browsers default locale.
- Fixed issue where unsupported locale would show empty selected
label.
Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=894288
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml
4 files changed, 30 insertions(+), 19 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: restapi : Creating template by specifing vm name, does not w...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Creating template by specifing vm name, does not work (#915285)
......................................................................
restapi : Creating template by specifing vm name, does not work (#915285)
Creating template by specifing vm name, does not work,
works only when vm id is specified.
This patch lets the user create a template from a VM
by specifying the vm name.
Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915285
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/dbscripts/vms_sp.sql
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQueryTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java
10 files changed, 234 insertions(+), 5 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[engine_3.2]: restapi: add missing log4j dep
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add missing log4j dep
......................................................................
restapi: add missing log4j dep
Change-Id: I6980d7a3acd38940a1c9e63bee028a7ee826cd7a
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13394
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6980d7a3acd38940a1c9e63bee028a7ee826cd7a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: fix NPE in WebAdminHostPageServletTest
by sanjal@redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: fix NPE in WebAdminHostPageServletTest
......................................................................
webadmin: fix NPE in WebAdminHostPageServletTest
Two @Before methods in WebAdminHostPageServletTest is causing the tests
to fail with NPE on my laptop. Merging them into single one resolves the
problem.
Change-Id: Ib76f7bd842d3b58c522e3e97609a9b55d5a79902
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib76f7bd842d3b58c522e3e97609a9b55d5a79902
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[engine_3.2]: core: Fix for VmBase
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix for VmBase
......................................................................
core: Fix for VmBase
Fix for patch: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54
Removed 'final' from disk list to allow RPC Serialization.
Change-Id: Id3aa95b2c93fb9cd3cc737f88b8a9ac970d42ba3
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3aa95b2c93fb9cd3cc737f88b8a9ac970d42ba3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 8 months
Change in ovirt-engine-cli[cli_3.2]: cli : --vm-os-boot doesn't send the order of devices
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli : --vm-os-boot doesn't send the order of devices
......................................................................
cli : --vm-os-boot doesn't send the order of devices
When starting vm with parameter --vm-os-boot
"boot.dev=hd,boot.dev=network" only network device is sent
Change-Id: I681b28926fad32cfe36472a3940df7021bfcbe6b
Bug-Url: https://bugzilla.redhat.com/921464
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I681b28926fad32cfe36472a3940df7021bfcbe6b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 8 months
Change in ovirt-engine-cli[master]: cli : --vm-os-boot doesn't send the order of devices
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli : --vm-os-boot doesn't send the order of devices
......................................................................
cli : --vm-os-boot doesn't send the order of devices
When starting vm with parameter --vm-os-boot
"boot.dev=hd,boot.dev=network" only network device is sent
Change-Id: I681b28926fad32cfe36472a3940df7021bfcbe6b
Bug-Url: https://bugzilla.redhat.com/921464
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I681b28926fad32cfe36472a3940df7021bfcbe6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[engine_3.2]: restapi: rename /api rsdl metadata to avoid collisions
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: rename /api rsdl metadata to avoid collisions
......................................................................
restapi: rename /api rsdl metadata to avoid collisions
api.xsd already has "api" element what can
lead to element->type mapping collisions in some
client bindings
Change-Id: Ic7b0421e4e01f147e55015adeabdcdefd9463f23
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/GeneralMetadataBuilder.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
4 files changed, 37 insertions(+), 37 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b0421e4e01f147e55015adeabdcdefd9463f23
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: restapi: rename /api rsdl metadata to avoid collisions
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: rename /api rsdl metadata to avoid collisions
......................................................................
restapi: rename /api rsdl metadata to avoid collisions
api.xsd already has "api" element what can
lead to element->type mapping collisions in some
client bindings
Change-Id: Ic7b0421e4e01f147e55015adeabdcdefd9463f23
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/GeneralMetadataBuilder.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
4 files changed, 37 insertions(+), 37 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b0421e4e01f147e55015adeabdcdefd9463f23
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine, webadmin: Show VM as stateless in audit log
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine,webadmin: Show VM as stateless in audit log
......................................................................
engine,webadmin: Show VM as stateless in audit log
Show different message in audit log (Events), in case a VM
was started in stateless mode
(can be specified in RunOnce dialog - 'stateless' checkbox option or
in Edit VM dialog (for desktop only).
Change-Id: Id9bb0bd88e544880406c340afb7e213041b2f845
Bug-Url: https://bugzilla.redhat.com/907997
Signed-off-by: Libor Spevak <lspevak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 11 insertions(+), 3 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9bb0bd88e544880406c340afb7e213041b2f845
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 8 months