Change in ovirt-engine[master]: engine: Fix mispelling in member name INSTANCE
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Fix mispelling in member name INSTANCE
......................................................................
engine: Fix mispelling in member name INSTANCE
Change-Id: Ibb07bd1b3f61826dc71a092acff20e858974b561
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BiggerOrSmallerRelationAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb07bd1b3f61826dc71a092acff20e858974b561
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: fix typo in scheduler error message
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix typo in scheduler error message
......................................................................
core: fix typo in scheduler error message
Change-Id: I4f2f80002d26edefbca5aa43c124ebcb668127d8
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f2f80002d26edefbca5aa43c124ebcb668127d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: build: Explicit versions definitions for maven plugins.
by asaf@redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: build: Explicit versions definitions for maven plugins.
......................................................................
build: Explicit versions definitions for maven plugins.
Maven 3.x deprecates definition of plugins and dependencies without
explicit version specified,
This commit defines explicit version for some maven plugins thus
eliminates the startup maven warnings when a build occurs.
Change-Id: I968a9ef2e4741acd313d2e165348bee1ccd1b0ed
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M pom.xml
1 file changed, 22 insertions(+), 0 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I968a9ef2e4741acd313d2e165348bee1ccd1b0ed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin, userportal: Fix action table element IDs
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix action table element IDs
......................................................................
webadmin,userportal: Fix action table element IDs
This patch fixes a problem in AbstractActionTable which uses
two table widgets internally (optional header + main table).
Since both above mentioned table widgets are now derived from
ColumnResizeCellTable, and sice column definition objects are
shared between both tables, we must not set element IDs for
the optional header table.
Change-Id: I318338a8e92b3967b4ce40ac288add846f0a1444
Bug-Url: https://bugzilla.redhat.com/960519
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ElementIdCellTable.java
2 files changed, 7 insertions(+), 6 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14546
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I318338a8e92b3967b4ce40ac288add846f0a1444
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: engine: Fixed upgrade script with duplicate number
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Fixed upgrade script with duplicate number
......................................................................
engine: Fixed upgrade script with duplicate number
Change-Id: I563aa8c81b5ba1d609f72a83d592bf7655b98995
Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com>
---
R backend/manager/dbscripts/upgrade/03_03_0130_add_gluster_services_tables.sql
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Shireesh Anjal: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I563aa8c81b5ba1d609f72a83d592bf7655b98995
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: gluster: Tables, SPs and DAOs for gluster services
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: gluster: Tables, SPs and DAOs for gluster services
......................................................................
gluster: Tables, SPs and DAOs for gluster services
These tables will store information about gluster related services
running on servers of gluster storage clusters.
gluster_service_types : Type of the service e.g. gluster-swift
gluster_services : Service type to services mapping
(gluster-swift-proxy, gluster-swift-container, etc)
gluster_cluster_services : Cluster to service types mapping
gluster_server_services : Server to services mapping
In this process, renamed the class ServiceInfo to GlusterServerService
Change-Id: I1ded8d39203009bc66974e136c41b5de180ffbff
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
A backend/manager/dbscripts/gluster_services_sp.sql
A backend/manager/dbscripts/upgrade/03_03_0120_add_gluster_services_tables.sql
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterClusterService.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterService.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServiceStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDaoDbFacadeImpl.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServiceDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServiceDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDaoTest.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoTest.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServiceDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServicesReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterServiceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
26 files changed, 1,317 insertions(+), 156 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ded8d39203009bc66974e136c41b5de180ffbff
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 6 months
Change in ovirt-engine-cli[cli_3.2]: cli: Add brick operation fails from ovirt-shell(#923169)
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Add brick operation fails from ovirt-shell(#923169)
......................................................................
cli: Add brick operation fails from ovirt-shell(#923169)
Duplicate bricks are send when --brick-brick option is
specified for add brick operation.
Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e
Bug-Url: https://bugzilla.redhat.com/923169
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 6 months
Change in ovirt-engine-cli[master]: cli: Add brick operation fails from ovirt-shell(#923169)
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Add brick operation fails from ovirt-shell(#923169)
......................................................................
cli: Add brick operation fails from ovirt-shell(#923169)
Duplicate bricks are send when --brick-brick option is
specified for add brick operation.
Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e
Bug-Url: https://bugzilla.redhat.com/923169
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: engine: Cleaning up InitVdsOnUpCommand
by sanjal@redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: Cleaning up InitVdsOnUpCommand
......................................................................
engine: Cleaning up InitVdsOnUpCommand
Removed the '_' prefixes from the private fields.
Change-Id: I4023d9eb66504ff2648b7567626fc962de08b53c
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
1 file changed, 24 insertions(+), 24 deletions(-)
Approvals:
Shireesh Anjal: Looks good to me, approved
Kanagaraj M: Verified
--
To view, visit http://gerrit.ovirt.org/14492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4023d9eb66504ff2648b7567626fc962de08b53c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine-cli[master]: cli: fail nicely on AttributeError #959740
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: fail nicely on AttributeError #959740
......................................................................
cli: fail nicely on AttributeError #959740
Change-Id: I534beb603be224a8103d5900ea6fb34b5315a18b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=959740
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/cli/messages.py
M src/ovirtcli/command/command.py
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I534beb603be224a8103d5900ea6fb34b5315a18b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 6 months