Change in ovirt-engine[master]: webadmin: replace login target button with an image
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: replace login target button with an image
......................................................................
webadmin: replace login target button with an image
New/Edit storage domain:
replacing login target button with an image
(preventing truncation in various translations).
Change-Id: I0dee7a0bb923f18ec5eb6370ffea9f5ff6c78f92
Bug-Url: https://bugzilla.redhat.com/927504
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/login.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/login_disabled.png
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java
6 files changed, 15 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dee7a0bb923f18ec5eb6370ffea9f5ff6c78f92
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Attach disk tables - resizable and tooltips
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Attach disk tables - resizable and tooltips
......................................................................
webadmin: Attach disk tables - resizable and tooltips
Attach disk tables columns are now support resizing and tool-tips.
Change-Id: I8543db5ca3833e481637d57d00677b3c68eb8fbf
Bug-Url: https://bugzilla.redhat.com/956378
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8543db5ca3833e481637d57d00677b3c68eb8fbf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Snapshots info panel resizable and tooltips
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Snapshots info panel resizable and tooltips
......................................................................
webadmin: Snapshots info panel resizable and tooltips
VMs -> Snapshots sub-tab: info panel columns are now support
resizing and tool-tips.
Change-Id: Ie306afa9ca0326515c39810571524a742e8d9040
Bug-Url: https://bugzilla.redhat.com/956378
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
1 file changed, 11 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie306afa9ca0326515c39810571524a742e8d9040
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: [ja] Edit pool- prestarted vms string is broken in...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: [ja] Edit pool- prestarted vms string is broken into two lines
......................................................................
webadmin: [ja] Edit pool- prestarted vms string is broken into two lines
In 'ja' locale the text of prestarted vms is too long for 230px.
Changed all the right column widgets to be 250px.
Also changed the width of the popup to 710px (Changing the width of the
rigth widgets caused "Increase number of VMs in pool by" to be broken
into two lines. BTW, in some langauges it was broken even before the
change).
The change applies only on EditPool.
Change-Id: Iaf34f3adbde08bb34d8db7db3508ba3cf4c31f92
Bug-Url: https://bugzilla.redhat.com/950788
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java
5 files changed, 50 insertions(+), 8 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf34f3adbde08bb34d8db7db3508ba3cf4c31f92
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: packaging - starting ovirt-engine only after yum rollback
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging - starting ovirt-engine only after yum rollback
......................................................................
packaging - starting ovirt-engine only after yum rollback
With the previous implementation ovirt-engine service
was started before exiting the rhyum transaction
context after an execption. So the newly installed version
of ovirt-engine was running with the restored PKI and DB.
Now the ovirt-engine service start is done only after
yum rollback transaction.
Change-Id: If8160293d45361534dfda6c6aa3870e72368d10b
Bug-Url: https://bugzilla.redhat.com/879969
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 133 insertions(+), 133 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8160293d45361534dfda6c6aa3870e72368d10b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: engine: Ability to assign multiple VMs from a pool to single...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Ability to assign multiple VMs from a pool to single user
......................................................................
engine: Ability to assign multiple VMs from a pool to single user
Added a new field VmPool.maxAssignedVmsPerUser representing maximumum
number of VMs a single user can attach to from the same pool. Default value of
1 is equivalent to current behavior.
This patch also includes necessary minimal frontend changes in userportal
due to the logic of showing/hiding VmPools in userportal.
Change-Id: I3a1cc836db48d7094c2e7a03ee3a60b0b34a52a9
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_03_0120_add_max_assigned_vms_per_user.sql
M backend/manager/dbscripts/vm_pools_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolSimpleUserParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolUserParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
17 files changed, 105 insertions(+), 67 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a1cc836db48d7094c2e7a03ee3a60b0b34a52a9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Fix repeated logins due to UI plugin REST API hear...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Fix repeated logins due to UI plugin REST API heartbeat
......................................................................
webadmin: Fix repeated logins due to UI plugin REST API heartbeat
This patch addresses a problem (behavior) of web browser sending
HTTP 'Authorization' header unconditionally (always) for each
request to given origin after the HTTP 'Authorization' header has
been set for the first time (e.g. via XmlHttpRequest).
This generally means the JavaScript application doesn't have full
control over HTTP 'Authorization' header; once set for the initial
request, web browser will always send this header until the browser
window is closed by the user.
To address this problem in UI plugin REST API integration:
1. all plugins will receive single session ID using GUI (WebAdmin)
user credentials, session timeout is set to 6 hours
2. WebAdmin will not try to keep-alive the session via periodic
heartbeat requests due to the problem with HTTP 'Authorization'
header handling in web browser
These changes have following implications:
* REST API session will be acquired with reasonably long timeout
* it's up to plugins (or other systems using the session) to keep
the session alive as necessary
In future, we should work around the HTTP 'Authorization' header
problem and revisit the general contract of UI plugin REST API
integration, i.e. whether to keep-alive the session by WebAdmin,
or whether to push session acquiry responsibility to individual
plugins.
Change-Id: I72c2d4952daac4daa17554b7661ed775c72cb97a
Bug-Url: https://bugzilla.redhat.com/894687
Bug-Url: https://bugzilla.redhat.com/906046
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
2 files changed, 28 insertions(+), 59 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72c2d4952daac4daa17554b7661ed775c72cb97a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webdamin: make the right side of vm->interface sub tab resiz...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webdamin: make the right side of vm->interface sub tab resizable
......................................................................
webdamin: make the right side of vm->interface sub tab resizable
Make the columns of the statistics and guest agent tabs (which are based
on EntityModelCellTable) resizable.
Change-Id: Ic7b36139e522abe7805a8b09d803d06e6a87e685
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java
2 files changed, 13 insertions(+), 7 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b36139e522abe7805a8b09d803d06e6a87e685
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
......................................................................
engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
The NPE is occuring because of some changes in Base class.
As a fix, start to pass a VDS as parameter and not vdsId
Change-Id: I9d3027b134e11e9fb22cd007d10ce4b9fd8afbb6
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
7 files changed, 11 insertions(+), 16 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14501
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3027b134e11e9fb22cd007d10ce4b9fd8afbb6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Introducing findbugs filter to bll module
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Introducing findbugs filter to bll module
......................................................................
core: Introducing findbugs filter to bll module
Introducing findbugs to bll module.
In order to generate findbugs report use
"mvn site" and look for findbugs.xml at the target/site
directory (this may take several minutes)
Marking as WIP as obviously this should be implemented to
other modules.
I would like you to review and share your opinions
Thanks
Change-Id: I26b9cafc1832022693a7386277972a7e48a53f0d
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
A backend/manager/modules/bll/exclude-filters.xml
M backend/manager/modules/bll/pom.xml
2 files changed, 28 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26b9cafc1832022693a7386277972a7e48a53f0d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months