Change in ovirt-engine[master]: webadmin: Moved network lines in SearchBackend.gwt.xml
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Moved network lines in SearchBackend.gwt.xml
......................................................................
webadmin: Moved network lines in SearchBackend.gwt.xml
Were listed under Gluster which could be confusing.
Change-Id: Iaaaab42e811fb10000363e31b273a85dcc37ded6
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14762
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaaab42e811fb10000363e31b273a85dcc37ded6
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Added connectivity test to provider popup
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Added connectivity test to provider popup
......................................................................
webadmin: Added connectivity test to provider popup
Added test button to add/edit provider popup, when pressed a
connectivity check is initiated and the user is informed whether the
input URL works.
Change-Id: Id0856c12d016c283a90c35622441fadc785c5d9c
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/ProviderPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
5 files changed, 122 insertions(+), 7 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0856c12d016c283a90c35622441fadc785c5d9c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Added authentication fields to Provider popup
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Added authentication fields to Provider popup
......................................................................
webadmin: Added authentication fields to Provider popup
Added checkbox to mark whether the provider requires authentication, and
if so then username and password text boxes may be filled.
Change-Id: I6153b80d0cb3d60baae8c1782239578eeb64d95c
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
4 files changed, 106 insertions(+), 6 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14758
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6153b80d0cb3d60baae8c1782239578eeb64d95c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Added UI provision for ProviderType
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Added UI provision for ProviderType
......................................................................
webadmin: Added UI provision for ProviderType
Added provision for the ProviderType enum, for when it is populated with
values. Different renderers might in fact be needed.
Change-Id: I0f9dbe26ecc611039210151fe09b14ac8d3f0734
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java
7 files changed, 69 insertions(+), 4 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f9dbe26ecc611039210151fe09b14ac8d3f0734
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Revamped Provider/General subtab
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Revamped Provider/General subtab
......................................................................
webadmin: Revamped Provider/General subtab
Added more fields to the subtab.
Change-Id: I45351c96a0f56cf5726e5d87a2d046c0c2b77ca5
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java
2 files changed, 42 insertions(+), 9 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45351c96a0f56cf5726e5d87a2d046c0c2b77ca5
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Added confirmation window for Remove Providers
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Added confirmation window for Remove Providers
......................................................................
webadmin: Added confirmation window for Remove Providers
Created confirmation window before removal is performed, and a model to
include all of the logic.
Change-Id: Ic8dbc9d11519c15306cc33d7af7d0b6e4f4c7a0c
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/RemoveProvidersModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
3 files changed, 86 insertions(+), 12 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8dbc9d11519c15306cc33d7af7d0b6e4f4c7a0c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Added validation to ProviderModel
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Added validation to ProviderModel
......................................................................
webadmin: Added validation to ProviderModel
Making sure that the provider name is not empty, and that its URL is
approximately fine.
Change-Id: I754a7ce4e2aa719b0284d2dc0021822af2629b07
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UriAuthority.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidation.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/UriTest.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidationTest.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
7 files changed, 350 insertions(+), 2 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I754a7ce4e2aa719b0284d2dc0021822af2629b07
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Added edit button in Providers tab
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Added edit button in Providers tab
......................................................................
webadmin: Added edit button in Providers tab
Created class hierarchy for the popup models in the process for the
sake of code reuse.
Change-Id: I9ddd28b7cfb9c90b7875762efff1d6faba424475
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ProviderModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
8 files changed, 77 insertions(+), 11 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ddd28b7cfb9c90b7875762efff1d6faba424475
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Houskeeping in Provider main tab and popup
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Houskeeping in Provider main tab and popup
......................................................................
webadmin: Houskeeping in Provider main tab and popup
Closed possible loopholes, removed redundant code, changed method
access modifiers, added constants to represent command names,
formatted code for uniformity within files.
Change-Id: Ie5d4225174e733588010a46325674df2165c8814
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
2 files changed, 158 insertions(+), 204 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5d4225174e733588010a46325674df2165c8814
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Provider main tab immediate refresh
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Provider main tab immediate refresh
......................................................................
webadmin: Provider main tab immediate refresh
Added callbacks to add/remove functionality in Providers main tab, so
that when a provider is added or removed the providers list is
immediately refresh.
Change-Id: I8ca1239cd111b417434e2276c8f36f628dacd144
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
2 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11139
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ca1239cd111b417434e2276c8f36f628dacd144
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 6 months