Change in ovirt-engine[master]: restapi: Remove Mockito from Tests
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: restapi: Remove Mockito from Tests
......................................................................
restapi: Remove Mockito from Tests
Change-Id: I14d5e772de6b79ae88ed2cfabdd873461e3b5d71
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/utils/OsTypeMockUtils.java
7 files changed, 55 insertions(+), 34 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14d5e772de6b79ae88ed2cfabdd873461e3b5d71
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: core: osinfo - Fix Unassigned conversion to UNASSIGNED
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: osinfo - Fix Unassigned conversion to UNASSIGNED
......................................................................
core: osinfo - Fix Unassigned conversion to UNASSIGNED
Fixed the pattern matching to cover all the rest OsType names
Added test cases to cover all the OsType names.
This fixed the backward compatibility UNASSIGNED OsType value.
Change-Id: Ib55fd00ddfb19aff8bf38d1ca0da923146956ccd
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImplTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M packaging/conf/osinfo-defaults.properties
4 files changed, 28 insertions(+), 5 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib55fd00ddfb19aff8bf38d1ca0da923146956ccd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-log-collector[master]: core: Add setup events log
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: Add setup events log
......................................................................
core: Add setup events log
Add to the report /var/lib/ovirt-engine/setup-history.txt, created
by http://gerrit.ovirt.org/15863
Change-Id: I7c159eeab80f7953470e7451559ba87b9cd024a0
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/889271
---
M src/sos/plugins/engine.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/16065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c159eeab80f7953470e7451559ba87b9cd024a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk-java[master]: sdk: synchronize on write
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: synchronize on write
......................................................................
sdk: synchronize on write
Change-Id: Id9e6c5d789a9f9532b611b3c2b6de3a49c802f0a
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionGetterTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionGetterTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubResourceTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/VariableTemplate
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolume.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrick.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrickStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetwork.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterCluster.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolume.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrick.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrickStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetwork.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQuota.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDiskPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDiskStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Domain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainGroup.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainUser.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Event.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Group.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRole.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermit.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostHook.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Network.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Role.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermit.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDiskPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDiskStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainFile.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplate.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplateDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateCdRom.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/User.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRole.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermit.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMApplication.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRom.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICReportedDevice.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMReportedDevice.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshot.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotCdRom.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VersionCaps.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPool.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermission.java
90 files changed, 713 insertions(+), 268 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9e6c5d789a9f9532b611b3c2b6de3a49c802f0a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: setup: Log setup/cleanup/upgrade actions
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: setup: Log setup/cleanup/upgrade actions
......................................................................
packaging: setup: Log setup/cleanup/upgrade actions
Added ovirt-engine-log-setup-event.sh and calls to it from
engine-setup/cleanup/upgrade.
Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/889271
---
M .gitignore
M Makefile
M ovirt-engine.spec.in
A packaging/bin/ovirt-engine-log-setup-event.sh.in
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-cleanup.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine-upgrade.py
M packaging/setup/ovirt_engine_setup/constants.py
A packaging/setup/plugins/ovirt-engine-common/distro-rpm/__init__.py
A packaging/setup/plugins/ovirt-engine-common/distro-rpm/log_setup_event.py
11 files changed, 241 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: regenerate against the latest api
......................................................................
sdk: regenerate against the latest api
- to datacenter added new field [comment]
- to disk added [sgio] field to enable|disable filtering for the ScsiGenericIo
- to StorageDomain.delete() added storagedomain.host.id|name
Change-Id: I08ed8b6ace9ca5da32a9e4d0b63879715ea3e1a5
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenters.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Disk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ScsiGenericIoOptions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VersionCaps.java
13 files changed, 225 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16076
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08ed8b6ace9ca5da32a9e4d0b63879715ea3e1a5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk-java[master]: codegen: use local sdk rather than latest mvn release
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: use local sdk rather than latest mvn release
......................................................................
codegen: use local sdk rather than latest mvn release
Change-Id: If529b1e8ef4af653fe5bf57b355d873c2be3a85d
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/pom.xml
1 file changed, 17 insertions(+), 11 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If529b1e8ef4af653fe5bf57b355d873c2be3a85d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in jenkins[master]: Backup plugins directory only on Sunday
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Backup plugins directory only on Sunday
......................................................................
Backup plugins directory only on Sunday
Change-Id: I685c026a7b9d882297aa43c84527d1a7a774b210
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M backup/backup-jenkins.sh
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve
Eyal Edri: Looks good to me, approved
Kiril Nesenko: Verified
--
To view, visit http://gerrit.ovirt.org/16063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I685c026a7b9d882297aa43c84527d1a7a774b210
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: frontend: Fixed NPE on new pool dialog
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fixed NPE on new pool dialog
......................................................................
frontend: Fixed NPE on new pool dialog
The 282f87b3b0a96008d87cad21cc48e4d8adcd4cf9 did
bring a regression that the new pool throws an NPE.
The problem was in the fact, that on some places
the osId was taken from the getSelectedItem() and
directly converted to int - but there are cases where
it can be null and that throws an NPE.
Null it can be for example when UnitVmModel.initOSType()
sets getOSType().setItems(AsyncDataProvider.getOsIds()),
which results in ListModel.itemsChanged() which does
setSelectedItems(null); and just after than it sets the
given items.
Change-Id: If6eb8db7e59204a6a77fbd802fcf7a378c31388b
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
2 files changed, 20 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6eb8db7e59204a6a77fbd802fcf7a378c31388b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: func to delete all versions of a config val
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: func to delete all versions of a config val
......................................................................
core: func to delete all versions of a config val
Adding a function to delete all versions of a config value so
we don't have to specify which versions specifically to delete.
Change-Id: I72c482d39b7c48dff5b6125cc1b795fbaabefa60
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/dbscripts/common_sp.sql
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72c482d39b7c48dff5b6125cc1b795fbaabefa60
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 10 months