Change in ovirt-engine[master]: core: VdsSelector: remove method used only once
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: VdsSelector: remove method used only once
......................................................................
core: VdsSelector: remove method used only once
Removing the method 'getVdsRunOnDestination(bool)'.
To improve code readability.
Gerrit-cntr: 1
Change-Id: Iecedcd6b9b754dbd853304d58083a556dab51cfb
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
1 file changed, 4 insertions(+), 17 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecedcd6b9b754dbd853304d58083a556dab51cfb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: remove vdsSelector CheckDestinationFirst
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: remove vdsSelector CheckDestinationFirst
......................................................................
core: remove vdsSelector CheckDestinationFirst
it's always true ...
Gerrit-cntr: 1
Change-Id: I5f9ce4357a85727f1a2016a46c0ce8f00621fd4c
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
4 files changed, 5 insertions(+), 24 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f9ce4357a85727f1a2016a46c0ce8f00621fd4c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Introduce scheduling package
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Introduce scheduling package
......................................................................
core: Introduce scheduling package
Move all host selection code into a separate package within
bll.
Remove all bll dependencies from these files.
This is the first part of refactoring host selection and load balancing.
Gerrit-cntr: 1
Change-Id: Icac8f7bc8a696455134bb90ffc17afd420e18dd4
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/NoneComparer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsComparer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/EvenlyDistributeComparer.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/MemoryVdsComparer.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/MigrationHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/NonWaitingDelayer.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/NoneComparer.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PowerSaveComparer.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/RunVmDelayer.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsComparer.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsCpuVdsLoadBalancingAlgorithm.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsFreeMemoryChecker.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancingAlgorithm.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VmCountVdsLoadBalancingAlgorithm.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
24 files changed, 246 insertions(+), 197 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15816
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icac8f7bc8a696455134bb90ffc17afd420e18dd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: Add new column to audit_log SQL table for stack trace
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: Add new column to audit_log SQL table for stack trace
......................................................................
Add new column to audit_log SQL table for stack trace
This patch adds a call stack column to the audit_log table.
Change-Id: I9c61ab5e1efff01d26594bbddb43060a86641de3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=966198
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/dbscripts/audit_log_sp.sql
A backend/manager/dbscripts/upgrade/03_03_0220_add_call_stack_to_audit_log.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
7 files changed, 57 insertions(+), 9 deletions(-)
Approvals:
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c61ab5e1efff01d26594bbddb43060a86641de3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-image-uploader[master]: config: added backward compatibilty
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: config: added backward compatibilty
......................................................................
config: added backward compatibilty
Added backward compatibility supporting upgrade from
3.1 version which used the keyword rhevm instead of engine.
When reading configurarion files, the user will be warned
that there is a deprecated key that needs to be updated.
Change-Id: Ic522c278157022b54d449bd4b0d73f9b9a2ce73d
Bug-Url: https://bugzilla.redhat.com/975347
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic522c278157022b54d449bd4b0d73f9b9a2ce73d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 10 months
Change in ovirt-iso-uploader[master]: config: added backward compatibilty
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: config: added backward compatibilty
......................................................................
config: added backward compatibilty
Added backward compatibility supporting upgrade from
3.1 version which used the keyword rhevm instead of engine.
When reading configurarion files, the user will be warned
that there is a deprecated key that needs to be updated.
Change-Id: I6755c1ad020ee3220aa5f5335c6d66ead5139e57
Bug-Url: https://bugzilla.redhat.com/975209
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6755c1ad020ee3220aa5f5335c6d66ead5139e57
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Manage OS properties in a repository
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Manage OS properties in a repository
......................................................................
core: Manage OS properties in a repository
This is the implementation of the OS info according to
http://www.ovirt.org/OS_info
This feature enables ovirt to configure all its OS info in one place,
out of the code, and in a way admins could extend it or easily configure
it.
It aims to merge all configuration items from the Config (currently
vdc_options table) and the VmOsType.java enum to one file-based
repository.
This patch contains:
* The default repo config file osinfo-defaults.properties
* A loading logic to support multiple properties file loading
* A Repository which holds an inner tree with all the configuration
* A backend query to expose the data to UI
Change-Id: I50384bf3b6763fa7a34badc2449e06242186a858
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M Makefile
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/MapBackedPreferences.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImplTest.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsLoader.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoaderTest.java
A backend/manager/modules/utils/src/test/resources/osinfo.conf.d/00-osinfo-test.properties
A backend/manager/modules/utils/src/test/resources/osinfo.conf.d/10-osinfo-test.properties
M ovirt-engine.spec.in
A packaging/conf/osinfo-defaults.properties
18 files changed, 1,188 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50384bf3b6763fa7a34badc2449e06242186a858
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: gluster: Resolve conflict for gluster hook content
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: gluster: Resolve conflict for gluster hook content
......................................................................
gluster: Resolve conflict for gluster hook content
While resolving content conflict in gluster hook and
user chooses the hook content from one of the server,
the hook should be copied on all servers - not just
conflicting servers.
Change-Id: Ifc2d8ad65af2e019eda0d24b6b1f2f87561c8f73
Bug-Url: https://bugzilla.redhat.com/973137
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
3 files changed, 37 insertions(+), 12 deletions(-)
Approvals:
Sahina Bose: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc2d8ad65af2e019eda0d24b6b1f2f87561c8f73
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: frontend: Slightly improve memory size unit relabeling
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Slightly improve memory size unit relabeling
......................................................................
frontend: Slightly improve memory size unit relabeling
When creating a new VM, entering 1G (or 1g) into the Memory Size field,
gets changed to '1 MB' after hitting tab instead of '1024 MB'.
This patch allows entering suffixes 'm', 'M', 'g' and 'G'.
Change-Id: I0006718ead0c7e97bcdc3d4a2827245dc468b554
Bug-Url: https://bugzilla.redhat.com/974379
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/parser/MemorySizeParser.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/15823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0006718ead0c7e97bcdc3d4a2827245dc468b554
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: avoid NPE in AttachDiskToVmCommand
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: avoid NPE in AttachDiskToVmCommand
......................................................................
core: avoid NPE in AttachDiskToVmCommand
if the given disk doesn't exist, NPE will occur.
Change-Id: Ifd68475c8f590e24eb5e20423aabba51df2ae33a
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd68475c8f590e24eb5e20423aabba51df2ae33a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months