Change in ovirt-engine[master]: backend: Enable edit of VmTemplate OS
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: Enable edit of VmTemplate OS
......................................................................
backend: Enable edit of VmTemplate OS
Added osId to list of permitted fields in VmTemplateHandler.
Change-Id: I979c384ad7b286eaf38992c7ffa12428b1c972bf
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I979c384ad7b286eaf38992c7ffa12428b1c972bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: frontend: enable localization of usb support types
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: enable localization of usb support types
......................................................................
frontend: enable localization of usb support types
Change the translations of UsbPolicy enum values to reside in
LocalizedEnums instead of Enums, in order to make it possible to
localize them.
Change-Id: Icc23c2d8597e7d270c0390eb136a0f123fe0e16f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
4 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc23c2d8597e7d270c0390eb136a0f123fe0e16f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: Removing not needed code
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Removing not needed code
......................................................................
core: Removing not needed code
The following patch fixes redunant
host string calculation
Change-Id: Ia0270a2150e9d5e51745f027b4223f02ed11aece
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0270a2150e9d5e51745f027b4223f02ed11aece
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-hosted-engine-setup[master]: build: post ovirt-hosted-engine-setup-1.0 branching
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-setup-1.0 branching
......................................................................
build: post ovirt-hosted-engine-setup-1.0 branching
Change-Id: I922f3a9e44a561d85a78d9d9612611d595cd1122
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/19307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I922f3a9e44a561d85a78d9d9612611d595cd1122
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: better illegal VM status message
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: better illegal VM status message
......................................................................
core: better illegal VM status message
Enriched the "The VM status is illegal" message to contain
also the localized version of the status which is illegal.
Change-Id: Iea6840e555aeb0c7a33a3b90e72fef23433e2be1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1000068
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/LocalizedVmStatus.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
15 files changed, 193 insertions(+), 18 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea6840e555aeb0c7a33a3b90e72fef23433e2be1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: engine: Add branded link to console resources
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Add branded link to console resources
......................................................................
engine: Add branded link to console resources
This patch adds an external link to console resources (for ovirt engine
hosted on ovirt wiki).
The link is added to following places:
- landing page (new section)
- (basic) user portal right-hand (details) pane
- console options dialog.
Change-Id: I5f7316e6ce5032123edc2e39b4939d0c8dab1cb1
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/997418
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml
M packaging/branding/ovirt.brand/external_resources.properties
M packaging/branding/ovirt.brand/messages.properties
M packaging/branding/ovirt.brand/welcome_page.template
10 files changed, 166 insertions(+), 30 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f7316e6ce5032123edc2e39b4939d0c8dab1cb1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-image-uploader[master]: packaging: enable units testing
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: enable units testing
......................................................................
packaging: enable units testing
- added %check in the spec file, calling make check
- added check-local target in src/ovf where a unit test
already existed
- cleaned up ovfenvelopetest.py
- avoid syntax check on generated file ovfenvelope.py
Change-Id: Ic4a3988c7067ece7f6ea60834182a2585a2f7545
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M .gitignore
M ovirt-image-uploader.spec.in
M src/ovf/Makefile.am
M src/ovf/ovfenvelopetest.py
4 files changed, 35 insertions(+), 27 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4a3988c7067ece7f6ea60834182a2585a2f7545
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: sanlock: creates metadata file
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sanlock: creates metadata file
......................................................................
sanlock: creates metadata file
Creates the metadata file is shared by all hosts participating in the engine
high availability cluster. Each host is assigned a 4KiB chunk according
to its host id, with a corresponding offset of host_id*4KiB. The
initial 4KiB of the file are reserved for shared state such as a global
engine ha maintenance bit.
Change-Id: I8862209fe2fd783aaeab04d2c655afd9e1a10396
Bug-Url: https://bugzilla.redhat.com/1008501
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
3 files changed, 19 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8862209fe2fd783aaeab04d2c655afd9e1a10396
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: move unplugged disks while VM is running
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: move unplugged disks while VM is running
......................................................................
core: move unplugged disks while VM is running
Refactor/rewrite of MoveDisksCommand to support the following:
* Offline move of unplugged disks while the VM is running.
* Add error messages when trying to move/migrate a mixture
of plugged and unplugged disks (on a running VM).
Change-Id: Ie0fbfd95c0086cfe0d792b3071a2d804ff32c18e
Bug-Url: https://bugzilla.redhat.com/987783
Bug-Url: https://bugzilla.redhat.com/957494
Bug-Url: https://bugzilla.redhat.com/957492
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 245 insertions(+), 111 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0fbfd95c0086cfe0d792b3071a2d804ff32c18e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: rename HandleError method to lowercase
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rename HandleError method to lowercase
......................................................................
core: rename HandleError method to lowercase
Change-Id: I704ef6f7373dd7150966d4904370badf3783dca3
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
5 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I704ef6f7373dd7150966d4904370badf3783dca3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months