Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Show Guide Me before vNIC creation
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Show Guide Me before vNIC creation
......................................................................
webadmin: Show Guide Me before vNIC creation
There's no real need to wait for the vNIC creation to finish before
showing the Guide Me dialog; if the creation succeeds then it could
happen asynchronously while the user deals with the Guide Me dialog
(I'm unaware of any interdependence between the operations), and if it
fails then an error dialog will popup up anyway (and on top of the
Guide Me dialog rather than under it).
Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Bug-Url: https://bugzilla.redhat.com/1066461
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 20 insertions(+), 9 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/25936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: Add new role permission drop below the end of the ...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: webadmin: Add new role permission drop below the end of the screen
......................................................................
webadmin: Add new role permission drop below the end of the screen
When creating a new role, the permission tree ends
below the lower border of the screen when the
entire tree is expanded
Change-Id: I6f785d91c8bc10b0ceb44ed153237e5f62590b76
Bug-Url: https://bugzilla.redhat.com/1057103
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml
1 file changed, 21 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/24853
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f785d91c8bc10b0ceb44ed153237e5f62590b76
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: allow snapshots for read-only disks
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: allow snapshots for read-only disks
......................................................................
core: allow snapshots for read-only disks
Allow snapshots for read-only disks
(modified 'DiskImageBase -> isAllowSnapshot' accordingly).
Change-Id: Ic832544d2d520841abe1f20d0a9a724535481218
Bug-Url: https://bugzilla.redhat.com/1072471
Bug-Url: https://bugzilla.redhat.com/1072529
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic832544d2d520841abe1f20d0a9a724535481218
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: Show Guide Me before vNIC creation
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Show Guide Me before vNIC creation
......................................................................
webadmin: Show Guide Me before vNIC creation
There's no real need to wait for the vNIC creation to finish before
showing the Guide Me dialog; if the creation succeeds then it could
happen asynchronously while the user deals with the Guide Me dialog
(I'm unaware of any interdependence between the operations), and if it
fails then an error dialog will popup up anyway (and on top of the
Guide Me dialog rather than under it).
Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Bug-Url: https://bugzilla.redhat.com/1066461
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 20 insertions(+), 9 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: userportal: fix right-hand pane scrolling
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal: fix right-hand pane scrolling
......................................................................
userportal: fix right-hand pane scrolling
In the User Portal, the right-hand pane took up too much space. The pane typically
had a horizontal scrollbar that caused the user to have to scroll to the right to
be able to edit the "Console options".
Fixed by removing min-width of 540px.
Change-Id: I80b358915c6a168d694b268a8cec08f9b18a5d72
Bug-Url: https://bugzilla.redhat.com/1001419
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/MainTabBasicView.ui.xml
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25913
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80b358915c6a168d694b268a8cec08f9b18a5d72
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: packaging: services: Allow more time for deployments
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: services: Allow more time for deployments
......................................................................
packaging: services: Allow more time for deployments
In my fedora 19 VM, nightly master, engine+dwh+reports, deployment took
almost 2 minutes. Allow 10 minutes instead of the default 60 seconds.
Bug-Url: https://bugzilla.redhat.com/1078291
Change-Id: Ieda7952fbb01ae37923a200ff6c0eaaa84e9bf10
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.xml.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/25895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieda7952fbb01ae37923a200ff6c0eaaa84e9bf10
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine[master]: core: Fix VDS clone method
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix VDS clone method
......................................................................
core: Fix VDS clone method
Fixed VDS clone to copy the comment.
Change-Id: I08b0e8946124cb176a01842d2d4304d9d0479aca
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08b0e8946124cb176a01842d2d4304d9d0479aca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-dwh[ovirt-3.3]: db: preserve custom db users permissions on...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: preserve custom db users permissions on...
......................................................................
db: preserve custom db users permissions on...
preserve custom db users permissions on upgrade
Up to this patch if custom users were added and assign privileges on DB
objects those privileges were removed when the db was updated or
refreshed.
This patch backups the privileges assigned to custom users and apply
them after the database was upgraded or refreshed.
Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073471
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M data-warehouse/historydbscripts_postgres/dbfunctions.sh
M data-warehouse/historydbscripts_postgres/refreshStoredProcedures.sh
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
10 years, 8 months
Change in ovirt-dwh[master]: core: preserve custom db users permissions on...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: preserve custom db users permissions on...
......................................................................
core: preserve custom db users permissions on...
preserve custom db users permissions on upgrade
Up to this patch if custom users were added and assign privileges on DB
objects those privileges were removed when the db was updated or
refreshed.
This patch backups the privileges assigned to custom users and apply
them after the database was upgraded or refreshed.
Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073471
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/dbscripts/dbfunc-common.sh
1 file changed, 23 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
10 years, 8 months
Change in ovirt-dwh[master]: db: add pg_dump wrapper
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: add pg_dump wrapper
......................................................................
db: add pg_dump wrapper
Change-Id: I5dac42b5991f913ae5c1fccc4436eaffbb420195
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbfunc-base.sh
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5dac42b5991f913ae5c1fccc4436eaffbb420195
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
10 years, 8 months