Change in ovirt-engine[master]: frontend: set query's refresh property using fluent api
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: frontend: set query's refresh property using fluent api
......................................................................
frontend: set query's refresh property using fluent api
In addition, the patch contains minor refactoring in AsyncDataProvider.
Change-Id: Id8dcd88a788cf06ae959b6e24ff34c0096392d6e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
3 files changed, 25 insertions(+), 26 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8dcd88a788cf06ae959b6e24ff34c0096392d6e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: change few queries to be not refreshable
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: change few queries to be not refreshable
......................................................................
webadmin: change few queries to be not refreshable
The automatic logout did not work when the snapshot sub-tab was shown.
It did not work because queries which were executed in this state were
invoked as refreshable, thus preventing the session from being
terminated automatically. So the solution is to change those queries to
be not refreshable.
Change-Id: I6c367c274bfc518f920344a57d7efd3fefd75d30
Bug-Url: https://bugzilla.redhat.com/1058629
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 12 insertions(+), 5 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25772
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c367c274bfc518f920344a57d7efd3fefd75d30
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4.0]: core: preserve custom db users permissions on...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: preserve custom db users permissions on...
......................................................................
core: preserve custom db users permissions on...
preserve custom db users permissions on upgrade
Up to this patch if custom users were added and assign privileges on DB
objects those privileges were removed when the db was updated or
refreshed.
This patch backups the privileges assigned to custom users and apply
them after the database was upgraded or refreshed.
Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073471
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbfunctions.sh
M packaging/dbscripts/refreshStoredProcedures.sh
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4.0
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: core: VdsNotRespondingTreatment Job is not marked as finished.
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: VdsNotRespondingTreatment Job is not marked as finished.
......................................................................
core: VdsNotRespondingTreatment Job is not marked as finished.
Once a host is not reachable and VdsNotRespondingTreatment job runs,
the job is always marked as STARTED - never FINISHED/FAILS. This
patch solves this
Change-Id: I9d3d6bc9f409bbcdd5a6b7d2201d8d6eef61ecf5
Bug-Url: https://bugzilla.redhat.com/1075500
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/25831
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3d6bc9f409bbcdd5a6b7d2201d8d6eef61ecf5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: consider the event type while printing events to engin...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: consider the event type while printing events to engine.log
......................................................................
core: consider the event type while printing events to engine.log
Change AuditLog log level based on the event severity.
Change-Id: I9e8444fc33aa487d378b7310a1004a016c762c0a
Bug-Url: https://bugzilla.redhat.com/1072795
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e8444fc33aa487d378b7310a1004a016c762c0a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-dwh[master]: packaging: setup: database: fix typo in manual instructions
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: database: fix typo in manual instructions
......................................................................
packaging: setup: database: fix typo in manual instructions
Change-Id: I30bfcd2a2bb7c3a0935bd7ec797484dfeba540dc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067548
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30bfcd2a2bb7c3a0935bd7ec797484dfeba540dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months
Change in ovirt-reports[master]: packaging: setup: database: fix typo in manual instructions
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: database: fix typo in manual instructions
......................................................................
packaging: setup: database: fix typo in manual instructions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067548
Change-Id: I9ac65d82e7fa6782192341f851ecfbd8de41a1f3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ac65d82e7fa6782192341f851ecfbd8de41a1f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: core: Remove redundant SuppressWarnings("unused")
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove redundant SuppressWarnings("unused")
......................................................................
core: Remove redundant SuppressWarnings("unused")
Change-Id: I24f000343ee82218a16dd20f2116e9552d202d13
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/25794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24f000343ee82218a16dd20f2116e9552d202d13
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: Revert "core: Setting missing severity to audit log..."
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: Revert "core: Setting missing severity to audit log..."
......................................................................
Revert "core: Setting missing severity to audit log..."
This reverts commit 5b04d663c19a9eba12b1d7a2ec71cc5617b724b6.
Breaks CI tests
Change-Id: Ib5640d003bd27d3f92156fb36fe604ce32b2f2c5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057029
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5640d003bd27d3f92156fb36fe604ce32b2f2c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: dbscripts: fix password field length
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: dbscripts: fix password field length
......................................................................
dbscripts: fix password field length
the password column in the 'storage_server_connections' table has
a different type with respect to the corresponding parameter of
the Insertstorage_server_connection function.
This trigger SQL exception doing the following:
- configure an ISCSI data domain (bug triggered on the first one,
but it should behave the same with the others too).
- in the 'New domain' window, issue fill all the fields,
most notably username and password, and do a manual discovery.
- try to add the target which shows up as result of the discovery.
This patch fixes this problem by enlarging the password field on
the table, in order to let it hold the encrypted password.
Bug-Url: https://bugzilla.redhat.com/1052839
Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M packaging/dbscripts/storages_san_sp.sql
A packaging/dbscripts/upgrade/03_04_0690_change_storage_server_connections_password_length.sql
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit http://gerrit.ovirt.org/25893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months