Change in ovirt-engine[ovirt-engine-3.4]: tools: Add man page for engine-backup
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Add man page for engine-backup
......................................................................
tools: Add man page for engine-backup
Change-Id: I03dd8338a2dbd6ad8ade22db07c7118e0630c17a
Bug-Url: https://bugzilla.redhat.com/1074303
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M ovirt-engine.spec.in
A packaging/man/man8/engine-backup.8
2 files changed, 115 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25809
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03dd8338a2dbd6ad8ade22db07c7118e0630c17a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: further handling of multiple ovf disks for domain
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: further handling of multiple ovf disks for domain
......................................................................
core: further handling of multiple ovf disks for domain
Perform ovf update to ovf stores after creation of all disks completes
to avoid races on acquiring locks
Change-Id: I8e54ca3781a301b72dc76b0dc014cf017a63e94e
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfVolumeForStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateOvfStoresForStorageDomainCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
5 files changed, 131 insertions(+), 40 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25852
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e54ca3781a301b72dc76b0dc014cf017a63e94e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: increment vm/templates db generation on pool ver upgrade
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: increment vm/templates db generation on pool ver upgrade
......................................................................
core: increment vm/templates db generation on pool ver upgrade
When upgrading the storage pool comptability version to one that
supports the OvfStoreOnAnyDomain feature, the vms/templates db
generation should be incremented so that ovf configuration will be
generated and saved for those vms/templates.
Without it being done on the next run of the ovf update process
for a domain we might store ovf with missing ovf configurations
(as they were never generated and saved).
Change-Id: Ief1a984a7d275d558bbe74bbca6bd49326267e43
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief1a984a7d275d558bbe74bbca6bd49326267e43
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Introducing OvfStoreOnAnyDomain feature
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: Introducing OvfStoreOnAnyDomain feature
......................................................................
core: Introducing OvfStoreOnAnyDomain feature
this patch intrdouces the OvfOnAnyDomain feature -
For any domain in supported pool the engine will attempt to store OVFs
of VMs/Templates that have image disks on that domain.
As soon as there will be such vms/templates, the engine will attempt to
create OVF disk on that domain. If the disk won't be created
succesfully, it will remain in ILLEGAL status untill it will be removed
by the user.
As soon as the OVF disk is created succesfully for the domain, an in
memory tar with all the related OVF data will be created and uploaded to
the ovf store disk on the domain.
Currently most of the operation are blocked for ovf disks, they will be
enabled in further patches.
Change-Id: I78803db10947a6ee477a493b530319654b1c045d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1032686
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
6 files changed, 597 insertions(+), 160 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23467
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78803db10947a6ee477a493b530319654b1c045d
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: block operations on ovf disks
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: webadmin: block operations on ovf disks
......................................................................
webadmin: block operations on ovf disks
disable different operations for ovf disks
Change-Id: I379d10be9b6ee1cbda99d85f5dc02af78695a65c
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I379d10be9b6ee1cbda99d85f5dc02af78695a65c
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Setting missing severity to audit log...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Setting missing severity to audit log...
......................................................................
core: Setting missing severity to audit log...
Setting missing severity to audit log messages
This patches adding settings for audit log severities that were logged
as NORMAL messages instead of ERROR/WARNING
Change-Id: Id0111351c8d83eeda0ae1a57538ef1eabe5d4001
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047889
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0111351c8d83eeda0ae1a57538ef1eabe5d4001
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: allow to remove storage pool when the only disks are o...
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: allow to remove storage pool when the only disks are ovf stores
......................................................................
core: allow to remove storage pool when the only disks are ovf stores
Change-Id: Ifca867af242984aa9292938b88f568f51a4a147c
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
2 files changed, 23 insertions(+), 3 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifca867af242984aa9292938b88f568f51a4a147c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: detach/remove of domain with ovf stores
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: detach/remove of domain with ovf stores
......................................................................
core: detach/remove of domain with ovf stores
*When detaching a storage domain the engine should allow to detach it
even if it has disks that are used as the domain ovf store.
*When removing a storage domain, use the StorageDomainDao.remove method,
this method is currently being used by the ForceRemoveStorage flow and
cleans up anything associated with the domain.
As we allow to remove a domain with ovf stores, the domain disks should
be removed as well (handled by this sp).
This sp is heavier than the previous calls, but we are saving round
trips and removing storage domain is a rare scenario so we better
make sure that no leftovers are left by executing this sp rather than
take care of that ourselves and rely on bll CDA checks.
Change-Id: Icde56b54bd11c617056c819fcdbacac71753e264
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 26 insertions(+), 11 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icde56b54bd11c617056c819fcdbacac71753e264
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: DetachStorageDomain - adding lock of the domain id
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: DetachStorageDomain - adding lock of the domain id
......................................................................
core: DetachStorageDomain - adding lock of the domain id
Change-Id: I4ee8cd4b64393d195fe45349f49996e45ce09f0f
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ee8cd4b64393d195fe45349f49996e45ce09f0f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: block different operations for OVF disks
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: block different operations for OVF disks
......................................................................
core: block different operations for OVF disks
Currently different operations on ovf disks should be blocked,
they will be enabled later on.
Removing on ovf disk is enabled only if it is in ILLEGAL status.
Change-Id: Ic2b7b9f39dcf5da76be75c1106e062ff41ca8068
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
15 files changed, 104 insertions(+), 2 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24179
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2b7b9f39dcf5da76be75c1106e062ff41ca8068
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months