March 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Attached network to host for unused labeled network

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Attached network to host for unused labeled network ...................................................................... engine: Attached network to host for unused labeled network The engine should support configuring a labeled network on hosts, if the network was already labeled, but never configured on any host. Change-Id: I646dd1901b2e75b1b6bebc5562c9cc2e8377425d Bug-Url: https://bugzilla.redhat.com/1074258 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 18 insertions(+), 13 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I646dd1901b2e75b1b6bebc5562c9cc2e8377425d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Networks with role configured with DHCP in nic

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Networks with role configured with DHCP in nic ...................................................................... engine: Networks with role configured with DHCP in nic Network with roles must have an IP address in order for the host to be operational (either for display or for migration purposes). A mass operation to configure networks on various hosts, where some of the networks might have roles, is by setting the boot protocol to DHCP. This will configure the networks on the hosts in a way that will enable to IP assignment. If the DHCP request fails, there is a change the network will not be configure on the host. This will cause the host to be non-operational, with a simple resolution for the nature of the problem. Change-Id: I3ee53ec1f354ea766cea59977e869f97c2be94df Bug-Url: https://bugzilla.redhat.com/1073043 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ee53ec1f354ea766cea59977e869f97c2be94df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: VURTI - fix handle expection in GetVmStats

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: VURTI - fix handle expection in GetVmStats ...................................................................... core: VURTI - fix handle expection in GetVmStats after getting all vms with List command, VURTI loops through them to update internal structure data. BUT if the call fails, VURTI removes the VM from the internal running map - this leads to a split-brains for VURTI assumes the Vm is DOWN and if it HA, its runs it. the fix is to exclude this Vm from the list of the vms that have changed this is similar to a case where Vm didn't changed its status UNIT TEST added a unit test to make sure the VM is kept in the map although the call to GetVmStats didn't made it Bug-Url: https://bugzilla.redhat.com/1072282 Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 172 insertions(+), 40 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: VURTI - use ResourceManager instead of commands

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: VURTI - use ResourceManager instead of commands ...................................................................... core: VURTI - use ResourceManager instead of commands Use ResourceManager instead of direct command invocation Add List, GetVmStats and GetAllVmsStats to the list of Command Types Clean-up the code expressions, format, indent etc Bug-Url: https://bugzilla.redhat.com/1072282 Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 50 insertions(+), 48 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: [Fix] SPICE proxy wrong in Pool

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: [Fix] SPICE proxy wrong in Pool ...................................................................... webadmin: [Fix] SPICE proxy wrong in Pool SPICE proxy never shows the Global Configuration value, if the Cluster configuration value is not defined and Global Configuration value is defined. Change-Id: I3272259c2bd33799acf985d86ca6689cba294fe5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075222 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/BasePoolPopupPresenterWidget.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Gustavo Frederico Temple Pedrosa: Verified -- To view, visit http://gerrit.ovirt.org/25630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3272259c2bd33799acf985d86ca6689cba294fe5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: [Fix] SPICE proxy wrong in Pool

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: [Fix] SPICE proxy wrong in Pool ...................................................................... webadmin: [Fix] SPICE proxy wrong in Pool SPICE proxy never shows the Global Configuration value, if the Cluster configuration value is not defined and Global Configuration value is defined. Change-Id: I3272259c2bd33799acf985d86ca6689cba294fe5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075222 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/BasePoolPopupPresenterWidget.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Gustavo Frederico Temple Pedrosa: Verified -- To view, visit http://gerrit.ovirt.org/25631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3272259c2bd33799acf985d86ca6689cba294fe5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Setting missing severity to audit log...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: Setting missing severity to audit log... ...................................................................... core: Setting missing severity to audit log... Setting missing severity to audit log messages This patches adding settings for audit log severities that were logged as NORMAL messages instead of ERROR/WARNING Change-Id: Id0111351c8d83eeda0ae1a57538ef1eabe5d4001 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047889 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0111351c8d83eeda0ae1a57538ef1eabe5d4001 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: removing TWS from fixtures.xml

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: removing TWS from fixtures.xml ...................................................................... core: removing TWS from fixtures.xml Change-Id: I5c2d5224509e92cbce4afb8da2d20cf832979e51 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c2d5224509e92cbce4afb8da2d20cf832979e51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: log login failure to webadmin userportal...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: log login failure to webadmin userportal... ...................................................................... core: log login failure to webadmin userportal... Log login failure to webadmin userportal from UI/API This patch adds login of authentication failures such that failed attempts to login to the application from user portal or web admin will be recorded as well. Change-Id: I3ebefcad91d7e37d2e1bb2adf1708b950283b92e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066103 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginAdminUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 2 files changed, 17 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ebefcad91d7e37d2e1bb2adf1708b950283b92e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: enable to decrease DC compatibility...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: enable to decrease DC compatibility... ...................................................................... core: enable to decrease DC compatibility... enable to decrease DC compatibility version if DC has no clusters This patch enables to decrease the DC compatibility version if DC has no clusters. Change-Id: I73284f641b7f80b380b39efbbd7b4566f55119b6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057029 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Ravi Nori: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73284f641b7f80b380b39efbbd7b4566f55119b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2014