Change in ovirt-engine[master]: aaa: Fix group population
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Fix group population
......................................................................
aaa: Fix group population
The following patch fixes group population for users and groups -
a. It does not use DbFacade to get the external id - external id
should be retrieved from the directory
b. It runs the group population in all cases user information is populated
c. At group population - the recrusion is fixed/changed - the LdapGroup
object that is created is at ProceedGroupSearchResult , before making
the recursive calls at populateGroup.
Topic: AAA
Change-Id: I599fca005b27f6873cda3e5a46081de3357089b2
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchUserByQueryCommand.java
3 files changed, 29 insertions(+), 30 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25407
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I599fca005b27f6873cda3e5a46081de3357089b2
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Make PyDev project files ignored by git
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Make PyDev project files ignored by git
......................................................................
core: Make PyDev project files ignored by git
Make PyDev project files ignored by git adding .pydevproject to
.gitignore
Change-Id: I97323548e6e153c53745f69b4a3ac745162b5012
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97323548e6e153c53745f69b4a3ac745162b5012
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine[master]: core: Fix checkstyle error in LdapBrokerCommandBase
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix checkstyle error in LdapBrokerCommandBase
......................................................................
core: Fix checkstyle error in LdapBrokerCommandBase
Fix unused import error.
Change-Id: I47f398c3be2b430bccfe93d021051775a4eb686e
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25595
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47f398c3be2b430bccfe93d021051775a4eb686e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: Remove port if hot plug new ext. nic fails
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Remove port if hot plug new ext. nic fails
......................................................................
engine: Remove port if hot plug new ext. nic fails
If a new vNIC is added on an external network, and this vNIC is also hot
plugged as part of this flow then a corresponding entity will be created
on the external provider.
If the aforementioned action fails, the vNIC will be removed from the DB
(by compensation mechanism) but not from the external provider, leaving
garbage forever on it.
In this fix, a new vNIC that fails to hot plug will also be removed from
the external provider.
At this point, there is no need to remove an existing vNIC
should the hot plug fail, as the entity that was created on the external
provider should be removed only when the vNIC is being removed, or the
network is not used by the vNIC anymore.
Change-Id: Iddeac63a47286e9b83ac02fb2e55f7dd56092805
Bug-Url: https://bugzilla.redhat.com/987814
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java
5 files changed, 58 insertions(+), 21 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddeac63a47286e9b83ac02fb2e55f7dd56092805
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-reports[ovirt-3.3]: packaging: setup: check service status by rc
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: check service status by rc
......................................................................
packaging: setup: check service status by rc
Before this change, the status of services was checked by searching for
keywords in the output of 'service $service status'. This didn't work
well on locales where the output did not contain the expected keywords.
With this change we only check the return code of that command.
Bug-Url: https://bugzilla.redhat.com/1074909
Change-Id: I3c7365cb7947a2d79bfaffa669f28ae4a8aa3ba3
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/common_utils.py
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c7365cb7947a2d79bfaffa669f28ae4a8aa3ba3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 8 months
Change in ovirt-reports[master]: build: ovirt-engine-reports-3.4.0-1
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: ovirt-engine-reports-3.4.0-1
......................................................................
build: ovirt-engine-reports-3.4.0-1
Also added release notes.
Change-Id: I8d0ec18bd1fbe9d4d2d39f1c349f01f86403dd27
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M version.mak
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d0ec18bd1fbe9d4d2d39f1c349f01f86403dd27
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: aaa: Moved DomainsPasswordMap to utils
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Moved DomainsPasswordMap to utils
......................................................................
aaa: Moved DomainsPasswordMap to utils
Not only dal uses this , but also vdsbroker and bll.
It has no db specific code, but rather depeneds on encrypt utils
which is part of utils.
Topic: AAA
Change-Id: Iaa7b65e62f9dd6a1bf3557631558715e5ca18d46
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/DomainsPasswordMap.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java
4 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa7b65e62f9dd6a1bf3557631558715e5ca18d46
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: aaa: Extracted session management outside of AdBroker package
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Extracted session management outside of AdBroker package
......................................................................
aaa: Extracted session management outside of AdBroker package
a. All LdapBroker commands that are not LdapAuthenticateUserCommand
should use the user associated with the domain -
no need to session management here (the user is kept at
UsersDomainsCacheManagerService)
b. For the LdapAuthenticateUserCommand - the code is extracted to the bll
LoginBaseCommand
Topic: AAA
Change-Id: I82003f1b91847d3f75d99e2b02eb238ab050d62e
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
3 files changed, 32 insertions(+), 28 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25505
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82003f1b91847d3f75d99e2b02eb238ab050d62e
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: aaa: Fix Audit log and can do action msgs handling in ldap b...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Fix Audit log and can do action msgs handling in ldap broker.
......................................................................
aaa: Fix Audit log and can do action msgs handling in ldap broker.
The following patch introduces AAAExtensionException that will be thrown from AAA Extensiosn.
In addition, audit log handling for login failures was extracted to the BLL command of LoginBaseCommand.
Based on the AuthenticationResult enum, the Ldap broker throws a proper AAAExtensionException
which is translated to both audit log and can do action message (VdcBllMessage) at LoginBaseCommand.
Proper VdcBllMessagwes were added where needed.
Topic: AAA
Change-Id: I8b0b024d27a92f620bb60e4689264bc6b3c3eda1
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/PasswordAuthenticator.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalAuthenticator.java
D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopAuthenticationResult.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopAuthenticator.java
D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/result/BooleanAuthenticationResult.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticationResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchExceptionHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
A backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/AAAExtensionException.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Extension.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
20 files changed, 255 insertions(+), 254 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b0b024d27a92f620bb60e4689264bc6b3c3eda1
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: restapi : Missing opertions for snapshots in RESTAPI
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: restapi : Missing opertions for snapshots in RESTAPI
......................................................................
restapi : Missing opertions for snapshots in RESTAPI
In RESTAPI some opertions for snapshot are missing which are
available in webadmin.
This patch adds preview, commit and undo operations to the
snapshot resource.
Change-Id: If8c6d25daf7e716a7c857295b6ceb1741cbaf7f7
Bug-Url: https://bugzilla.redhat.com/867339
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
5 files changed, 130 insertions(+), 1 deletion(-)
Approvals:
Ori Liel: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/24056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8c6d25daf7e716a7c857295b6ceb1741cbaf7f7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months