March 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: set DC compatability version to latest...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: set DC compatability version to latest... ...................................................................... core: set DC compatability version to latest... Set DC compatibility version to latest when null Up to now when adding a DC from API without giving explicitly the compatibility version was resulted in a failure on unsupported version. This patch changes this behaviour by setting the latest version as a default if a null was given for compatibility version. Change-Id: I53373e9ce2563d91a96353f068cd19069508399d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1053062 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Juan Hernandez: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53373e9ce2563d91a96353f068cd19069508399d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Collect stats based on non-operational reason

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Collect stats based on non-operational reason ...................................................................... engine: Collect stats based on non-operational reason If a host become non-operational due to network issue, the statistics will not be collected any more. Therefore any attempt to activate the host by the Auto-Recovery manager will be skipped. Even if the network issue will be solved, the host will remain non-operational unless activated by the user. This patch will allow to examine the cause for the non- operational status and continue stats collection to assure a network issue was solved and re-attempt to activate the host. Change-Id: I407d165e1cf13bbd1ba50811eaed4771c3f36f1a Bug-Url: https://bugzilla.redhat.com/1070260 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 5 files changed, 28 insertions(+), 19 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I407d165e1cf13bbd1ba50811eaed4771c3f36f1a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: resouces of VMs in launch state shouldn't be committed

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: resouces of VMs in launch state shouldn't be committed ...................................................................... core: resouces of VMs in launch state shouldn't be committed Currently we count pending in scheduling process, and committed memory is calculated in server side according to VMs attached to the host (including VMs in wait for launch state- host in VM entity is update when CreateVm command returns from VDSM). Pending memory is being release in powering-up state, so in fact we count resources twice: since the time VM is in wait for launch till it's powering up. Memory commitment in VDSM occurs after a vm was requested, so using this data will eliminate VM throttling that failed to reach powering up state. Change-Id: Ie2db20c213ac326d620fad578bb5c1c78ff0b3bc Bug-Url: https://bugzilla.redhat.com/1074478 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2db20c213ac326d620fad578bb5c1c78ff0b3bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Use predefined ISO domains list in import storage ...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Use predefined ISO domains list in import storage domain dialog ...................................................................... webadmin: Use predefined ISO domains list in import storage domain dialog Change-Id: Ibdf777e808a2cfb49c08d9209d27b3b85943581d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Related-To: https://bugzilla.redhat.com/1063288 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdf777e808a2cfb49c08d9209d27b3b85943581d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: VURTI - fix handle expection in GetVmStats

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: VURTI - fix handle expection in GetVmStats ...................................................................... core: VURTI - fix handle expection in GetVmStats after getting all vms with List command, VURTI loops through them to update internal structure data. BUT if the call fails, VURTI removes the VM from the internal running map - this leads to a split-brains for VURTI assumes the Vm is DOWN and if it HA, its runs it. the fix is to exclude this Vm from the list of the vms that have changed this is similar to a case where Vm didn't changed its status UNIT TEST added a unit test to make sure the VM is kept in the map although the call to GetVmStats didn't made it Bug-Url: https://bugzilla.redhat.com/1072282 Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 172 insertions(+), 40 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: VURTI - use ResourceManager instead of commands

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: VURTI - use ResourceManager instead of commands ...................................................................... core: VURTI - use ResourceManager instead of commands Use ResourceManager instead of direct command invocation Add List, GetVmStats and GetAllVmsStats to the list of Command Types Clean-up the code expressions, format, indent etc Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 49 insertions(+), 48 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-reports[master]: packaging: setup: Install -> Configure

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Install -> Configure ...................................................................... packaging: setup: Install -> Configure Change-Id: I22e93748bfec5f1598c989861d96865ae694455b Bug-Url: https://bugzilla.redhat.com/1064876 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/misc.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22e93748bfec5f1598c989861d96865ae694455b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 8 months

1
0
0 / 0

Change in ovirt-dwh[master]: packaging: setup: Install -> Configure

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Install -> Configure ...................................................................... packaging: setup: Install -> Configure Change-Id: I78eaeda47cee822b52a02e7e5bee477ed0e9de3c Bug-Url: https://bugzilla.redhat.com/1064876 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78eaeda47cee822b52a02e7e5bee477ed0e9de3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Change Vm status on destroy only for SRC VMs

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: Change Vm status on destroy only for SRC VMs ...................................................................... core: Change Vm status on destroy only for SRC VMs when stopping a migrating VMs, do the state change only if the VM is really running on SRC host. StopVm shoots 2 destroy commands incase the vm is migrating - 1 for the DST and one for the SRC. after the DST is destroy the Vm must not be DOWN, otherwise an interleaving RunVm could start it while we're about to shoot the next stop. that solution is reverting change I6109ef0ea4869b59a93be6fef4b0c3cff50da62e which implemented that with an engine lock Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Bug-url: https://bugzilla.redhat.com/1064859 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: Revert "core: Prevent StopVm to interleave with other VM loc...

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: Revert "core: Prevent StopVm to interleave with other VM locked actions" ...................................................................... Revert "core: Prevent StopVm to interleave with other VM locked actions" This reverts commit 37411acc82c03ba8e3150e5d9b4aad2e6d39a414. Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 3 files changed, 1 insertion(+), 20 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2014