Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: ovf: allow empty image description
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovf: allow empty image description
......................................................................
ovf: allow empty image description
Change-Id: I05558503bcbe99d7b35087da5703c0dd5655944f
Bug-Url: https://bugzilla.redhat.com/1147468
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit e2189302509bd2058160a8ccdd5b9b4a2e6b82b0)
---
M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
1 file changed, 13 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05558503bcbe99d7b35087da5703c0dd5655944f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-hosted-engine-setup[master]: ovf: allow empty image description
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovf: allow empty image description
......................................................................
ovf: allow empty image description
Change-Id: I05558503bcbe99d7b35087da5703c0dd5655944f
Bug-Url: https://bugzilla.redhat.com/1147468
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
1 file changed, 13 insertions(+), 5 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05558503bcbe99d7b35087da5703c0dd5655944f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core : Welcome page should use base reports URL
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : Welcome page should use base reports URL
......................................................................
core : Welcome page should use base reports URL
Welcome page should redirect user to base
reports url from reports portal link
Change-Id: I732df3a7d6ebec5915be21bb945889d8660c615c
Bug-Url: https://bugzilla.redhat.com/1116851
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
2 files changed, 15 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Yaniv Dary: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I732df3a7d6ebec5915be21bb945889d8660c615c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core, webadmin : Fix issues with reports integration
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: core, webadmin : Fix issues with reports integration
......................................................................
core, webadmin : Fix issues with reports integration
Reports tab and right click reports generation
need to use different url to access reports.
Reports tab is not updated when clicking on
system tree. Sometimes null uri is sent to
reports.
Change-Id: Id5e91aa80dcd4e4d4f175d0193e92d19e65281e6
Bug-Url: https://bugzilla.redhat.com/1116851
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java
M packaging/services/ovirt-engine/ovirt-engine.conf.in
7 files changed, 59 insertions(+), 44 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5e91aa80dcd4e4d4f175d0193e92d19e65281e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Show correct tooltip in disks tab when a disk is u...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Show correct tooltip in disks tab when a disk is unattached
......................................................................
webadmin: Show correct tooltip in disks tab when a disk is unattached
Bug-Url: https://bugzilla.redhat.com/1140093
Change-Id: Ibc9858297ff9f4cace04707a8894c95429bf2422
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc9858297ff9f4cace04707a8894c95429bf2422
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-guest-agent[ovirt-3.5]: win: Enable policy for software SAS
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win: Enable policy for software SAS
......................................................................
win: Enable policy for software SAS
On some systems the policy for enabling the Secure Attention Sequence
might not have been set or has been set to a value which would not allow
the guest agent to perform SSO.
This patch introduces setting the policy before calling 'SendSAS' and
reverting the policy to the previous value (in case it was set before).
Change-Id: Ie2b5f58e461c92e06789d46fa9113441ea48e659
Bug-Url: https://bugzilla.redhat.com/1124263
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 35 insertions(+), 7 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b5f58e461c92e06789d46fa9113441ea48e659
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: core: persist disk image parameters for live migration
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: persist disk image parameters for live migration
......................................................................
core: persist disk image parameters for live migration
DiskImage's Disk Profile and Quota wasn't updated.
Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7
Bug-Url: https://bugzilla.redhat.com/1145694
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
(cherry picked from commit 2df230f0245e693455e7fc00bfe82157b0180a1e)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
1 file changed, 24 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/33530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core:fixing step numbering for steps and sub-steps
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core:fixing step numbering for steps and sub-steps
......................................................................
core:fixing step numbering for steps and sub-steps
When a step is added to a job, it should get its step_number value
according to the existing steps already added to the job.
The same is for adding sub-step to an exiting step.
This patch fix a problem in adding step/sub-step when all added
steps/sub-steps get a 0 for the step_number value.
This resulted in incorrect order of steps and sub-steps in the UI while
steps where ordered by the step_number but this had no affect
since the step_number was always 0.
Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1143035
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
3 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: persist disk image parameters for live migration
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: persist disk image parameters for live migration
......................................................................
core: persist disk image parameters for live migration
DiskImage's Disk Profile and Quota wasn't updated.
Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7
Bug-Url: https://bugzilla.redhat.com/1145694
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
1 file changed, 24 insertions(+), 5 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33483
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Do not attempt to extend a block domain if LUNs dat...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Do not attempt to extend a block domain if LUNs data not supplied
......................................................................
restapi: Do not attempt to extend a block domain if LUNs data not supplied
When editing a block domain via REST, in case the storage data was not
supplied there is still a comparison between the old an new LUNs which
results in an NPE, in that case we just skip the comparison if the data
was not sent in the request
Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326
Bug-Url: https://bugzilla.redhat.com/1115966
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months