Change in ovirt-engine[master]: core: WAD in RemoveDiskSnapshotTaskHandler
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: WAD in RemoveDiskSnapshotTaskHandler
......................................................................
core: WAD in RemoveDiskSnapshotTaskHandler
Added a call to setWipeAfterDelete in
RemoveDiskSnapshotTaskHandler.buildRemoveSnapshotSingleDiskParameters.
Change-Id: Ib3f6896c4ad64ca5d3515b865dbab469d236100b
Bug-Url: https://bugzilla.redhat.com/1141702
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotTaskHandler.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit http://gerrit.ovirt.org/32930
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3f6896c4ad64ca5d3515b865dbab469d236100b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Small logic fix when reassigning roles
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Small logic fix when reassigning roles
......................................................................
webadmin: Small logic fix when reassigning roles
Previous fix implicitly relied on the state of the sent entity too
much, now comparison is made with the entity as stored in the DB.
Change-Id: I99bceea9f35f2356897a21c6e6e7f2f051f3f37d
Bug-Url: https://bugzilla.redhat.com/1135785
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/32925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99bceea9f35f2356897a21c6e6e7f2f051f3f37d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: make AuthenticationProfileRepository observable
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: make AuthenticationProfileRepository observable
......................................................................
aaa: make AuthenticationProfileRepository observable
cleanup negotiation filter to update dynamically, as it is not enough to
do lazy, per early requests.
modify observer usage to use local inline object instead of effecting
entire class.
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I04db3fcb60a2199d5a4af042b589a30023e29ff5
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
2 files changed, 47 insertions(+), 51 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04db3fcb60a2199d5a4af042b589a30023e29ff5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: add authn negotiation priority
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: add authn negotiation priority
......................................................................
aaa: add authn negotiation priority
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I1bb8803e44fbc75ff91c0b6791491ced58eff6d5
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java
3 files changed, 27 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bb8803e44fbc75ff91c0b6791491ced58eff6d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: extapi: move authn config keys into api
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: extapi: move authn config keys into api
......................................................................
extapi: move authn config keys into api
sync with Base.
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I5f9104dae94d5992690efbb89b0867ba77926384
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java
3 files changed, 18 insertions(+), 8 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f9104dae94d5992690efbb89b0867ba77926384
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: filters: cleanup: use profile object directly
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: filters: cleanup: use profile object directly
......................................................................
aaa: filters: cleanup: use profile object directly
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I2ba90ceadbcca5e63c85bf6b6f913dd0f5a147b0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
1 file changed, 6 insertions(+), 9 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ba90ceadbcca5e63c85bf6b6f913dd0f5a147b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: cleanup: remove unused function
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: cleanup: remove unused function
......................................................................
aaa: cleanup: remove unused function
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I03ce61dbddc74704e641c43b0aa037c1b49c5319
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03ce61dbddc74704e641c43b0aa037c1b49c5319
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-dwh[master]: packaging: setup: use env statement at misc in single_etl
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: use env statement at misc in single_etl
......................................................................
packaging: setup: use env statement at misc in single_etl
misc stage runs also if new_database, where self._statement is not set.
Change-Id: Iaedbda91fcd055f31069bee7afab75ade5891959
Bug-Url: https://bugzilla.redhat.com/1118350
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/single_etl.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/32820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaedbda91fcd055f31069bee7afab75ade5891959
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Marshalling regression on fenceNode
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Marshalling regression on fenceNode
......................................................................
core: Marshalling regression on fenceNode
Change-Id: If9a1bc5a818a122a75f8f02385cfcfc26b003400
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Martin Peřina: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9a1bc5a818a122a75f8f02385cfcfc26b003400
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Fix typo in ImportVmCommandTest
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix typo in ImportVmCommandTest
......................................................................
core: Fix typo in ImportVmCommandTest
s/deivce/device
Change-Id: Ie42fb701e5791b4b311ff069dd889a90d5930a4a
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie42fb701e5791b4b311ff069dd889a90d5930a4a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months