Change in ovirt-engine[master]: core: ImportVmCommand storage allocation checks
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVmCommand storage allocation checks
......................................................................
core: ImportVmCommand storage allocation checks
This patch is a part of a series of patches, adding storage allocation
validations to the system when they're missing, and replacing old
verification usage with unified, new, correct and tested verification.
This patch did this for ImportVmCommand, while added new space allocation
validation to storage domain validators regarding snapshoted disks to be
cloned with the spnapshots. Tests were amended accordingly.
Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f
Bug-Url: https://bugzilla.redhat.com/1053746
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java
9 files changed, 324 insertions(+), 64 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/32258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: fixing bug no validation AddSubnetToProvider
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: fixing bug no validation AddSubnetToProvider
......................................................................
webadmin: fixing bug no validation AddSubnetToProvider
validating subnet fields are valid before preforming command
Change-Id: Iaac8748c9b47dfc7a622efaa887980333f5bc56d
Bug-Url: https://bugzilla.redhat.com/1138981
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eliraz Levi: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaac8748c9b47dfc7a622efaa887980333f5bc56d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: positive affinity breaks maintenancing a host
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: positive affinity breaks maintenancing a host
......................................................................
core: positive affinity breaks maintenancing a host
I feel that this is best to describe with an example: vm1, vm2 running
with enforcing positive affinity group on host A.
When putting host A to maintenance, both VMs will try to migrate,
and fail because they're violating the affinity constraints.
the host is stuck on preparing for maint.
The fix ignores the host when it's in preparing for maint status.
Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e
Bug-Url: https://bugzilla.redhat.com/1084794
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26623
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Add missing VDSM error message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add missing VDSM error message
......................................................................
core: Add missing VDSM error message
Added StorageDomainTargetUnsupported message which was missing from the
VDSM error message in core and webadmin
Change-Id: Icef1c04f1252722f12431000d8464359efb72a92
Bug-Url: https://bugzilla.redhat.com/985437
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
4 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icef1c04f1252722f12431000d8464359efb72a92
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Add missing VDSM error message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add missing VDSM error message
......................................................................
core: Add missing VDSM error message
Added StorageDomainTargetUnsupported message which was missing from the
VDSM error message in core and webadmin
Change-Id: Icef1c04f1252722f12431000d8464359efb72a92
Bug-Url: https://bugzilla.redhat.com/985437
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
4 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icef1c04f1252722f12431000d8464359efb72a92
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Represent slave's mac in lower case
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Represent slave's mac in lower case
......................................................................
engine: Represent slave's mac in lower case
slave's mac in older vdsm versions, is in upper case, resulting
slave's mac is saved and represented in upper case
Change-Id: Ibfebc2aea4bc3605253bfb072fc4ad19c0fd2270
Bug-Url: https://bugzilla.redhat.com/1132422
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Eliraz Levi: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfebc2aea4bc3605253bfb072fc4ad19c0fd2270
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Parameterize ImportNetworksModel and related classes
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Parameterize ImportNetworksModel and related classes
......................................................................
webadmin: Parameterize ImportNetworksModel and related classes
Parameterized generic instances of ListModel in ImportNetworksModel,
as well as the corresponding view and widget used in that view (and
nowhere else at the moment, which made things easier).
ExternalNetwork is changed to extend Model instead of EntityModel (as
it used no special capabilities of EntityModel).
Change-Id: I4d1e6e409edc794baa799807268755105f8e21fa
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ExternalNetwork.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
5 files changed, 91 insertions(+), 92 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1e6e409edc794baa799807268755105f8e21fa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Cleanup around Setup Networks events
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Cleanup around Setup Networks events
......................................................................
webadmin: Cleanup around Setup Networks events
* Removed NetworksChanged event that wasn't used for anything.
* Parameterized generic events.
* Fixed typo in OperationCandidateEventArgs name.
Change-Id: I23945cb33eea895b216ab78fbbca5a6a26300c7c
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
R frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCandidateEventArgs.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
3 files changed, 23 insertions(+), 36 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23945cb33eea895b216ab78fbbca5a6a26300c7c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Disable buttons on ghost entry
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Disable buttons on ghost entry
......................................................................
webadmin: Disable buttons on ghost entry
A relatively recent refactoring/enhancement caused a small regression
in several widgets, this is now fixed by calling superclass
implementation of toggleGhost() (or not overriding it to do
nothing). That patch wasn't pushed to ovirt-engine-3.5, so this is not
an issue there.
Change-Id: Iafe35b1f4bdbee8068ea79629342518ca3405a62
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java
3 files changed, 1 insertion(+), 10 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/32404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafe35b1f4bdbee8068ea79629342518ca3405a62
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-node-plugin-vdsm[ovirt-3.5]: engine_page: augeas set copy_if_rename_fails
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: engine_page: augeas set copy_if_rename_fails
......................................................................
engine_page: augeas set copy_if_rename_fails
Avoid issues with bind mounting before editing files.
Change-Id: Ic500a92aaff60a24d5d1dbd444b3397e9706a198
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic500a92aaff60a24d5d1dbd444b3397e9706a198
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months