Change in ovirt-engine[master]: engine : CoCo: Set status at end of command execution
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : CoCo: Set status at end of command execution
......................................................................
engine : CoCo: Set status at end of command execution
Set status of commands without child commands and
commands without command callbacks at the end of command
execution
Change-Id: Ifc3960568993baf888a3d9f74e7fad4bd0589823
Bug-Url: https://bugzilla.redhat.com/1133041
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc3960568993baf888a3d9f74e7fad4bd0589823
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-host-deploy[master]: build: update-po
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: update-po
......................................................................
build: update-po
Change-Id: I4520a13a4f203930866cb5a46cb332e6a14b0c74
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M po/POTFILES.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32591
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4520a13a4f203930866cb5a46cb332e6a14b0c74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Updating default storage type question
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: Updating default storage type question
......................................................................
packaging: setup: Updating default storage type question
Previous releases handle different storage pool type,
now it handles only Local/Shared.
Change-Id: I1fa88c96fc7e8d799fa2bd777b951bb1e29e0703
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1102021
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/dbscripts/inst_sp.sql
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py
4 files changed, 41 insertions(+), 22 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fa88c96fc7e8d799fa2bd777b951bb1e29e0703
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: changeing vm_type and os_type did reset the dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: changeing vm_type and os_type did reset the dialog
......................................................................
webadmin: changeing vm_type and os_type did reset the dialog
For change of os type:
The problem was that the change of the vm_type in the vm dialog triggered the
InstanceTypeManager.updateFields().
It was not correct since this caused the whole dialog to be re-inited from the
selected instance type/template (depending on the actual selection) and that
should happen only after "big" changes like cluster change which changes
availability of some fields.
Since the vm type only provides some defaults for the fields and not the
availability of the fields, there is no need to go through the instance type
manager - just simply set the fields up.
For the os type:
Similar but a bit more tricky. There are some fields which are actually
provided from instance type. So if the os type changes, in case the selected
instance type is not custom, it should set the "IsChangable" flag and let the
instance type manager to copy the corresponding fields. But not all to avoid
the dialog will be reset again - only the ones related to the os change.
Change-Id: I5859ca02ddcbeb60583a0e79b94f7b9f2647596a
Bug-Url: https://bugzilla.redhat.com/1125344
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewPoolInstanceTypeManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewVmInstanceTypeManager.java
6 files changed, 94 insertions(+), 37 deletions(-)
Approvals:
Tomas Jelinek: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5859ca02ddcbeb60583a0e79b94f7b9f2647596a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: Add additional exception to prevent socket.gaierror error
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add additional exception to prevent socket.gaierror error
......................................................................
Add additional exception to prevent socket.gaierror error
In time of second host, you need to pass FQDN of first host to
receive answer file, but FQDN not pass any validation and can be
incorrect, it will lead to socket.gaierror in socket.getaddrinfo
method.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136015
Change-Id: I92776791af606b6fdb664c9e44ed119a167d15ac
Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 38995557e4623003f9dbba5f5ff07063fffe948f)
---
M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py
1 file changed, 10 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32588
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92776791af606b6fdb664c9e44ed119a167d15ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-hosted-engine-setup[master]: Add additional exception to prevent socket.gaierror error
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add additional exception to prevent socket.gaierror error
......................................................................
Add additional exception to prevent socket.gaierror error
In time of second host, you need to pass FQDN of first host to
receive answer file, but FQDN not pass any validation and can be
incorrect, it will lead to socket.gaierror in socket.getaddrinfo
method.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136015
Change-Id: I92776791af606b6fdb664c9e44ed119a167d15ac
Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py
1 file changed, 10 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92776791af606b6fdb664c9e44ed119a167d15ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in otopi[master]: core: Alert if priorities were overridden
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: Alert if priorities were overridden
......................................................................
core: Alert if priorities were overridden
During buildSequence, warn or optionally abort, if the final sequence
has methods ordered in reverse to their priorities. This might happen if
the priorities conflict with before/after.
Change-Id: I5610d172ee6dd8765beefb8b27a9a94395b232e2
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/otopi/constants.py
M src/otopi/context.py
2 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/29180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5610d172ee6dd8765beefb8b27a9a94395b232e2
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: core: remove unused field, diskSize, from VmStatic
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove unused field, diskSize, from VmStatic
......................................................................
core: remove unused field, diskSize, from VmStatic
Change-Id: Idb1c7894b1efd5f2cc3132a5f899689288be1ef7
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
2 files changed, 0 insertions(+), 16 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/32575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb1c7894b1efd5f2cc3132a5f899689288be1ef7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Fix layout of 'MTU' field in Network dialog
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Fix layout of 'MTU' field in Network dialog
......................................................................
webadmin: Fix layout of 'MTU' field in Network dialog
Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003
Bug-Url: https://bugzilla.redhat.com/1127587
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
2 files changed, 18 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: ExportVmTemplateCommand storage allocations
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ExportVmTemplateCommand storage allocations
......................................................................
core: ExportVmTemplateCommand storage allocations
MoveOrCopyTemplateCommand.canDoAction() small fix:
Fixed storage domain space verification. Using StorageDomainValidator
for some other storage verification, instead of (p)re-inventing the
wheel.
ExportVmTemplate inherits and therefore is affected by this.
Change-Id: Ic5de81b318d5b8a2e0da918b4a44ae2003ca4b06
Bug-Url: https://bugzilla.redhat.com/1136717
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
1 file changed, 11 insertions(+), 9 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5de81b318d5b8a2e0da918b4a44ae2003ca4b06
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months