Change in ovirt-reports[ovirt-engine-reports-3.4]: build: post ovirt-engine-reports-3.4.4 rc
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: post ovirt-engine-reports-3.4.4 rc
......................................................................
build: post ovirt-engine-reports-3.4.4 rc
Change-Id: I8c761560caa7f0193c3b76a4dc11f918f9828ab9
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, …
[View More]visit http://gerrit.ovirt.org/32590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c761560caa7f0193c3b76a4dc11f918f9828ab9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.4
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
[View Less]
10 years, 8 months
Change in ovirt-reports[ovirt-engine-reports-3.4]: build: ovirt-engine-reports-3.4.4 rc
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: ovirt-engine-reports-3.4.4 rc
......................................................................
build: ovirt-engine-reports-3.4.4 rc
Change-Id: I269462c4c3dd68b43e45a59ab1d3536c3d443c78
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit …
[View More]http://gerrit.ovirt.org/32589
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I269462c4c3dd68b43e45a59ab1d3536c3d443c78
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.4
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: core: fix CVE-2014-3573
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: fix CVE-2014-3573
......................................................................
core: fix CVE-2014-3573
single place in which DocumentBuilderFactory is constructed to apply
security settings.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139000
Change-Id: Icf27db1ec13b6a16d9b7c77fd9710e8e6f6ec3c9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/…
[View More]java/org/ovirt/engine/core/bll/InstallerMessages.java
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java
M backend/manager/modules/restapi/interface/definition/src/main/modules/org/ovirt/engine/api/restapi-definition/main/module.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/XmlUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlDocument.java
A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/xml/SecureDocumentBuilderFactory.java
7 files changed, 36 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf27db1ec13b6a16d9b7c77fd9710e8e6f6ec3c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: engine, webadmin: Plugging of an unlinked vnic with an ext ne...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine,webadmin: Plugging of an unlinked vnic with an ext net is blocked
......................................................................
engine,webadmin: Plugging of an unlinked vnic with an ext net is blocked
Plugged and unlinked VM network interface is not supported for an
external network, thus the action is blocked.
Change-Id: Ia944ca7e0430adc54a6cae6cb65b8a1df4e88d24
Bug-Url: https://bugzilla.redhat.com/…
[View More]1077796
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/32032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia944ca7e0430adc54a6cae6cb65b8a1df4e88d24
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: core: remove AddVmFromTemplateParameters
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove AddVmFromTemplateParameters
......................................................................
core: remove AddVmFromTemplateParameters
No need for this parameters class, VmManagementParametersBase will
be used instead.
Change-Id: I9241a0f402e829e9b029cbecf8cc05e10d6a6dda
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/…
[View More]AddVmFromTemplateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromTemplateParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
8 files changed, 21 insertions(+), 58 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/32491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9241a0f402e829e9b029cbecf8cc05e10d6a6dda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix vNIC widget behavior
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix vNIC widget behavior
......................................................................
webadmin: Fix vNIC widget behavior
The relatively recent adjustment of the widget to allow
arbitrary-length labels caused labels to always appear as enabled -
this patch properly renders them again.
Change-Id: I76cf6c99f5e894470396751fee533e67f04bbcb3
Bug-Url: https://bugzilla.redhat.com/1086259
Signed-off-by: Lior …
[View More]Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextOverflow.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java
2 files changed, 16 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31891
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76cf6c99f5e894470396751fee533e67f04bbcb3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Make reinstall dialog slightly bigger
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Make reinstall dialog slightly bigger
......................................................................
webadmin: Make reinstall dialog slightly bigger
This to obviate a scroll bar that appears when selecting a provider.
Change-Id: Icdaba03bcefb5f65ca4bdecb7008b48c7a0758d1
Bug-Url: https://bugzilla.redhat.com/1117399
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
(cherry picked from commit …
[View More]d8a4fdaa3ed5b3c22260b583e42c538237a65a53)
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/32364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdaba03bcefb5f65ca4bdecb7008b48c7a0758d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-iso-uploader[master]: ovirt-iso-uploader: fixing usage of API SDK insecure parameter
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-iso-uploader: fixing usage of API SDK insecure parameter
......................................................................
ovirt-iso-uploader: fixing usage of API SDK insecure parameter
Python SDK insecure parameter simply skips hostname validation,
it still gives errors if we also pass an unmatching CA cert.
Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16
Bug-Url: https://bugzilla.redhat.com/…
[View More]1136768
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/__main__.py
1 file changed, 17 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/32349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: engine : Children of callback commands should not have callb...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Children of callback commands should not have callback enabled by default
......................................................................
engine : Children of callback commands should not have callback enabled by default
Children of commands with callback should have callback
enabled only if they have custom callbacks implemented
Change-Id: Ib6c0f1e42572dfa51b50d2e6cc9531a81c2f5aad
Bug-Url: https://…
[View More]bugzilla.redhat.com/1133041
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6c0f1e42572dfa51b50d2e6cc9531a81c2f5aad
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: engine : Persist commands with callbacks automatically
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Persist commands with callbacks automatically
......................................................................
engine : Persist commands with callbacks automatically
Persist commands with callbacks automatically when
the command is executed
Change-Id: Ic4f56ec11d295baae513e7552f93a5bf9b81d384
Bug-Url: https://bugzilla.redhat.com/1133041
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/…
[View More]manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4f56ec11d295baae513e7552f93a5bf9b81d384
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months