Change in ovirt-engine[master]: extapi: Changing fetch principal to support principal
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: extapi: Changing fetch principal to support principal
......................................................................
extapi: Changing fetch principal to support principal
Change-Id: I6d2b532f56ef5b3a38af79ef869c5a5c8bf526bf
Bug-Url: https://bugzilla.redhat.com/1127623
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d2b532f56ef5b3a38af79ef869c5a5c8bf526bf
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: fix coverity issues
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fix coverity issues
......................................................................
webadmin: fix coverity issues
- Fixed potential divide by 0 in QuotaProgressBar.
- Fixed potential npe in PolicyUnitPanel.
- Fixed a couple of unchecked cast issues.
Change-Id: I7359a63d79a86dc2e6106befde4d7044abe499e6
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java
5 files changed, 22 insertions(+), 16 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7359a63d79a86dc2e6106befde4d7044abe499e6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: services: add proxy servlet
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: services: add proxy servlet
......................................................................
services: add proxy servlet
a proxy servlet that proxy into url appending query string.
example of usage:
<servlet>
<servlet-name>google1</servlet-name>
<servlet-class>org.ovirt.engine.core.services.ProxyServlet</servlet-class>
<init-param>
<param-name>url</param-name>
<param-value>https://www.google.com/</param-value>
</init-param>
<init-param>
<param-name>trustStoreType</param-name>
<param-value>%{ENGINE_PKI_TRUST_STORE_TYPE}</param-value>
</init-param>
<init-param>
<param-name>trustStore</param-name>
<param-value>%{ENGINE_PKI_TRUST_STORE}</param-value>
</init-param>
<init-param>
<param-name>trustStorePassword</param-name>
<param-value>%{ENGINE_PKI_TRUST_STORE_PASSWORD}</param-value>
</init-param>
</servlet>
<servlet-mapping>
<servlet-name>google1</servlet-name>
<url-pattern>/google1</url-pattern>
</servlet-mapping>
Change-Id: Ia26768ec7a0e06a20f657cae40f6a51303970b44
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
A backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ProxyServlet.java
M backend/manager/modules/uutils/pom.xml
A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java
M backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml
4 files changed, 295 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Ravi Nori: Verified; Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26768ec7a0e06a20f657cae40f6a51303970b44
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine, webadmin: Webadmin read reports.xml from remote repo...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine, webadmin: Webadmin read reports.xml from remote reports app
......................................................................
engine, webadmin: Webadmin read reports.xml from remote reports app
in 3.5 report can be installed in separate server.
Webadmin needs to be able to read reports.xml from
that location via http.
Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3
Bug-Url: https://bugzilla.redhat.com/1116851
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
D backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ReportsRedirectServlet.java
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/utils/exclude-filters.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListWithDetailsAndReportsModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListWithReportsModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/form/PostableFrame.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/services/ovirt-engine/ovirt-engine.conf.in
28 files changed, 368 insertions(+), 190 deletions(-)
Approvals:
Ravi Nori: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: 'Add Users and Groups' dialog the column size shou...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: 'Add Users and Groups' dialog the column size should be limited
......................................................................
webadmin: 'Add Users and Groups' dialog the column size should be limited
The column with the long name looks long
and we need to scroll right/left to see
the other columns
Change-Id: Ia3009bffce854cc99031ad6571affea328c437d1
Bug-Url: https://bugzilla.redhat.com/1126283
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3009bffce854cc99031ad6571affea328c437d1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: common: allow spaces for affiniy group desc
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: common: allow spaces for affiniy group desc
......................................................................
common: allow spaces for affiniy group desc
Change-Id: I80fc31a9b1880f1f0da8cec9d3431316c156ad77
Bug-Url: https://bugzilla.redhat.com/1129012
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/32314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80fc31a9b1880f1f0da8cec9d3431316c156ad77
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Change reorder vNIC action's permissions
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Change reorder vNIC action's permissions
......................................................................
engine: Change reorder vNIC action's permissions
Changed the aforementioned action to belong to ActionGroup.CREATE_VM
rather than ActionGroup.CONFIGURE_VM_NETWORK, as it's an integral part
of the process of creating a VM (it shouldn't be called in the context
of a pre-existing VM in order to re-arrange its NICs).
This might seem askew - this whole command can (and likely should) be
a part of the Create VM command, if that is changed to receive as a
parameter a list of NICs to create.
Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468
Bug-Url: https://bugzilla.redhat.com/1134554
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Remove BusinessEntityGuidComparator class
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Remove BusinessEntityGuidComparator class
......................................................................
core: Remove BusinessEntityGuidComparator class
Remove BusinessEntityGuidComparator that can be replaced in all cases
with the more generic BusinessEntityComparator with inferred types.
Change-Id: I733bfbfdee01aa4c0bef344319e1dd471a3f2d79
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityGuidComparator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java
6 files changed, 10 insertions(+), 23 deletions(-)
Approvals:
Martin Betak: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I733bfbfdee01aa4c0bef344319e1dd471a3f2d79
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Parameterize commonly used events
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Parameterize commonly used events
......................................................................
webadmin: Parameterize commonly used events
Parameterized the common events in EntityModel and in ListModel, to
help people get rid of warnings if they properly parameterize their
own listeners.
Change-Id: I3fb6f78d9b917635108c2ca4dac5af2338ee4dc0
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
2 files changed, 16 insertions(+), 17 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/32283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fb6f78d9b917635108c2ca4dac5af2338ee4dc0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: tools: Make "No transport ..." error more understandable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: tools: Make "No transport ..." error more understandable
......................................................................
tools: Make "No transport ..." error more understandable
Makes current error message "No transport is enabled, nothing to do"
more understandable to users:
"No transport is enabled, please enable SMTP (using MAIL_SERVER option)
or SNMP (using SNMP_MANAGERS option)."
Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020
Bug-Url: https://bugzilla.redhat.com/1136026
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32305
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months