Change in ovirt-engine[master]: core: legacy VDSM fix - part 2
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: legacy VDSM fix - part 2
......................................................................
core: legacy VDSM fix - part 2
Adding forgotten part of legacy vdsm fix to
I48cd5f76ed870530208fcd0fc69c3d1a52b7249b which I forgot to fixup.
Change-Id: I3b0cd1d109dae745c5a91e4f7a928457c9a7a9d3
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 26 insertions(+), 27 deletions(-)
Approvals:
Frank Kobzik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b0cd1d109dae745c5a91e4f7a928457c9a7a9d3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: fix DirectLUN disk creation
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: fix DirectLUN disk creation
......................................................................
webadmin: fix DirectLUN disk creation
As progress start/stop event is no longer invoked on the model,
external disk panel isn't being displayed on VmDiskPopupWidget
(i.e. New disk popup is missing the LUNs list in DirectLUN view).
Hence,
* Removing progress indication from the inner view (external
disk panel) and rely on the popup progress.
* Pass proper target to AsyncQuerys on SanStorageModel/SanStorageModelBase
to ensure progress on Disk and Storage popups.
Change-Id: Ib5f30df2ba2f4591f6daaa6144b1af8a0d09bfd4
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
3 files changed, 26 insertions(+), 52 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/36831
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f30df2ba2f4591f6daaa6144b1af8a0d09bfd4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine: The wipe after delete should not be null
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: The wipe after delete should not be null
......................................................................
engine: The wipe after delete should not be null
When adding an image repository provider, a storage
domain is being created for it. However, the wipe-after-delete
option must be provided due its not-null constraint.
Change-Id: I89de7410aa25073dfa60c40b99589b164cdfe6ea
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java
1 file changed, 10 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/36852
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89de7410aa25073dfa60c40b99589b164cdfe6ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: issue warning on duplicate profile name
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: issue warning on duplicate profile name
......................................................................
aaa: issue warning on duplicate profile name
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1181603
Change-Id: I5622a8ea0189cfce49008e978527c0e20b849908
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java
2 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5622a8ea0189cfce49008e978527c0e20b849908
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: utils: RedirectServlet: replace localhost to engine host
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: utils: RedirectServlet: replace localhost to engine host
......................................................................
utils: RedirectServlet: replace localhost to engine host
as the redirect happens at client side, the client needs explicit host
name, while localhost may appear at engine configuration in regard of
where resource may be.
to overcome this, replace localhost with the Host header or if not
available with known engine name.
Change-Id: I155489de230124339be4f2493686c83ebaee3a68
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java
1 file changed, 66 insertions(+), 9 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Ravi Nori: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I155489de230124339be4f2493686c83ebaee3a68
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: minor cleanup in import vm related code
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: minor cleanup in import vm related code
......................................................................
webadmin: minor cleanup in import vm related code
Change-Id: I390aeb08fc6180b19acb30f6bf17f9d4c3c0d9dd
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportDiskListModel.java
3 files changed, 16 insertions(+), 18 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/36672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I390aeb08fc6180b19acb30f6bf17f9d4c3c0d9dd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-dwh[ovirt-engine-dwh-3.5]: history: Added log message for DisconnectDwh
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: Added log message for DisconnectDwh
......................................................................
history: Added log message for DisconnectDwh
Added message to the etl in case the service stops
because of DisconnectDwh flag on engine side.
Change-Id: I92bf5cb503e6166cdaabf03ff25087b5900e821d
Bug-Url: https://bugzilla.redhat.com/1181621
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/historyetl_3_5/HistoryETL.java
M tos_project/process/HistoryETL_3.5.item
M tos_project/process/HistoryETL_3.5.properties
3 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92bf5cb503e6166cdaabf03ff25087b5900e821d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-dwh-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-dwh[ovirt-engine-dwh-3.5]: history: maintain db connection for DisconnectDwh check
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: maintain db connection for DisconnectDwh check
......................................................................
history: maintain db connection for DisconnectDwh check
Fixed that if db connection is lost then the
DisconnectDwh check will try to reconnect again
to the engine db.
Change-Id: I948cf3aa8eabe3096e7683db67024a0702775f70
Bug-Url: https://bugzilla.redhat.com/1181616
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/historyetl_3_5/HistoryETL.java
M tos_project/process/HistoryETL_3.5.item
M tos_project/process/HistoryETL_3.5.properties
3 files changed, 1,066 insertions(+), 565 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I948cf3aa8eabe3096e7683db67024a0702775f70
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-dwh-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: aaa: issue warning on duplicate profile name
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: issue warning on duplicate profile name
......................................................................
aaa: issue warning on duplicate profile name
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1181603
Change-Id: I5622a8ea0189cfce49008e978527c0e20b849908
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java
2 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Ravi Nori: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36850
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5622a8ea0189cfce49008e978527c0e20b849908
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: websocket-proxy: SETUP_ATTRS_MODULES to co...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: websocket-proxy: SETUP_ATTRS_MODULES to common
......................................................................
packaging: setup: websocket-proxy: SETUP_ATTRS_MODULES to common
Without this, utilities other than setup (currently rename) drop
wsp constants from postinstall.
Change-Id: I2825c3db19b252464c6fe2dcdad7daa963462399
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py
2 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/36378
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2825c3db19b252464c6fe2dcdad7daa963462399
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months