Change in ovirt-engine-sdk-java[sdk_3.5]: packaging: Distribution specific RPM spec files
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Distribution specific RPM spec files
......................................................................
packaging: Distribution specific RPM spec files
Currently we use a single .spec file template for all the supported
distributions. To support all the distributions it contains many "%if"
statements that change behaviour. This makes it convoluted and
difficult to maintain. To avoid this issue this patch introduces
different spec file templates, one for each supported distribution.
Change-Id: I3ee2acddca2e42c11d5679fb4b8c5931c91ac986
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit b5559822a65004f13b1b6a2ad19988fa32cebeb0)
---
M ovirt-engine-sdk-java/Makefile
M ovirt-engine-sdk-java/README.md
R ovirt-engine-sdk-java/spec.el6.in
A ovirt-engine-sdk-java/spec.el7.centos.in
C ovirt-engine-sdk-java/spec.el7.in
C ovirt-engine-sdk-java/spec.fc20.in
C ovirt-engine-sdk-java/spec.fc21.in
A ovirt-engine-sdk-java/version.py
8 files changed, 215 insertions(+), 449 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ee2acddca2e42c11d5679fb4b8c5931c91ac986
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: sharpen the test for engine enabled
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: sharpen the test for engine enabled
......................................................................
packaging: setup: sharpen the test for engine enabled
Without this change:
1. install and setup engine on machine A
2. install and setup other components (dwh, reports, wsp) on machine B
3. install engine on machine B
4. Run engine-setup - will silently enable the engine
This was done for upgrades from 3.4 that need to enable the engine in
the environment, because in 3.4 it was always enabled and there was no
environment for that.
This change also checks the engine FQDN in engine config files and
compares that with our FQDN. We enable if exists and equal.
Bug-Url: https://bugzilla.redhat.com/1174667
Change-Id: Ie58fcaff0925f3b5ac16fc5159a3eda4498f0b6e
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py
1 file changed, 23 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/36217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie58fcaff0925f3b5ac16fc5159a3eda4498f0b6e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: fixing the check of ISO image permission
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fixing the check of ISO image permission
......................................................................
packaging: setup: fixing the check of ISO image permission
Fixing ISO image permission check against qemu user
Change-Id: I3445e536f4f22b7ccdad1163b4be8afe1c8a69af
Bug-Url: https://bugzilla.redhat.com/1169792
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/35792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3445e536f4f22b7ccdad1163b4be8afe1c8a69af
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: pki: support ovirt specific eku within certificate
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: pki: support ovirt specific eku within certificate
......................................................................
pki: support ovirt specific eku within certificate
having eku within certificate will enable the receiver of signed data
to confirm the identity of the signer per its designated role within the
application.
choice of eku was made as m2crypto cannot read custom x509v3 extended
attributes.
Change-Id: I32fe2e9ed95f27d75d08f4c8498e8a7b79fe1391
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M README.oid
M packaging/bin/pki-enroll-pkcs12.sh
M packaging/bin/pki-enroll-request.sh
M packaging/pki/cert.template.in
4 files changed, 43 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32fe2e9ed95f27d75d08f4c8498e8a7b79fe1391
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: doc: add README.oid
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: doc: add README.oid
......................................................................
doc: add README.oid
Change-Id: I062b35e20d670bf23b862d22318292dd3ca47c85
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
A README.oid
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
mooli tayer: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I062b35e20d670bf23b862d22318292dd3ca47c85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: fix audit/acct/log messages without profile/authn names
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: fix audit/acct/log messages without profile/authn names
......................................................................
aaa: fix audit/acct/log messages without profile/authn names
some logging/audit records are issued without correct user or without
full user name, this makes it difficult to perform problem
determination.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1180707
Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AcctUtils.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutBySessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java
14 files changed, 104 insertions(+), 48 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36833
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine-sdk-java[master]: packaging: Distribution specific RPM spec files
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Distribution specific RPM spec files
......................................................................
packaging: Distribution specific RPM spec files
Currently we use a single .spec file template for all the supported
distributions. To support all the distributions it contains many "%if"
statements that change behaviour. This makes it convoluted and
difficult to maintain. To avoid this issue this patch introduces
different spec file templates, one for each supported distribution.
Change-Id: Ifea3318d7ab1a64efa533809c5aacff75bf9067d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ovirt-engine-sdk-java/Makefile
M ovirt-engine-sdk-java/README.md
R ovirt-engine-sdk-java/spec.el6.in
A ovirt-engine-sdk-java/spec.el7.centos.in
C ovirt-engine-sdk-java/spec.el7.in
C ovirt-engine-sdk-java/spec.fc20.in
C ovirt-engine-sdk-java/spec.fc21.in
A ovirt-engine-sdk-java/version.py
8 files changed, 215 insertions(+), 449 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifea3318d7ab1a64efa533809c5aacff75bf9067d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Reformat POM
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Reformat POM
......................................................................
sdk: Reformat POM
This patch reformats the POM file so that it uses a consistent
indentation and it also removes some unused dependencies, properties and
plugins.
Change-Id: I6add299528b7a2b59727f70586816527f77db615
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 0f326584d1b790e05fecdf7ab7cd3c8399e7c35a)
---
M ovirt-engine-sdk-java/pom.xml
1 file changed, 172 insertions(+), 287 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36834
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6add299528b7a2b59727f70586816527f77db615
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-dwh[master]: history: Added log message for DisconnectDwh
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: Added log message for DisconnectDwh
......................................................................
history: Added log message for DisconnectDwh
Added message to the etl in case the service stops
because of DisconnectDwh flag on engine side.
Change-Id: I92bf5cb503e6166cdaabf03ff25087b5900e821d
Bug-Url: https://bugzilla.redhat.com/1168141
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/historyetl_3_6/HistoryETL.java
M tos_project/process/HistoryETL_3.6.item
M tos_project/process/HistoryETL_3.6.properties
3 files changed, 3,078 insertions(+), 2,498 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36763
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92bf5cb503e6166cdaabf03ff25087b5900e821d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: do not copy RNG device from instance type if not possible
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: do not copy RNG device from instance type if not possible
......................................................................
core: do not copy RNG device from instance type if not possible
The rng device was copied from the instance type to newly created VM without
checking if the virtio rng is actually supported on this cluster.
Fixed by extracting the logic to a standalone validator and using this
validator in commands and also in VmDeviceUtils.
Change-Id: Ic016df28bd0484735c74308750fe03ab9036f59d
Bug-Url: https://bugzilla.redhat.com/1177234
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateRngDeviceTest.java
6 files changed, 60 insertions(+), 20 deletions(-)
Approvals:
Tomas Jelinek: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic016df28bd0484735c74308750fe03ab9036f59d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months