December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddVmCommand allows InstanceCreator role to create VM
by ahadas＠redhat.com 30 Nov '15

30 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: AddVmCommand allows InstanceCreator role to create VM ...................................................................... core: AddVmCommand allows InstanceCreator role to create VM It fixes the bug when user with InstaceCreator role permissions on VM template and Cluster was not able to create a VM from userportal because AddVmCommand did not respected ActionGroup.CREATE_INSTANCE in combination with VdcObjectType.VmTemplate. Change-Id: I8ddafbbb96d8d38a964b6b855cc9163ebfda5cda Bug-Url: https://bugzilla.redhat.com/1278271 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 27 insertions(+), 9 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ddafbbb96d8d38a964b6b855cc9163ebfda5cda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Typo fix in Welcome page
by masayag＠redhat.com 30 Nov '15

30 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Typo fix in Welcome page ...................................................................... core: Typo fix in Welcome page 'Not Logger In' -> 'Not Logged In' Change-Id: If6e3db48a1fbfa5d0bd84d0855f8006eaebc4a96 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/welcome/src/main/resources/messages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6e3db48a1fbfa5d0bd84d0855f8006eaebc4a96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Log out from userportal doesn't work for non-admins
by masayag＠redhat.com 30 Nov '15

30 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: engine : Log out from userportal doesn't work for non-admins ...................................................................... engine : Log out from userportal doesn't work for non-admins Logout from user portal does not succeed as retrieving the token for session fails due to insufficient privileges. Change-Id: Ib848abe48ba28178b2a6e9de2cddd1c82cd5ec02 Bug-Url: https://bugzilla.redhat.com/1286810 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOLogoutServlet.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib848abe48ba28178b2a6e9de2cddd1c82cd5ec02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: fix tuned profile entries
by sabose＠redhat.com 30 Nov '15

30 Nov '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: fix tuned profile entries ...................................................................... gluster: fix tuned profile entries Fix selection on change of compat version Bug-Url: https://bugzilla.redhat.com/1249979 Change-Id: I15e6bbc05282d60c6fb708d800e3563a04e79546 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15e6bbc05282d60c6fb708d800e3563a04e79546 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: fix tuned profile entries
by sabose＠redhat.com 30 Nov '15

30 Nov '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: fix tuned profile entries ...................................................................... gluster: fix tuned profile entries Fix selection on change of compat version Change-Id: I15e6bbc05282d60c6fb708d800e3563a04e79546 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: anmolbabu: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/49332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15e6bbc05282d60c6fb708d800e3563a04e79546 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0