Change in ovirt-engine[master]: virt: replace Runnable creation with lambda exp
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: virt: replace Runnable creation with lambda exp
......................................................................
virt: replace Runnable creation with lambda exp
Change-Id: Ice06c68e2ef7a287f222bccf6f56dd2c17f2cbf4
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
1 file changed, 8 insertions(+), 18 deletions(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice06c68e2ef7a287f222bccf6f56dd2c17f2cbf4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core:java8 stream API in AddEventSubscription...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:java8 stream API in AddEventSubscription...
......................................................................
core:java8 stream API in AddEventSubscription...
Using java8 stream API in AddEventSubscriptionCommand
Change-Id: I21df3783b39e99823f03cba637652b87d8d8bd1d
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java
1 file changed, 5 insertions(+), 11 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified; Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21df3783b39e99823f03cba637652b87d8d8bd1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: fix method doc
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: fix method doc
......................................................................
core: fix method doc
Change-Id: Ia846b9195df2892ac441f6f5c1b96a997515d42b
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia846b9195df2892ac441f6f5c1b96a997515d42b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in jenkins[master]: Added hmtl reports to stardard-ci
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added hmtl reports to stardard-ci
......................................................................
Added hmtl reports to stardard-ci
Now any index.html file located in the exported-artifacts dir will be
published in the jenkins build page
Change-Id: I05b39625b80ff1804e1969eae8874a22dc2bf56e
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A jobs/confs/yaml/publishers/html-reports.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Barak Korren: Looks good to me
Yaniv Bronhaim: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for merge
--
To view, visit https://gerrit.ovirt.org/50546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05b39625b80ff1804e1969eae8874a22dc2bf56e
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: uutils: ssh: sshd-core 1.1.0 glue
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: uutils: ssh: sshd-core 1.1.0 glue
......................................................................
uutils: ssh: sshd-core 1.1.0 glue
prepare for ssh-core 1.1.0 bump
Change-Id: I323eadb0582a8e2526e032f404ca563d17a16673
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/OVirtNodeUpgrade.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
12 files changed, 142 insertions(+), 78 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50562
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I323eadb0582a8e2526e032f404ca563d17a16673
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: packaging: added shadow-utils req.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: added shadow-utils req.
......................................................................
packaging: added shadow-utils req.
Requirement for shadow-utils was added to ovirt-engine-setup-base
package, as it requires it to be installed in order to run the
post installation scripts.
Change-Id: Ie6d53bca0ae1a0dfe1af5ecfb242cb7767a2cd57
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1292009
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6d53bca0ae1a0dfe1af5ecfb242cb7767a2cd57
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: remove obsolete parentHasTasks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: remove obsolete parentHasTasks
......................................................................
core: remove obsolete parentHasTasks
Removed obsolete 'parentHasTasks' members/getters/setters/usages
from parameters classes and commands.
Change-Id: Ib83accd4ccc9ef0bc5485a0319186d0153d49a54
Bug-Url: https://bugzilla.redhat.com/1287771
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneCinderDisksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmCinderDisksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllCinderSnapshotsParameters.java
11 files changed, 9 insertions(+), 44 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib83accd4ccc9ef0bc5485a0319186d0153d49a54
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-live[ovirt-live-3.6]: centos: kickstart: include fixes from centos-7-live-gnome.cfg
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: kickstart: include fixes from centos-7-live-gnome.cfg
......................................................................
centos: kickstart: include fixes from centos-7-live-gnome.cfg
Fixes:
patching file
/usr/lib64/python2.7/site-packages/pyanaconda/packaging/livepayload.py
Hunk #1 succeeded at 165 with fuzz 2 (offset 13 lines).
Hunk #2 FAILED at 166.
1 out of 2 hunks FAILED -- saving rejects to file
/usr/lib64/python2.7/site-packages/pyanaconda/packaging/livepayload.py.rej
Change-Id: I618973576b30826f4c92bb9ca0eb5539f1a38837
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/centos-7-livecd.cfg
1 file changed, 3 insertions(+), 41 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I618973576b30826f4c92bb9ca0eb5539f1a38837
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-live[master]: centos: kickstart: include fixes from centos-7-live-gnome.cfg
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: kickstart: include fixes from centos-7-live-gnome.cfg
......................................................................
centos: kickstart: include fixes from centos-7-live-gnome.cfg
Fixes:
patching file
/usr/lib64/python2.7/site-packages/pyanaconda/packaging/livepayload.py
Hunk #1 succeeded at 165 with fuzz 2 (offset 13 lines).
Hunk #2 FAILED at 166.
1 out of 2 hunks FAILED -- saving rejects to file
/usr/lib64/python2.7/site-packages/pyanaconda/packaging/livepayload.py.rej
Change-Id: I618973576b30826f4c92bb9ca0eb5539f1a38837
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/centos-7-livecd.cfg
1 file changed, 3 insertions(+), 41 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50575
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I618973576b30826f4c92bb9ca0eb5539f1a38837
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: restore snapshot with Cinder disks - failure flow
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: restore snapshot with Cinder disks - failure flow
......................................................................
core: restore snapshot with Cinder disks - failure flow
Determining whether a callback is needed on
RestoreAllSnapshotsCommand isn't straight forward (logic in
'restoreSnapshotAndRemoveObsoleteSnapshots').
Hence, fixing RestoreAllCinderSnapshotsCommand specifically.
Change-Id: I2e5ae3486b55c981cde290970a0c67d2acdc9afe
Bug-Url: https://bugzilla.redhat.com/1287771
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java
3 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Daniel Erez: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50008
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e5ae3486b55c981cde290970a0c67d2acdc9afe
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months