December 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: Foreman integration: Remove 'nested' attribute from paramete...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: Foreman integration: Remove 'nested' attribute from parameters dict ...................................................................... Foreman integration: Remove 'nested' attribute from parameters dict Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1285780 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1283215 Foreman-Issue-Url: http://projects.theforeman.org/issues/12516 Change-Id: I7257eeff9c887d33a9fe8cbab1a4aef6e970218d Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7257eeff9c887d33a9fe8cbab1a4aef6e970218d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Base templates also contains <version> tag

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Base templates also contains <version> tag ...................................................................... restapi: Base templates also contains <version> tag Till now base templates did not contain <version> tag, it was only present in template sub-versions. This patch adds <version> tag to all templates to improve automation and consistency. Change-Id: I27d0a9988f97e55ea64fa1d40cdcc4c1c4a3fdbd Bug-Url: https://bugzilla.redhat.com/1284587 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java 2 files changed, 10 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Passed CI tests Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27d0a9988f97e55ea64fa1d40cdcc4c1c4a3fdbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: VmPools can use <use_latest_template_version>

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: restapi: VmPools can use <use_latest_template_version> ...................................................................... restapi: VmPools can use <use_latest_template_version> VmPools updates and adds can now use <use_latest_template_version> as optional argument. Change-Id: Ia86f423728dfca0dab7c4321ba32eb17ca04a789 Bug-Url: https://bugzilla.redhat.com/1284596 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java 4 files changed, 12 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86f423728dfca0dab7c4321ba32eb17ca04a789 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core, restapi: fixed potential NPE and removed duplicity

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core,restapi: fixed potential NPE and removed duplicity ...................................................................... core,restapi: fixed potential NPE and removed duplicity Bug-Url: https://bugzilla.redhat.com/1287665 Change-Id: Ia913e0f2069fa63b07be3f640600c1867406eda7 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Mucha: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia913e0f2069fa63b07be3f640600c1867406eda7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: change 'SSH Port' to 'Port' in PM dialog

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: change 'SSH Port' to 'Port' in PM dialog ...................................................................... core: change 'SSH Port' to 'Port' in PM dialog Changing 'SSH Port' to 'Port' in PM dialog since not all ports are SSH ports and the term 'Port' is more general and matches all PM agents. Change-Id: I8220adb1da68edddd18a801e2deaf6dafbc2bb87 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280309 Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8220adb1da68edddd18a801e2deaf6dafbc2bb87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: BackendVmsResource template ID checking

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: BackendVmsResource template ID checking ...................................................................... restapi: BackendVmsResource template ID checking Two separate places in this class compare IDs from business entities (which are Guids) with IDs from API entities (which are Strings). Since different types of objects cannot (or at least, should not) equal each other in Java, these equality checks return false as long as at least one of these values is not null, which is probably not what this code intended. This patch converts both values to Strings before comparing them. Using ObjectUtils.equals hints to a concern that these values may be nulls, so the null-safe Objects.toString is used to convert the Guids to Strings instead of a straight-forward call to toString(). Change-Id: I94222e61ceebcd79168d62dd6449fb27730ea258 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/49320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94222e61ceebcd79168d62dd6449fb27730ea258 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: Require latest otopi

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Require latest otopi ...................................................................... packaging: setup: Require latest otopi Add 'otopi' to list of setup packages so that we require its latest available version before continuing. Bug-Url: https://bugzilla.redhat.com/1286558 Change-Id: Icf2a5c3af3845527b75c2b0a4cdd42d5bd89f4a3 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A packaging/setup/plugins/ovirt-engine-setup/base/distro-rpm/__init__.py A packaging/setup/plugins/ovirt-engine-setup/base/distro-rpm/packages.py 2 files changed, 90 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/49105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2a5c3af3845527b75c2b0a4cdd42d5bd89f4a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: dbutils: Clean jobs when steps are cleaned

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: dbutils: Clean jobs when steps are cleaned ...................................................................... dbutils: Clean jobs when steps are cleaned This patch insures that when the taskcleaner util deletes steps, the corresponding jobs of those steps will be cleared as well. Prior to this fix steps were cleared by taskcleaner while the related job remains in STARTED status and actually without any steps. This leads to Orphan jobs stuck in the system and not cleared forever. Change-Id: I9c2f775a93208d667b11b4d32a93277f44d11776 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283944 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql 2 files changed, 13 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c2f775a93208d667b11b4d32a93277f44d11776 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: update setupNetworks heartbeat policy only for mgmt ...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: update setupNetworks heartbeat policy only for mgmt networks ...................................................................... engine: update setupNetworks heartbeat policy only for mgmt networks Updating the heartbeat policy during the HostSetupNetworks command only makes sense when the connection between the engine and host is modified. This should only be the case when the management network is modified. This patch changes the rpc broker to only reset the heartbeat policy when the management network is changed in any way. Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1262051 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 10 files changed, 78 insertions(+), 16 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: move createMultipleStorageDomainsValidator from VmCommand

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: move createMultipleStorageDomainsValidator from VmCommand ...................................................................... core: move createMultipleStorageDomainsValidator from VmCommand This patch moves createMultipleStorageDomainsValidator() from VmCommand to CreateAllSnapshotsFromVmCommand, since the only ones who use it are CreateAllSnapshotsFromVmCommand and CreateAllSnapshotsFromVmCommandTest. Change-Id: If744bb2371b9bf7e1da6c37afca7b8cd43173408 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 6 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If744bb2371b9bf7e1da6c37afca7b8cd43173408 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2015