Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: Fix escaped HTML in table headers
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix escaped HTML in table headers
......................................................................
webadmin,userportal: Fix escaped HTML in table headers
Table headers with HTML content no longer have their content
escaped, e.g. Network / Hosts sub tab no longer has columns
like "Speed <sub>(Mbps)</sub>", but just "Speed (Mbps)".
Change-Id: I6b636084ed04af1295084579fd1ab4102445fc79
Bug-Url: https://bugzilla.redhat.com/1259826
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
Scott Dickerson: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/49184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b636084ed04af1295084579fd1ab4102445fc79
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Fix typo in audit log message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix typo in audit log message
......................................................................
core: Fix typo in audit log message
Change-Id: I1311f46567c5170c95650b76f3af8d5e82a76648
Bug-Url: https://bugzilla.redhat.com/1273378
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/49537
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1311f46567c5170c95650b76f3af8d5e82a76648
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Remove unused variable in NUMA model
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Remove unused variable in NUMA model
......................................................................
webadmin: Remove unused variable in NUMA model
Change-Id: If861d14c4456ac1659f5d21e6c9387776a7c9d96
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Roman Mohr: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49285
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If861d14c4456ac1659f5d21e6c9387776a7c9d96
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: restapi: Add the "async" parameter to all the actions
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add the "async" parameter to all the actions
......................................................................
restapi: Add the "async" parameter to all the actions
All the update, remove and action methods support an "async" parameter
that indicates if the operation should be performed asynchronously.
Currently this is documented in the RSDL, but not in the model. This
patch adds this parameter to the model, so that in the future it will be
available in the documentation.
Change-Id: I9e66d9ac3bc5b9549f4374d15d507ae063ee50f3
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JaxrsGenerator.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaGenerator.java
M backend/manager/modules/restapi/model/src/main/java/services/AffinityGroupService.java
M backend/manager/modules/restapi/model/src/main/java/services/AffinityGroupVmService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedCpuProfileService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedDiskProfileService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedNetworkService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedTagService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedVnicProfileService.java
M backend/manager/modules/restapi/model/src/main/java/services/AttachedStorageDomainService.java
M backend/manager/modules/restapi/model/src/main/java/services/BalanceService.java
M backend/manager/modules/restapi/model/src/main/java/services/BookmarkService.java
M backend/manager/modules/restapi/model/src/main/java/services/ClusterService.java
M backend/manager/modules/restapi/model/src/main/java/services/CopyableService.java
M backend/manager/modules/restapi/model/src/main/java/services/CpuProfileService.java
M backend/manager/modules/restapi/model/src/main/java/services/DataCenterService.java
M backend/manager/modules/restapi/model/src/main/java/services/DiskProfileService.java
M backend/manager/modules/restapi/model/src/main/java/services/DiskService.java
M backend/manager/modules/restapi/model/src/main/java/services/DiskSnapshotService.java
M backend/manager/modules/restapi/model/src/main/java/services/DisksService.java
M backend/manager/modules/restapi/model/src/main/java/services/EventService.java
M backend/manager/modules/restapi/model/src/main/java/services/EventsService.java
M backend/manager/modules/restapi/model/src/main/java/services/ExternalProviderService.java
M backend/manager/modules/restapi/model/src/main/java/services/FenceAgentService.java
M backend/manager/modules/restapi/model/src/main/java/services/FilterService.java
M backend/manager/modules/restapi/model/src/main/java/services/GraphicsConsoleService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostNicService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostNicsService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostService.java
M backend/manager/modules/restapi/model/src/main/java/services/ImageService.java
M backend/manager/modules/restapi/model/src/main/java/services/InstanceTypeNicService.java
M backend/manager/modules/restapi/model/src/main/java/services/InstanceTypeService.java
M backend/manager/modules/restapi/model/src/main/java/services/InstanceTypeWatchdogService.java
M backend/manager/modules/restapi/model/src/main/java/services/IscsiBondService.java
M backend/manager/modules/restapi/model/src/main/java/services/JobService.java
M backend/manager/modules/restapi/model/src/main/java/services/LabelService.java
M backend/manager/modules/restapi/model/src/main/java/services/MacPoolService.java
M backend/manager/modules/restapi/model/src/main/java/services/MoveableService.java
M backend/manager/modules/restapi/model/src/main/java/services/NetworkAttachmentService.java
M backend/manager/modules/restapi/model/src/main/java/services/NetworkService.java
M backend/manager/modules/restapi/model/src/main/java/services/PermissionService.java
M backend/manager/modules/restapi/model/src/main/java/services/PermitService.java
M backend/manager/modules/restapi/model/src/main/java/services/QosService.java
M backend/manager/modules/restapi/model/src/main/java/services/QuotaClusterLimitService.java
M backend/manager/modules/restapi/model/src/main/java/services/QuotaService.java
M backend/manager/modules/restapi/model/src/main/java/services/QuotaStorageLimitService.java
M backend/manager/modules/restapi/model/src/main/java/services/RoleService.java
M backend/manager/modules/restapi/model/src/main/java/services/SchedulingPolicyService.java
M backend/manager/modules/restapi/model/src/main/java/services/SchedulingPolicyUnitService.java
M backend/manager/modules/restapi/model/src/main/java/services/SnapshotService.java
M backend/manager/modules/restapi/model/src/main/java/services/StepService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainServerConnectionService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainTemplateService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainVmService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageServerConnectionExtensionService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageServerConnectionService.java
M backend/manager/modules/restapi/model/src/main/java/services/SystemService.java
M backend/manager/modules/restapi/model/src/main/java/services/TagService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateDiskService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateNicService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateWatchdogService.java
M backend/manager/modules/restapi/model/src/main/java/services/UnmanagedNetworkService.java
M backend/manager/modules/restapi/model/src/main/java/services/VirtualFunctionAllowedNetworkService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmCdromService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmDiskService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmGraphicsConsoleService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmHostDeviceService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmNicService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmNumaNodeService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmPoolService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmWatchdogService.java
M backend/manager/modules/restapi/model/src/main/java/services/VnicProfileService.java
M backend/manager/modules/restapi/model/src/main/java/services/WeightService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/GroupService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/SshPublicKeyService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/UserService.java
M backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/ExternalHostProviderService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterBrickService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterBricksService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterHookService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterVolumeService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackImageProviderService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackImageService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackNetworkProviderService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackSubnetService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackVolumeAuthenticationKeyService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackVolumeProviderService.java
90 files changed, 949 insertions(+), 14 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49329
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e66d9ac3bc5b9549f4374d15d507ae063ee50f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: restapi: Add the "max" parameter to all the "List" methods
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add the "max" parameter to all the "List" methods
......................................................................
restapi: Add the "max" parameter to all the "List" methods
All the "List" methods support a "max" parameter that indicates the
maximum number of results to return. Currently this is documented in the
RSDL, but not in the model. This patch adds this parameter to the model,
so that in the future it will be available in the documentation.
Change-Id: I727034038efa5a34d7eac17949ec273d8a58184e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/model/src/main/java/services/AffinityGroupVmsService.java
M backend/manager/modules/restapi/model/src/main/java/services/AffinityGroupsService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedCpuProfilesService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedDiskProfilesService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedNetworksService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedRolesService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedTagsService.java
M backend/manager/modules/restapi/model/src/main/java/services/AssignedVnicProfilesService.java
M backend/manager/modules/restapi/model/src/main/java/services/AttachedStorageDomainsService.java
M backend/manager/modules/restapi/model/src/main/java/services/BalancesService.java
M backend/manager/modules/restapi/model/src/main/java/services/BookmarksService.java
M backend/manager/modules/restapi/model/src/main/java/services/ClustersService.java
M backend/manager/modules/restapi/model/src/main/java/services/CpuProfilesService.java
M backend/manager/modules/restapi/model/src/main/java/services/DataCentersService.java
M backend/manager/modules/restapi/model/src/main/java/services/DiskProfilesService.java
M backend/manager/modules/restapi/model/src/main/java/services/DiskSnapshotsService.java
M backend/manager/modules/restapi/model/src/main/java/services/EventsService.java
M backend/manager/modules/restapi/model/src/main/java/services/ExternalProviderCertificatesService.java
M backend/manager/modules/restapi/model/src/main/java/services/FenceAgentsService.java
M backend/manager/modules/restapi/model/src/main/java/services/FilesService.java
M backend/manager/modules/restapi/model/src/main/java/services/FiltersService.java
M backend/manager/modules/restapi/model/src/main/java/services/GraphicsConsolesService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostDevicesService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostHooksService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostNicsService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostNumaNodesService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostsService.java
M backend/manager/modules/restapi/model/src/main/java/services/IconsService.java
M backend/manager/modules/restapi/model/src/main/java/services/ImagesService.java
M backend/manager/modules/restapi/model/src/main/java/services/InstanceTypeNicsService.java
M backend/manager/modules/restapi/model/src/main/java/services/InstanceTypeWatchdogsService.java
M backend/manager/modules/restapi/model/src/main/java/services/InstanceTypesService.java
M backend/manager/modules/restapi/model/src/main/java/services/IscsiBondsService.java
M backend/manager/modules/restapi/model/src/main/java/services/JobsService.java
M backend/manager/modules/restapi/model/src/main/java/services/LabelsService.java
M backend/manager/modules/restapi/model/src/main/java/services/MacPoolsService.java
M backend/manager/modules/restapi/model/src/main/java/services/NetworkAttachmentsService.java
M backend/manager/modules/restapi/model/src/main/java/services/NetworksService.java
M backend/manager/modules/restapi/model/src/main/java/services/OperatingSystemsService.java
M backend/manager/modules/restapi/model/src/main/java/services/PermitsService.java
M backend/manager/modules/restapi/model/src/main/java/services/QossService.java
M backend/manager/modules/restapi/model/src/main/java/services/QuotaClusterLimitsService.java
M backend/manager/modules/restapi/model/src/main/java/services/QuotaStorageLimitsService.java
M backend/manager/modules/restapi/model/src/main/java/services/QuotasService.java
M backend/manager/modules/restapi/model/src/main/java/services/RolesService.java
M backend/manager/modules/restapi/model/src/main/java/services/SchedulingPoliciesService.java
M backend/manager/modules/restapi/model/src/main/java/services/SchedulingPolicyUnitsService.java
M backend/manager/modules/restapi/model/src/main/java/services/SnapshotCdromsService.java
M backend/manager/modules/restapi/model/src/main/java/services/SnapshotDisksService.java
M backend/manager/modules/restapi/model/src/main/java/services/SnapshotNicsService.java
M backend/manager/modules/restapi/model/src/main/java/services/SnapshotsService.java
M backend/manager/modules/restapi/model/src/main/java/services/StatisticsService.java
M backend/manager/modules/restapi/model/src/main/java/services/StepsService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainContentDisksService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainServerConnectionsService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainTemplatesService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainVmsService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainsService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageServerConnectionExtensionsService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageServerConnectionsService.java
M backend/manager/modules/restapi/model/src/main/java/services/TagsService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateCdromsService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateDisksService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateNicsService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateWatchdogsService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplatesService.java
M backend/manager/modules/restapi/model/src/main/java/services/UnmanagedNetworksService.java
M backend/manager/modules/restapi/model/src/main/java/services/VirtualFunctionAllowedNetworksService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmApplicationsService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmCdromsService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmDisksService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmHostDevicesService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmNicsService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmNumaNodesService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmPoolsService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmReportedDevicesService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmSessionsService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmWatchdogsService.java
M backend/manager/modules/restapi/model/src/main/java/services/VnicProfilesService.java
M backend/manager/modules/restapi/model/src/main/java/services/WeightsService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/DomainGroupsService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/DomainUsersService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/DomainsService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/GroupsService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/SshPublicKeysService.java
M backend/manager/modules/restapi/model/src/main/java/services/aaa/UsersService.java
M backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/ExternalComputeResourcesService.java
M backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/ExternalDiscoveredHostsService.java
M backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/ExternalHostGroupsService.java
M backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/ExternalHostProvidersService.java
M backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/ExternalHostsService.java
M backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/KatelloErrataService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterBricksService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterHooksService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterVolumesService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackImageProvidersService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackImagesService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackNetworkProvidersService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackNetworksService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackSubnetsService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackVolumeAuthenticationKeysService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackVolumeProvidersService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackVolumeTypesService.java
103 files changed, 551 insertions(+), 15 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I727034038efa5a34d7eac17949ec273d8a58184e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in gerrit-admin[master]: Added hook to propagate CI flag
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added hook to propagate CI flag
......................................................................
Added hook to propagate CI flag
Right now, if you create a non-code patch before getting feedback from
jenkins, that patch will never get CI review from it as jenkins will
review only the patchset that has code changes. This hook is triggered
on any comment, and propagates the CI value to the latest patchset if
it does not have a CI value already.
Change-Id: I0b6f3a53edd0a8d2a0114fb728fff0054c11d466
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A hooks/custom_hooks/comment-added.propagate_review_values
M hooks/hook-dispatcher
M hooks/lib/gerrit.py
M hooks/lib/tools.py
4 files changed, 320 insertions(+), 47 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48518
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b6f3a53edd0a8d2a0114fb728fff0054c11d466
Gerrit-PatchSet: 16
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in gerrit-admin[master]: Fix: hook-dispatcher not showing hooks result
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Fix: hook-dispatcher not showing hooks result
......................................................................
Fix: hook-dispatcher not showing hooks result
Previous change introduced an issue that made the hook-dispatcher
break when it should not show any result message (this is not
reflected in the final functionality)
Change-Id: Icca8ef7477cb03588c856cca2adc947e0cc6aa86
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M hooks/hook-dispatcher
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icca8ef7477cb03588c856cca2adc947e0cc6aa86
Gerrit-PatchSet: 3
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in gerrit-admin[master]: Target release is not needed anymore to move a bug
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Target release is not needed anymore to move a bug
......................................................................
Target release is not needed anymore to move a bug
Now is only set on release instead
Change-Id: Ib54a7efd198cc2e9787726361590090e8157146e
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M hooks/custom_hooks/change-merged.set_MODIFIED
1 file changed, 0 insertions(+), 14 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib54a7efd198cc2e9787726361590090e8157146e
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in jenkins[master]: mock_runner:Fixing add package
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: mock_runner:Fixing add package
......................................................................
mock_runner:Fixing add package
There was an unsync between the short option definition and the option
parsing
Change-Id: I0ef89913ca56ebb6eab46a8a9d824e552241dbb0
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M mock_configs/mock_runner.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Barak Korren: Looks good to me
David Caro: Verified; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/49443
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ef89913ca56ebb6eab46a8a9d824e552241dbb0
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: engine: WebSocketProxy set to be reloadable
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: engine: WebSocketProxy set to be reloadable
......................................................................
engine: WebSocketProxy set to be reloadable
The 'WebSocketProxy' configuration value (vdc_options, ConfigValues)
is set to be reloadable - the engine does not need to be
restarted to take effect of a change.
Steps needed to reload the configuration on-the-fly can be found
in the bug description.
Change-Id: I62a6f37037fff61adb902428b163814abd9e7f43
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124851
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Martin Betak: Looks good to me, but someone else must approve
Marek Libra: Verified
Arik Hadas: Looks good to me, approved; Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48856
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62a6f37037fff61adb902428b163814abd9e7f43
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months