Change in ovirt-engine[master]: core: rename RestoreAllSnapshotCommandTest
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename RestoreAllSnapshotCommandTest
......................................................................
core: rename RestoreAllSnapshotCommandTest
This patch renames RestoreAllSnapshotCommandTest to
RestoreAllSnapshotsCommandTest, to be consistent with the command
RestoreAllSnapshotsCommand name.
Change-Id: I15e7d9ba8d2862ce138f6194f50e8d6226e23fb6
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49356
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15e7d9ba8d2862ce138f6194f50e8d6226e23fb6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: move bll/lsm to bll/storage/lsm
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: move bll/lsm to bll/storage/lsm
......................................................................
core: move bll/lsm to bll/storage/lsm
This patch is a part of a series of patches aimed to organize the
org/ovirt/engine/core/bll/storage package.
Specifically, it moves the org/ovirt/engine/core/bll/lsm package to
org/ovirt/engine/core/bll/storage/lsm.
Change-Id: Ic57f238a419a2702afda74c5f0c631301e6f807d
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/CreateImagePlaceholderTaskHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDisksTaskHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveSnapshotTaskHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/VmReplicateDiskFinishTaskHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/VmReplicateDiskStartTaskHandler.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommandTest.java
9 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49352
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic57f238a419a2702afda74c5f0c631301e6f807d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: relocate all export domains related classes
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: relocate all export domains related classes
......................................................................
core: relocate all export domains related classes
This patch is a part of a series of patches aimed to organize the
org/ovirt/engine/core/bll/storage package.
Specifically, it relocates all the export domains related classes
to org/ovirt/engine/core/bll/storage/export.
Change-Id: Ice6b131a8463471f0c8cce54e811879057bc455f
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/GetAllFromExportDomainQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/GetTemplatesFromExportDomainQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/GetVmsFromExportDomainQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/RemoveVmFromImportExportCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/RemoveVmTemplateFromImportExportCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommandTest.java
13 files changed, 46 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice6b131a8463471f0c8cce54e811879057bc455f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: move methods from MoveOrCopyTemplate to ImportVmTemplate
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: move methods from MoveOrCopyTemplate to ImportVmTemplate
......................................................................
core: move methods from MoveOrCopyTemplate to ImportVmTemplate
This patch moves the methods updateManagedDeviceMap and
generateNewDiskId from MoveOrCopyTemplateCommand to
ImportVmTemplateCommand since they are used only by
ImportVmTemplateCommand and ImportVmTemplateCommandTest.
Change-Id: I3e9ba2194b745a351e20a517c2566db51834e45f
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
2 files changed, 35 insertions(+), 35 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e9ba2194b745a351e20a517c2566db51834e45f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: remove unused method generateNewDiskId
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove unused method generateNewDiskId
......................................................................
core: remove unused method generateNewDiskId
Change-Id: Iccb4b2b54ba801164fa690ebe0d6405f4e93c46b
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
1 file changed, 0 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49247
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccb4b2b54ba801164fa690ebe0d6405f4e93c46b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: use failCanDoAction in MoveOrCopyTemplateCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: use failCanDoAction in MoveOrCopyTemplateCommand
......................................................................
core: use failCanDoAction in MoveOrCopyTemplateCommand
Change-Id: Ic601d8b51749fec4169cd00d8c0c36d832d1658b
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommandTest.java
2 files changed, 12 insertions(+), 16 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic601d8b51749fec4169cd00d8c0c36d832d1658b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: relocate all ovf stores related classes
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: relocate all ovf stores related classes
......................................................................
core: relocate all ovf stores related classes
This patch is a part of a series of patches aimed to organize the
org/ovirt/engine/core/bll/storage package.
Specifically, it relocates all the ovf stores related classes to
org/ovirt/engine/core/bll/storage/ovfstore.
Change-Id: I9c096171e42b8eb07947d5d4184767f5fc0467d7
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromConfigurationQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmOvfByVmIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredEntitiesQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/CreateOvfStoresForStorageDomainCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/CreateOvfVolumeForStorageDomainCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfHelper.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfUpdateProcessHelper.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/UploadStreamCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQueryTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdaterTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
27 files changed, 66 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49211
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c096171e42b8eb07947d5d4184767f5fc0467d7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: relocate all storage pools related classes
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: relocate all storage pools related classes
......................................................................
core: relocate all storage pools related classes
This patch is a part of a series of patches aimed to organize the
org/ovirt/engine/core/bll/storage package.
Specifically, it relocates all the storage pools related classes
to org/ovirt/engine/core/bll/storage/pool.
Change-Id: I0ea79b45b1fe3c1719dab21822cf204e6bd0f6f7
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ActivateDeactivateSingleAsyncOperation.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ActivateDeactivateSingleAsyncOperationFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperation.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperationFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ConntectVDSToPoolAndDomains.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperation.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperationFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetAllStoragePoolsQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetAvailableStoragePoolVersionsQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByDatacenterNameQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByIdQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolsByClusterServiceQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolsByStorageDomainIdQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStorageTypesInPoolByPoolIdQuery.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ReconstructMasterDomainCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RecoveryStoragePoolCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshPoolSingleAsyncOperation.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshPoolSingleAsyncOperationFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperation.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SetStoragePoolStatusCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolManagementCommandBase.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolStatusHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommandTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByIdQueryTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/ReconstructMasterDomainCommandTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommandTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java
41 files changed, 59 insertions(+), 41 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ea79b45b1fe3c1719dab21822cf204e6bd0f6f7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: add MockConfigDescriptor for StoragePoolNameSizeLimit
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: add MockConfigDescriptor for StoragePoolNameSizeLimit
......................................................................
core: add MockConfigDescriptor for StoragePoolNameSizeLimit
The method StorageHandlingCommandBase.getStoragePoolNameSizeLimit()
returns a config value.
This patch removes the mocking of getStoragePoolNameSizeLimit(), and
instead adds a new config descriptor to the existing config rule.
Since only StorageHandlingCommandBase used this method at only one
place, it has been inlined.
Change-Id: I8b54e51033abe03889d617fe4217fd9611d80499
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
2 files changed, 3 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b54e51033abe03889d617fe4217fd9611d80499
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: relocate AbstractSPMAsyncTaskHandler
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: relocate AbstractSPMAsyncTaskHandler
......................................................................
core: relocate AbstractSPMAsyncTaskHandler
This patch is a part of a series of patches aimed to organize the
org/ovirt/engine/core/bll/storage package.
Specifically, it relocates AbstractSPMAsyncTaskHandler to
org/ovirt/engine/core/bll/storage.
Change-Id: Iadf62e28d06e3a461999d622b664e95a53728a38
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AbstractSPMAsyncTaskHandler.java
5 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/49203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadf62e28d06e3a461999d622b664e95a53728a38
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months