Change in ovirt-engine[master]: engine: Fix broken test
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Fix broken test
......................................................................
engine: Fix broken test
Change-Id: I8ae38a29c2e87d89a31274ce742c29471c127659
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/StartVdsCommandTest.java
1 file changed, 8 insertions(+), 9 deletions(-)
Approvals:
Ori Liel: Looks good to me, …
[View More]approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/37608
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ae38a29c2e87d89a31274ce742c29471c127659
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Update current UI code with the new parameter class
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Update current UI code with the new parameter class
......................................................................
webadmin: Update current UI code with the new parameter class
Update calls to AddVdsGroupCommand to pass the new parameter class.
Change-Id: Ie7efe9c826d3cbeacc69f3cebdb9362dc90e500e
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/…
[View More]uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java
3 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/33414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7efe9c826d3cbeacc69f3cebdb9362dc90e500e
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: Add AddClusterOperationParameters class
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add AddClusterOperationParameters class
......................................................................
engine: Add AddClusterOperationParameters class
AddClusterOperationParameters is added in order to enable
to pass managementNetworkId parameter to the command.
Change-Id: I41d6bb8cc882c9aa8bb0e3193f9785a2daf1c889
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/…
[View More]modules/common/src/main/java/org/ovirt/engine/core/common/action/AddClusterOperationParameters.java
1 file changed, 28 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/33300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41d6bb8cc882c9aa8bb0e3193f9785a2daf1c889
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: Add DefaultManagementNetworkFinder
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add DefaultManagementNetworkFinder
......................................................................
engine: Add DefaultManagementNetworkFinder
Add DefaultManagementNetworkFinder + impl + test.
Add the provider method for NetworkDao in BllCDIAdapter.
Change-Id: I7f8f0d53096523414ceb339d1b43224b540e0f78
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/…
[View More]main/java/org/ovirt/engine/core/bll/network/cluster/DefaultManagementNetworkFinder.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DefaultManagementNetworkFinderImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/DefaultManagementNetworkFinderImplTest.java
4 files changed, 160 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/33275
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f8f0d53096523414ceb339d1b43224b540e0f78
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: Add getManagementNetworks to NetworkDao
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add getManagementNetworks to NetworkDao
......................................................................
engine: Add getManagementNetworks to NetworkDao
Add getManagementNetworks method to NetworkDao and
GetAllManagementNetworksByDataCenterId stored procedure.
Change-Id: I967abeb41bfc086962cdcc3c3878e16cbaa4636b
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/…
[View More]dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M packaging/dbscripts/network_sp.sql
4 files changed, 42 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/33252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I967abeb41bfc086962cdcc3c3878e16cbaa4636b
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: Add ManagementNetworkUtil
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add ManagementNetworkUtil
......................................................................
engine: Add ManagementNetworkUtil
Add ManagementNetworkUtil + its test.
Change-Id: I4117f9e97e721c847f5192e1ab724c8d231ce4f3
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java
A backend/…
[View More]manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImpl.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImplTest.java
3 files changed, 213 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/32992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4117f9e97e721c847f5192e1ab724c8d231ce4f3
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: add getManagementNetwork to NetworkDao
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: add getManagementNetwork to NetworkDao
......................................................................
engine: add getManagementNetwork to NetworkDao
getManagementNetwork method was added to NetworkDao
Implementation, test and SP were added too.
Change-Id: I6af5a554ed743ff748b5c941f77a0b217761bd5b
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/dal/src/main/…
[View More]java/org/ovirt/engine/core/dao/network/NetworkDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/network_sp.sql
6 files changed, 73 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/32978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6af5a554ed743ff748b5c941f77a0b217761bd5b
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: Rename getEngineNetwork to getDefaultManagementNetwo...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Rename getEngineNetwork to getDefaultManagementNetworkName
......................................................................
engine: Rename getEngineNetwork to getDefaultManagementNetworkName
Rename method NetworkUtils.getEngineNetwork to
getDefaultManagementNetworkName.
Change-Id: I64fd5df07dc3bef7f4d683ca22613fd4ec750874
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/…
[View More]manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
14 files changed, 23 insertions(+), 23 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/32811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64fd5df07dc3bef7f4d683ca22613fd4ec750874
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: Change ManagementNetwork to DefaultManagementNetwork
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Change ManagementNetwork to DefaultManagementNetwork
......................................................................
engine: Change ManagementNetwork to DefaultManagementNetwork
Change option name from ManagementNetwork to DefaultManagementNetwork:
1. DB - update script was added
2. backend code was updated accordingly
3. ConfigurationValues enum and the UI code that relates to that were
updated too in …
[View More]order to keep tests pass. UI logic related to the
management network remained unchanged in this patch, it will be updated
in the upcoming patches.
Change-Id: Ic36e4c7bf50d307efaf6d259be99c52bc3ef8e26
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewProfileBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/03_06_0850_update_management_network_vdc_option.sql
20 files changed, 24 insertions(+), 22 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/32810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic36e4c7bf50d307efaf6d259be99c52bc3ef8e26
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Anonymous Coward #1000397
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months
Change in ovirt-engine[master]: engine: Add setNetworkExclusivelyAsManagement to NetworkClus...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add setNetworkExclusivelyAsManagement to NetworkClusterDao
......................................................................
engine: Add setNetworkExclusivelyAsManagement to NetworkClusterDao
Add setNetworkExclusivelyAsManagement method to NetworkClusterDao
and its implementation.
Change-Id: I5315d5bd634a94f7a5aadb51de86a14cbafdaf3e
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M …
[View More]backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java
M packaging/dbscripts/network_sp.sql
4 files changed, 50 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/32782
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5315d5bd634a94f7a5aadb51de86a14cbafdaf3e
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Anonymous Coward #1000397
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 4 months