Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Forbid cluster version change if a VM is active
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Forbid cluster version change if a VM is active
......................................................................
webadmin: Forbid cluster version change if a VM is active
Cluster version change is not allowed when there is
an active VM in the cluster.
All VMs have to be restarted to allow reconfiguration after cluster
version change.
Check is performed on:
- UI: ClusterModel.validate()
- UpdateClusterCommand.validate()
Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1
Bug-Url: https://bugzilla.redhat.com/1336527
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ClusterVersionChangeValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 66 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/58125
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[refs/meta/config]: Added same permissions for 4.* as in 3.5/6.*
by dcaro@redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added same permissions for 4.* as in 3.5/6.*
......................................................................
Added same permissions for 4.* as in 3.5/6.*
Change-Id: I0ee023a8abff3791ae45d0d9bf95f2972c21ea58
---
M project.config
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Barak Korren: Looks good to me, but someone else must approve
Gil Shinar: Verified
David Caro: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58021
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ee023a8abff3791ae45d0d9bf95f2972c21ea58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: display: Fix display type enum order
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: display: Fix display type enum order
......................................................................
display: Fix display type enum order
Java enums start with ordinal 0. Synchronize the agent enum map with
hosted-engine.
Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844
Related-To: https://bugzilla.redhat.com/1326810
Related-To: https://bugzilla.redhat.com/1328921
Bug-Url: https://bugzilla.redhat.com/1339305
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58176
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-hosted-engine-ha[master]: display: Fix display type enum order
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: display: Fix display type enum order
......................................................................
display: Fix display type enum order
Java enums start with ordinal 0. Synchronize the agent enum map with
hosted-engine.
Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844
Related-To: https://bugzilla.redhat.com/1326810
Related-To: https://bugzilla.redhat.com/1328921
Bug-Url: https://bugzilla.redhat.com/1339305
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml
M ovirt_hosted_engine_ha/lib/ovf/ovf_test_max_vcpu.xml
3 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58171
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: Update provider popup
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Update provider popup
......................................................................
webadmin: Update provider popup
- Updated provider popup to be patternfly based.
Change-Id: I5cbdc1227e2766e831e5df77415ef94a4b375fc1
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/VmwarePropertiesWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/VmwarePropertiesWidget.ui.xml
3 files changed, 78 insertions(+), 64 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cbdc1227e2766e831e5df77415ef94a4b375fc1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[master]: node: Pull updates from the regular ovirt repositories
by fabiand@redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: node: Pull updates from the regular ovirt repositories
......................................................................
node: Pull updates from the regular ovirt repositories
Previously jenkins repositories got injected.
Change-Id: I127b3e0dc7ece602a29e0116f01570d930371fbf
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58173
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I127b3e0dc7ece602a29e0116f01570d930371fbf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[master]: node: Add imgbase-motd.service
by fabiand@redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: node: Add imgbase-motd.service
......................................................................
node: Add imgbase-motd.service
To generate the motd.
Change-Id: Id38bc18a3e20e9ef18a5ba4ad577547c500d87ac
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id38bc18a3e20e9ef18a5ba4ad577547c500d87ac
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[master]: node: Use sshd.service
by fabiand@redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: node: Use sshd.service
......................................................................
node: Use sshd.service
Don't use socket, see bug.
Change-Id: I8bb6bc6050a93dc407e40842fe6674c7fee69b17
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1327332
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bb6bc6050a93dc407e40842fe6674c7fee69b17
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: sla: Mark CPU_OVERCOMMIT_DURATION as editable in balancing u...
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: sla: Mark CPU_OVERCOMMIT_DURATION as editable in balancing units
......................................................................
sla: Mark CPU_OVERCOMMIT_DURATION as editable in balancing units
This patch re-adds the CPU_OVERCOMMIT_DURATION field to the
scheduling unit annotations to make it visible in the UI and
editable in the scheduling policy dialogs.
Change-Id: I215cbc9bef44771259c5747a24b01321a3b0e005
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339640
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
2 files changed, 21 insertions(+), 18 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Jenny Tokar: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58064
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I215cbc9bef44771259c5747a24b01321a3b0e005
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-hosted-engine-ha[master]: Add hostname in ovirt-ha-agent emails
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Add hostname in ovirt-ha-agent emails
......................................................................
Add hostname in ovirt-ha-agent emails
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1324673
Change-Id: I6489ea2e6911360fa19915b347f9a2deffb107f8
Signed-off-by: mshira <mshira(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/notifications/state_transition.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6489ea2e6911360fa19915b347f9a2deffb107f8
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Maximov Maximov <mshira(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Maximov Maximov <mshira(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Stanislav Mikhalevich <msio57(a)gmail.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months