Change in jenkins[master]: Don't override the result var on scrub
by dcaro@redhat.com
David Caro has submitted this change and it was merged.
Change subject: Don't override the result var on scrub
......................................................................
Don't override the result var on scrub
That was giving false positives
Change-Id: I1fb3ab76cacbfd8ccf31c9d3a27588cc05b9ac29
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M mock_configs/mock_runner.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/57743
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fb3ab76cacbfd8ccf31c9d3a27588cc05b9ac29
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: Revert "core: Kernel cmdline - host deploy"
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Revert "core: Kernel cmdline - host deploy"
......................................................................
Revert "core: Kernel cmdline - host deploy"
This reverts commit aeb98b5a5ac807d23008ed26293244efab103bde.
Change-Id: I3961f8683b12f0eabc67958f89bb575076fd5086
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployKernelUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployUnit.java
3 files changed, 13 insertions(+), 76 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57742
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3961f8683b12f0eabc67958f89bb575076fd5086
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: possible NPE in VdcActionUtils
by mbetak@redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: webadmin: possible NPE in VdcActionUtils
......................................................................
webadmin: possible NPE in VdcActionUtils
In some rare cases the VdcActionUtils.canExecute can receive entities == null
causing NPE.
Fixed by a simple null check since the null entity can not execute any actions
on it.
Change-Id: I47c7694928ad40dda6840e526964dcf78555ad66
Bug-Url: https://bugzilla.redhat.com/1324066
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57719
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47c7694928ad40dda6840e526964dcf78555ad66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Kernel cmdline - host deploy
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Kernel cmdline - host deploy
......................................................................
core: Kernel cmdline - host deploy
This feature allows to customize kernel commandline (bootloader
configuration) of hosts.
New VdsDeployUnit setting two environment variables
KernelEnv#CMDLINE_NEW and KernelEnv#CMDLINE_OLD to current and last
applied kernel command line. After successful host deploy database
column vds_static.last_stored_kernel_cmdline is updated.
Change-Id: I314d96cc9970b07311e620bd4c4e2c878726fb72
Bug-Url: https://bugzilla.redhat.com/1301104
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployKernelUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployUnit.java
3 files changed, 78 insertions(+), 15 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57052
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I314d96cc9970b07311e620bd4c4e2c878726fb72
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: sort the vms lists in import vms window
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: sort the vms lists in import vms window
......................................................................
webadmin: sort the vms lists in import vms window
This is a followup patch to patch:
2b5170fcf6b5e04e4cb9e02319ac54159362e71f
This patch is not adding any new functionality. It just includes
cleaner coding solution than the previous patch.
Change-Id: Ibf08071c57bafd3c76691dbc314c6c8aa8cf37e0
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EntityModelLexoNumericNameableComparator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
2 files changed, 30 insertions(+), 58 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/57683
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf08071c57bafd3c76691dbc314c6c8aa8cf37e0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Clear device addresses on machine type change
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Clear device addresses on machine type change
......................................................................
core: Clear device addresses on machine type change
When user changes VM machine type, the device addresses are (possibly)
wrong due to topology changes. To avoid issues with VM startup, the
Engine should drop device addresses when machine type is changed.
Dropping VM devices hash in VmDevicesMonitoring forces
VmDevicesMonitoring to update all information about VM's devices on the
next poll.
Change-Id: I14fedf30e64069605e2c2bd849fbba26b992d5dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1330988
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java
M packaging/dbscripts/vm_device_sp.sql
4 files changed, 48 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57537
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14fedf30e64069605e2c2bd849fbba26b992d5dd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-guest-agent[master]: Version Bump 1.0.12 - For ovirt 4.0
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Version Bump 1.0.12 - For ovirt 4.0
......................................................................
Version Bump 1.0.12 - For ovirt 4.0
Change-Id: Ie52dde8f113d69942072c027b9d627f18e216a72
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ChangeLog
M configure.ac
M ovirt-guest-agent.rhel6.spec
M ovirt-guest-agent.spec
4 files changed, 309 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified; Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie52dde8f113d69942072c027b9d627f18e216a72
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-guest-agent[master]: Map architectures i[356]86 to x86
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Map architectures i[356]86 to x86
......................................................................
Map architectures i[356]86 to x86
Because architectures i386,i586 and i686 aren't understood by the engine
we have to map them to x86
Change-Id: Idca38acbe9a62d50016d3f177eaf3d028487a0b9
Bug-Url: https://bugzilla.redhat.com/1332723
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M scripts/ovirt-osinfo
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/56995
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idca38acbe9a62d50016d3f177eaf3d028487a0b9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Prepare for next release
......................................................................
cli: Prepare for next release
In preparation for the next release this patch increases the version
number and sets the RPM release number to 0.1.
Change-Id: I43f603efa2cebf47dd2c009f0a7338a01196401d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M setup.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43f603efa2cebf47dd2c009f0a7338a01196401d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine-cli[cli_3.6]: cli: Release 3.6.2.1
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Release 3.6.2.1
......................................................................
cli: Release 3.6.2.1
Change-Id: I15e3bade3a3d5b332cbff9e8aee4b0e1e5a14aef
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M ovirt-engine-cli.spec.in
M setup.py
3 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57729
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15e3bade3a3d5b332cbff9e8aee4b0e1e5a14aef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months