Change in ovirt-engine[master]: engine: set ovirtmgmt net as display and migration
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: set ovirtmgmt net as display and migration
......................................................................
engine: set ovirtmgmt net as display and migration
Set ovirtmgmt network as display and migration
in the initailly created default cluster.
Change-Id: I278fec6e6ef0540b6487a70216f8b01006fa8b1e
Bug-Url: https://bugzilla.redhat.com/1322515
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M packaging/dbscripts/data/01000_insert_network_cluster.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, approved
Alona Kaplan: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/56645
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I278fec6e6ef0540b6487a70216f8b01006fa8b1e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Introduce Network Filter Dao
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Introduce Network Filter Dao
......................................................................
engine: Introduce Network Filter Dao
Adding network_filter table to schema.
Currently, the table is designated to be immutable.
The NetworkFilterDao API is exposing the following methods:
1. getAllNetworkFilters
2. getAllSupportedNetworkFiltersByVersion
3. getNetworkFilterById
4. getMinimalSupportedVersionByNetworkFilterName
5. getNetworkFilterByName
Bug-Url: https://bugzilla.redhat.com/1317441
Change-Id: I189ca3c702d406778d64266c749acaa85215724e
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllNetworkFiltersQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSupportedNetworkFiltersByVersionQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMinimalSupportedVersionByNetworkFilterNameQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworkFilterByIdQuery.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VersionQueryParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkFilter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkFilterDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/04_00_0560_add_netwrok_filter_table.sql
14 files changed, 584 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I189ca3c702d406778d64266c749acaa85215724e
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Introduce VersionRowMapper
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Introduce VersionRowMapper
......................................................................
engine: Introduce VersionRowMapper
Change-Id: Ifc3ee36da3ef11c10b0003ad2f3179aa54da2bad
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VersionRowMapper.java
1 file changed, 22 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52767
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc3ee36da3ef11c10b0003ad2f3179aa54da2bad
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: jsonrpc: version bump
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: jsonrpc: version bump
......................................................................
jsonrpc: version bump
Change-Id: I6edc49f59d14dbc58508b46ef88314e98f355d7d
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1320128
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56647
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6edc49f59d14dbc58508b46ef88314e98f355d7d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Return emptyList to avoid possible NPE
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Return emptyList to avoid possible NPE
......................................................................
core: Return emptyList to avoid possible NPE
Found possible null pointer exception in the Affinity Rules Enforcement
Manager.
The NPE is caused when findVmViolatingPositiveAg returns null and then
the method isEmpty (From the List Interface) is invoked on that value.
This bug was fixed by Returning empty list instead of null.
Change-Id: I92a7df2771bba55db485fc0c265dcb367c092102
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47994
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92a7df2771bba55db485fc0c265dcb367c092102
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Refactor RemoveVmPoolCommandCallback
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: engine: Refactor RemoveVmPoolCommandCallback
......................................................................
engine: Refactor RemoveVmPoolCommandCallback
Refactor RemoveVmPoolCommandCallback in order to inherit from
ConcurrentChildCommandsExecutionCallback.
Change-Id: I7723b6e92fba247bbd0d2a536966fa00d0278050
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommandCallback.java
1 file changed, 12 insertions(+), 47 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Freddy Rolland: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7723b6e92fba247bbd0d2a536966fa00d0278050
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in jenkins[master]: fixed ssh credentials in system_gerrit-exproll
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: fixed ssh credentials in system_gerrit-exproll
......................................................................
fixed ssh credentials in system_gerrit-exproll
Change-Id: Iea5506bd2690c9229b5f80f2716822b076443a57
Signed-off-by: ngoldin <ngoldin(a)redhat.com>
---
M jobs/confs/projects/system/system_gerrit-exproll.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nadav Goldin: Verified; Ready for review
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56867
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea5506bd2690c9229b5f80f2716822b076443a57
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Show only assignable host devices in frontend
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Show only assignable host devices in frontend
......................................................................
core: Show only assignable host devices in frontend
VDSM now reports which host devices can be used for hostdev passthrough
purposes via the "is_assignable" flag. This patch adds parsing of this
field and uses it on the frontend to filter devices that will be offered
to the user for assignment.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303160
Change-Id: I7d7b52ca10368a8fe0802d0ececfb8f1c12ebbe5
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDevice.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/AddVmHostDevicesModel.java
M packaging/dbscripts/host_device_sp.sql
A packaging/dbscripts/upgrade/03_06_2110_add_host_device_is_assignable.sql
9 files changed, 70 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56688
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d7b52ca10368a8fe0802d0ececfb8f1c12ebbe5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: Make tenant field available for external providers
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Make tenant field available for external providers
......................................................................
webadmin: Make tenant field available for external providers
The tenant field should be available for external providers,
but should not be mandatory like for openstack network provider.
Change-Id: Iab5050d0fe6abdcec2c90b61ba9a28fd5d64067e
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
2 files changed, 19 insertions(+), 10 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56593
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab5050d0fe6abdcec2c90b61ba9a28fd5d64067e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: vdsbroker: check connection identifier during policy reset
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: vdsbroker: check connection identifier during policy reset
......................................................................
vdsbroker: check connection identifier during policy reset
We need to check whether we need to wait for the connection to reconnect
during policy reset. We can based our decision of connection identifier.
Change-Id: I58a1e7d4b3024be0be3f76e3dd4092003b1cdfe7
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1320128
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Moti Asayag: Looks good to me, approved
Oved Ourfali: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56279
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58a1e7d4b3024be0be3f76e3dd4092003b1cdfe7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months