Change in ovirt-engine[ovirt-engine-4.0.1]: webadmin: On NUMA pinning update send a fully populated NUMA...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: On NUMA pinning update send a fully populated NUMA node
......................................................................
webadmin: On NUMA pinning update send a fully populated NUMA node
When updating NUMA nodes through the NUMA window, reachable through
'NUMA Support' in the host context menu, the CPU indices of the NUMA
nodes were not sent to the backend. As a consequence the NUMA mapping
was partially deleted in the DB, leaving the VM in an inconsistent
state.
Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27
Bug-Url: https://bugzilla.redhat.com/1324830
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60512
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.1
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0.1]: core: remove inaccessible memory during upgrade
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove inaccessible memory during upgrade
......................................................................
core: remove inaccessible memory during upgrade
This patch fixes an issue discovered in the upgrade process where the
upgrade fails while trying to convert memory volumes on a storage
domain that does not exist in the system to disk images.
So before doing the conversion, such memory volumes are first being
removed. They are unusable anyway.
Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82
Bug-Url: https://bugzilla.redhat.com/1353219
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60449
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: On NUMA pinning update send a fully populated NUMA...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: On NUMA pinning update send a fully populated NUMA node
......................................................................
webadmin: On NUMA pinning update send a fully populated NUMA node
When updating NUMA nodes through the NUMA window, reachable through
'NUMA Support' in the host context menu, the CPU indices of the NUMA
nodes were not sent to the backend. As a consequence the NUMA mapping
was partially deleted in the DB, leaving the VM in an inconsistent
state.
Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27
Bug-Url: https://bugzilla.redhat.com/1324830
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in jenkins[master]: ovirt-engine-wildfly-overlay: move from fc22 to fc24
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine-wildfly-overlay: move from fc22 to fc24
......................................................................
ovirt-engine-wildfly-overlay: move from fc22 to fc24
- Dropped FC22 build after FC22 EOL
- Added FC24 build for WildFly 10
Change-Id: If2933cbf08cd7becc450f9bbd687a091b39a73ec
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60478
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2933cbf08cd7becc450f9bbd687a091b39a73ec
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: ui: Template version sort not working properly.
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: ui: Template version sort not working properly.
......................................................................
ui: Template version sort not working properly.
When the column was only numbers it was soring good,
Now that we have name and number we need to use LexoNumericComparator
which is the default.
Bug-Url: https://bugzilla.redhat.com/1273825
Change-Id: I8ad1f5f3a4ce1e42ec1519dabdf9f67ed260da3b
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ad1f5f3a4ce1e42ec1519dabdf9f67ed260da3b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0.1]: restapi: Remove old template disks API and introduce templat...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Remove old template disks API and introduce template attachments
......................................................................
restapi: Remove old template disks API and introduce template attachments
The templates/{template_id}/disks is an old API and should be removed.
All template disks operations operations in V4 should be done
through templates/{template_id}/diskattachments which was added in this
patch.
Change-Id: I6b7428969b6692c536abc15d99a7bc3317ad88f8
Bug-Url: https://bugzilla.redhat.com/1353175
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskAttachmentResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskAttachmentsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
3 files changed, 100 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b7428969b6692c536abc15d99a7bc3317ad88f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0.1]: restapi: Support disk plug/unplug to VM
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Support disk plug/unplug to VM
......................................................................
restapi: Support disk plug/unplug to VM
Support disk plug/unplug to VM via REST API, the plug unplug will be done
through the vms/{vm_id}/diskattachments/{disk_id} via a PUT request as
follows:
<disk_attachment>
<active>true/false</active>
</disk_attachment>
Change-Id: Id024656cb78b82a29414f53a44edf30a1159785c
Bug-Url: https://bugzilla.redhat.com/1352966
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60508
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id024656cb78b82a29414f53a44edf30a1159785c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0.1]: restapi: Update to model 4.0.27 and metamodel 1.0.16
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Update to model 4.0.27 and metamodel 1.0.16
......................................................................
restapi: Update to model 4.0.27 and metamodel 1.0.16
The relevant changes in this version of the model are the following:
* Add the `active` flag to `DiskAttachment` type.
* Add the template disk attachments services and types, replacing the
`disks` collection.
* Add the `from` parameter of the events service.
Change-Id: I1d9dc1d3e16ab69c9a0fc2cb5251f9aae95e531b
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.adoc
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotInAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3TemplateOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VMInAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplatesServer.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M pom.xml
19 files changed, 391 insertions(+), 105 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60507
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d9dc1d3e16ab69c9a0fc2cb5251f9aae95e531b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 4 months
Change in ovirt-engine[master]: core: Squash 03_05 upgrade scripts into base db
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Squash 03_05 upgrade scripts into base db
......................................................................
core: Squash 03_05 upgrade scripts into base db
This patch introduces all changes made in dbscripts/upgrade/03_05*
scripts into the base database.
The process of squashing is :
1) creating a git branch with only the squashed version upgrade
scripts
2) generating schema and insert files (automatically by pg_dump)
3) restoring all deleted upgrade files with version > squashed
version that were deleted in 1)
4) creating a database based on 1) to 3)
5) creating a database on master
6) using the database comparison tool to verify both databases
are identical (except some generated UUIDs
Change-Id: I0ccd91460ae86af8201302a9abc41149714ef0fd
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/create_tables.sql
M packaging/dbscripts/data/00000_insert_schema_version.sql
M packaging/dbscripts/data/00200_insert_ad_groups.sql
M packaging/dbscripts/data/00300_insert_storage_pool.sql
M packaging/dbscripts/data/00340_insert_policy_units.sql
M packaging/dbscripts/data/00350_insert_cluster_policies.sql
M packaging/dbscripts/data/00360_insert_cluster_policy_units.sql
M packaging/dbscripts/data/00400_insert_vds_groups.sql
M packaging/dbscripts/data/00500_insert_roles.sql
M packaging/dbscripts/data/00600_insert_permissions.sql
M packaging/dbscripts/data/00700_insert_roles_groups.sql
M packaging/dbscripts/data/00900_insert_network.sql
M packaging/dbscripts/data/01000_insert_network_cluster.sql
M packaging/dbscripts/data/01100_insert_vm_static.sql
M packaging/dbscripts/data/01200_insert_vm_device.sql
M packaging/dbscripts/data/01300_insert_vm_ovf_generations.sql
M packaging/dbscripts/data/01400_insert_action_version_map.sql
M packaging/dbscripts/data/01500_insert_event_map.sql
M packaging/dbscripts/data/01600_insert_dwh_history_timekeeping.sql
M packaging/dbscripts/data/02000_insert_vm_init.sql
M packaging/dbscripts/dbfunc-common.sh
D packaging/dbscripts/upgrade/03_05_0010_add_tables_for_gluster_volume_and_brick_details.sql
D packaging/dbscripts/upgrade/03_05_0020_gluster_refresh_gluster_volume_details-event_map.sql
D packaging/dbscripts/upgrade/03_05_0030_add_ha_columns_to_vds_statistics.sql
D packaging/dbscripts/upgrade/03_05_0040_add_ha_maintenance_events.sql
D packaging/dbscripts/upgrade/03_05_0050_event_notification_methods.sql
D packaging/dbscripts/upgrade/03_05_0060_event_map_vds_failure.sql
D packaging/dbscripts/upgrade/03_05_0070_fix_event_notfication_method.sql
D packaging/dbscripts/upgrade/03_05_0080_add_missing_manipulate_users_permissions.sql
D packaging/dbscripts/upgrade/03_05_0090_delete_network_labels_action_groups.sql
D packaging/dbscripts/upgrade/03_05_0100_allow_values_higher_9_for_cpuovercommit.sql
D packaging/dbscripts/upgrade/03_05_0110_add_vm_serial_number_policy.sql
D packaging/dbscripts/upgrade/03_05_0120_add_storage_domain_ovf.sql
D packaging/dbscripts/upgrade/03_05_0130_add_ovf_data_column.sql
D packaging/dbscripts/upgrade/03_05_0140_add_install_vds_upgrade_ovirt_node_action_group.sql
D packaging/dbscripts/upgrade/03_05_0150_remove_import_export_permission_from_user_instance_manager_role.sql
D packaging/dbscripts/upgrade/03_05_0160_add_host_interface_high_network_use_event.sql
D packaging/dbscripts/upgrade/03_05_0170_add_boot_time_to_vds_statistics.sql
D packaging/dbscripts/upgrade/03_05_0180_vm_init_add_sysprep_locale.sql
D packaging/dbscripts/upgrade/03_05_0190_vm_init_add_user_name.sql
D packaging/dbscripts/upgrade/03_05_0200_vm_init_add_active_directory_ou.sql
D packaging/dbscripts/upgrade/03_05_0210_change_group_ids.sql
D packaging/dbscripts/upgrade/03_05_0220_update_user_ids.sql
D packaging/dbscripts/upgrade/03_05_0230_add_host_interface_status_change_events.sql
D packaging/dbscripts/upgrade/03_05_0240_change_external_id_to_string.sql
D packaging/dbscripts/upgrade/03_05_0250_add_reason_columns.sql
D packaging/dbscripts/upgrade/03_05_0260_add_exit_reason_to_vm_dynamic.sql
D packaging/dbscripts/upgrade/03_05_0270_update_template_version_naming.sql
D packaging/dbscripts/upgrade/03_05_0280_add_vm_boot_menu.sql
D packaging/dbscripts/upgrade/03_05_0290_drop_vds_group_id_constraint_from_vm_static.sql
D packaging/dbscripts/upgrade/03_05_0300_add_host_kdump_detection.sql
D packaging/dbscripts/upgrade/03_05_0310_add_host_kdump_status.sql
D packaging/dbscripts/upgrade/03_05_0320_add_vds_interface_custom_properties.sql
D packaging/dbscripts/upgrade/03_05_0330_nullify_external_network_labels.sql
D packaging/dbscripts/upgrade/03_05_0340_add_migration_progress_percent_to_vm_dynamic.sql
D packaging/dbscripts/upgrade/03_05_0350_add_display_network_change_events.sql
D packaging/dbscripts/upgrade/03_05_0360_add_audit_log_operation_action_group_and_roles.sql
D packaging/dbscripts/upgrade/03_05_0370_add_base_interface_column_to_vds_interfaces.sql
D packaging/dbscripts/upgrade/03_05_0380_reintroduce_powersaving_variables.sql
D packaging/dbscripts/upgrade/03_05_0390_add_guest_cpu_count_to_vm_dynamic.sql
D packaging/dbscripts/upgrade/03_05_0400_index_for_snapshot_type.sql
D packaging/dbscripts/upgrade/03_05_0410_add_selinux_to_vds_dynamic.sql
D packaging/dbscripts/upgrade/03_05_0420_generalize_messaging_broker_type.sql
D packaging/dbscripts/upgrade/03_05_0430_add_numa_tables_and_columns.sql
D packaging/dbscripts/upgrade/03_05_0440_add_create_and_update_dates_to_users_table.sql
D packaging/dbscripts/upgrade/03_05_0450_set_default_value_for_numa_tune_mode.sql
D packaging/dbscripts/upgrade/03_05_0460_set_display_migration_cluster_network.sql
D packaging/dbscripts/upgrade/03_05_0470_update_vm_static_child_count.sql
D packaging/dbscripts/upgrade/03_05_0480_add_org_name_for_sysprep.sql
D packaging/dbscripts/upgrade/03_05_0490_remove_duplicate_smartcards.sql
D packaging/dbscripts/upgrade/03_05_0500_add_rng_device_columns.sql
D packaging/dbscripts/upgrade/03_05_0510_unregistered_ovf_of_entities.sql
D packaging/dbscripts/upgrade/03_05_0520_fix_description_of_balancing_policy_units.sql
D packaging/dbscripts/upgrade/03_05_0530_remove_unused_event.sql
D packaging/dbscripts/upgrade/03_05_0540_add_spice_transfer_toggle.sql
D packaging/dbscripts/upgrade/03_05_0550_add_live_snapshot_support.sql
D packaging/dbscripts/upgrade/03_05_0560_aaa_add_namespace.sql
D packaging/dbscripts/upgrade/03_05_0570_deprecate_broken_snapshots.sql
D packaging/dbscripts/upgrade/03_05_0580_add_default_instance_types.sql
D packaging/dbscripts/upgrade/03_05_0590_set_default_time_zone.sql
D packaging/dbscripts/upgrade/03_05_0600_drop_images_fk.sql
D packaging/dbscripts/upgrade/03_05_0610_add_command_entity_table.sql
D packaging/dbscripts/upgrade/03_05_0620_lowercase_default_cluster_policies_names.sql
D packaging/dbscripts/upgrade/03_05_0630_add_host_protocol.sql
D packaging/dbscripts/upgrade/03_05_0640_add_external_variable.sql
D packaging/dbscripts/upgrade/03_05_0650_add_vds_kdump_status.sql
D packaging/dbscripts/upgrade/03_05_0660_remove_command_from_async_tasks.sql
D packaging/dbscripts/upgrade/03_05_0670_add_cmd_entity_callback_enabled.sql
D packaging/dbscripts/upgrade/03_05_0680_add_cmd_entity_callback_notified.sql
D packaging/dbscripts/upgrade/03_05_0690_add_cmd_entity_return_value.sql
D packaging/dbscripts/upgrade/03_05_0700_create_vm_jobs_table.sql
D packaging/dbscripts/upgrade/03_05_0710_add_manipulate_permissions_for_template_admin.sql
D packaging/dbscripts/upgrade/03_05_0720_index_for_stoarge_domain_id_in_unregistered_ovf_of_entities.sql
D packaging/dbscripts/upgrade/03_05_0730_drop_disk_image_dynamic_fk.sql
D packaging/dbscripts/upgrade/03_05_0740_min_allocated_memory_on_instance_type.sql
D packaging/dbscripts/upgrade/03_05_0750_delete_orphand_disk_image_dynamic_records.sql
R packaging/dbscripts/upgrade/03_06_0000_set_version.sql
97 files changed, 614 insertions(+), 1,078 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60328
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ccd91460ae86af8201302a9abc41149714ef0fd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: restapi: Avoid NPE when external event has link but not id
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Avoid NPE when external event has link but not id
......................................................................
restapi: Avoid NPE when external event has link but not id
Currently when an external event is added we support links to specific
objects, for examaple, to add an event with a link to a specific virtual
machine we accept the following event:
<event>
<description>File system /home is full</description>
<severity>alert</severity>
<origin>mymonitor</origin>
<custom_id>1467879754</custom_id>
<vm id="aae98225-5b73-490d-a252-899209af17e9"/>
</event>
But we don't check if the "id" attribute of the link is actually
populated, which generates a NPE. For example, if the caller sends the
name instead of the id:
<event>
<description>File system /home is full</description>
<severity>alert</severity>
<origin>mymonitor</origin>
<custom_id>1467879754</custom_id>
<vm>
<name>myvm</name>
</vm>
</event>
This isn't supported at the moment, but it shound't generate a NPE, it
should just be ignored.
This patch changes the event mapper so that it checks if the id is
present.
Change-Id: I13a174699e66833d6b31f50d0bb03967c178458e
Bug-Url: https://bugzilla.redhat.com/1353460
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java
1 file changed, 35 insertions(+), 21 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13a174699e66833d6b31f50d0bb03967c178458e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months