Change in ovirt-engine[master]: webadmin: On NUMA pinning update send a fully populated NUMA...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: On NUMA pinning update send a fully populated NUMA node
......................................................................
webadmin: On NUMA pinning update send a fully populated NUMA node
When updating NUMA nodes through the NUMA window, reachable through
'NUMA Support' in the host context menu, the CPU indices of the NUMA
nodes were not sent to the backend. As a consequence the NUMA mapping
was partially deleted in the DB, leaving the VM in an inconsistent
state.
Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27
Bug-Url: https://bugzilla.redhat.com/1324830
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.27 and metamodel 1.0.16
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Update to model 4.0.27 and metamodel 1.0.16
......................................................................
restapi: Update to model 4.0.27 and metamodel 1.0.16
The relevant changes in this version of the model are the following:
* Add the `active` flag to `DiskAttachment` type.
* Add the template disk attachments services and types, replacing the
`disks` collection.
* Add the `from` parameter of the events service.
Change-Id: I1d9dc1d3e16ab69c9a0fc2cb5251f9aae95e531b
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.adoc
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotInAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3TemplateOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VMInAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplatesServer.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M pom.xml
19 files changed, 391 insertions(+), 105 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d9dc1d3e16ab69c9a0fc2cb5251f9aae95e531b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Support disk plug/unplug to VM
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Support disk plug/unplug to VM
......................................................................
restapi: Support disk plug/unplug to VM
Support disk plug/unplug to VM via REST API, the plug unplug will be done
through the vms/{vm_id}/diskattachments/{disk_id} via a PUT request as
follows:
<disk_attachment>
<active>true/false</active>
</disk_attachment>
Change-Id: Id024656cb78b82a29414f53a44edf30a1159785c
Bug-Url: https://bugzilla.redhat.com/1352966
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60452
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id024656cb78b82a29414f53a44edf30a1159785c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Remove old template disks API and introduce templat...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Remove old template disks API and introduce template attachments
......................................................................
restapi: Remove old template disks API and introduce template attachments
The templates/{template_id}/disks is an old API and should be removed.
All template disks operations operations in V4 should be done
through templates/{template_id}/diskattachments which was added in this
patch.
Change-Id: I6b7428969b6692c536abc15d99a7bc3317ad88f8
Bug-Url: https://bugzilla.redhat.com/1353175
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskAttachmentResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskAttachmentsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
3 files changed, 100 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b7428969b6692c536abc15d99a7bc3317ad88f8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine-sdk[sdk_4.0]: Use type name as the tag for method parameters
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use type name as the tag for method parameters
......................................................................
Use type name as the tag for method parameters
Currently the name of the XML tag used to represent the input parameters
of methods like "add" is the name of the parameter as described in the
model. For example, for the operation to add a disk attachment the name
of the parameter is "attachment", so the XML document generated and sent
by the SDK is something like this:
<attachment>
...
</attachment>
But the server doesn't expect this, it expects the name the XML tag
corresponding to the type of the parameter, in this case this case
"DiskAttachment", so the server expects the following:
<disk_attachment>
...
</disk_attachment>
It would be more correct to use the name of the parameter, as described
in the model, but it isn't factible to introduce such change in the
server side at this point, so we need to change the SDK to generate what
the server expects. That is what this patch does.
In the future, we will probably change the server so that it ignores the
root tag of the documents, then this patch can be reverted.
Change-Id: I18284685f5eefc981fd6769ac7e1ca998d586a81
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 1da5c57dae5f0974f6c5abb44c1b777834e059fc)
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18284685f5eefc981fd6769ac7e1ca998d586a81
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: core: remove inaccessible memory during upgrade
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove inaccessible memory during upgrade
......................................................................
core: remove inaccessible memory during upgrade
This patch fixes an issue discovered in the upgrade process where the
upgrade fails while trying to convert memory volumes on a storage
domain that does not exist in the system to disk images.
So before doing the conversion, such memory volumes are first being
removed. They are unusable anyway.
Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82
Bug-Url: https://bugzilla.redhat.com/1353219
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine-sdk[master]: Use type name as the tag for method parameters
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use type name as the tag for method parameters
......................................................................
Use type name as the tag for method parameters
Currently the name of the XML tag used to represent the input parameters
of methods like "add" is the name of the parameter as described in the
model. For example, for the operation to add a disk attachment the name
of the parameter is "attachment", so the XML document generated and sent
by the SDK is something like this:
<attachment>
...
</attachment>
But the server doesn't expect this, it expects the name the XML tag
corresponding to the type of the parameter, in this case this case
"DiskAttachment", so the server expects the following:
<disk_attachment>
...
</disk_attachment>
It would be more correct to use the name of the parameter, as described
in the model, but it isn't factible to introduce such change in the
server side at this point, so we need to change the SDK to generate what
the server expects. That is what this patch does.
In the future, we will probably change the server so that it ignores the
root tag of the documents, then this patch can be reverted.
Change-Id: I18284685f5eefc981fd6769ac7e1ca998d586a81
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60462
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18284685f5eefc981fd6769ac7e1ca998d586a81
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Translations of OriginType enum added
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Translations of OriginType enum added
......................................................................
webadmin: Translations of OriginType enum added
Explicite translations of OriginType.MANAGED_HOSTED_ENGINE and
OriginType.KVM
Change-Id: I87afbfcb31408925ed55d32d2ee6124cb6488e58
Bug-Url: https://bugzilla.redhat.com/1351477
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87afbfcb31408925ed55d32d2ee6124cb6488e58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine-sdk-java[sdk_4.0]: Add RPM spec file for Fedora 24
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add RPM spec file for Fedora 24
......................................................................
Add RPM spec file for Fedora 24
This patch adds a RPM spec file for Fedora 24.
Change-Id: I8c2562c55886506a0023e78038065b78d8290320
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 8d63281d3bc98e14351949f84f4097e45181e5cd)
---
A packaging/spec.fc24.in
1 file changed, 47 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60501
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c2562c55886506a0023e78038065b78d8290320
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine-sdk-java[master]: Add RPM spec file for Fedora 24
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add RPM spec file for Fedora 24
......................................................................
Add RPM spec file for Fedora 24
This patch adds a RPM spec file for Fedora 24.
Change-Id: I8c2562c55886506a0023e78038065b78d8290320
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A packaging/spec.fc24.in
1 file changed, 47 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c2562c55886506a0023e78038065b78d8290320
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months