July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Clear the POST body before sending requests
by juan.hernandez＠redhat.com 08 Jul '16

08 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Clear the POST body before sending requests ...................................................................... Clear the POST body before sending requests Currently the SDK doesn't clear the cURL POST body before sending requests, as a result the body of a previous POST request can interfere with a current GET request, causing an error in the server side. This patch changes the SDK so that the POST body is cleared before every request. Change-Id: I9df5a89dec28f4f252dc99fcc774ede017707d30 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/http.rb 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9df5a89dec28f4f252dc99fcc774ede017707d30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use type name as the tag for method parameters
by juan.hernandez＠redhat.com 08 Jul '16

08 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use type name as the tag for method parameters ...................................................................... Use type name as the tag for method parameters Currently the name of the XML tag used to represent the input parameters of methods like "add" is the name of the parameter as described in the model. For example, for the operation to add a disk attachment the name of the parameter is "attachment", so the XML document generated and sent by the SDK is something like this: <attachment> ... </attachment> But the server doesn't expect this, it expects the name the XML tag corresponding to the type of the parameter, in this case this case "DiskAttachment", so the server expects the following: <disk_attachment> ... </disk_attachment> It would be more correct to use the name of the parameter, as described in the model, but it isn't factible to introduce such change in the server side at this point, so we need to change the SDK to generate what the server expects. That is what this patch does. In the future, we will probably change the server so that it ignores the root tag of the documents, then this patch can be reverted. Change-Id: I2861cf05cb0a39a7f2bdbbafb72dcf0e3b56823d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2861cf05cb0a39a7f2bdbbafb72dcf0e3b56823d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Use the hosted storage domain id instead of name when ...
by piotr.kliczewski＠gmail.com 08 Jul '16

08 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Use the hosted storage domain id instead of name when importing it ...................................................................... core: Use the hosted storage domain id instead of name when importing it When importing hosted storage domain the system relied on a hardcoded name: "hosted_storage". Instead of using that constant to find and import the domain the code is now using the domain id that is reported by vdsm in the vm data. The system verifies that a hosted engine VM is running on a storage domain to determine if that domain is a hosted engine domain. Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70 Bug-Url: https://bugzilla.redhat.com/1301105 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 31d8036) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java A packaging/dbscripts/upgrade/04_00_0800_remove_hosted_engine_storage_domain_name_config_value.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 16 files changed, 106 insertions(+), 116 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/60255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove missing fedora builds from 3.6 publisher
by eedri＠redhat.com 08 Jul '16

08 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: remove missing fedora builds from 3.6 publisher ...................................................................... remove missing fedora builds from 3.6 publisher ovirt-engine & mom 3.6 stopped being built for fedora removing so publisher will work again. we still need to remove other projects but first they need to stop building it and it requires a patch per project Change-Id: Ibba9999aca027962debd830b3922b3c1f524e148 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 1 file changed, 10 insertions(+), 22 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibba9999aca027962debd830b3922b3c1f524e148 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Include disk plugged status in DiskVmElement
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Include disk plugged status in DiskVmElement ...................................................................... core: Include disk plugged status in DiskVmElement Change-Id: Iffac29dd8b075466356c4f2d116a8c7a3de1f32e Bug-Url: https://bugzilla.redhat.com/1352966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskVmElement.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/disk_vm_element_sp.sql 4 files changed, 36 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffac29dd8b075466356c4f2d116a8c7a3de1f32e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Change VmDevice plugged property to a primitive boolean
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change VmDevice plugged property to a primitive boolean ...................................................................... core: Change VmDevice plugged property to a primitive boolean Since VmDevice.getIsPlugged always returns a value of true/false we can change all legacy null values in the DB to false and return them as is without the redundant check. Change-Id: I53064843f448d4ef75baed0d5811e207080257fc Bug-Url: https://bugzilla.redhat.com/1352966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java A packaging/dbscripts/upgrade/04_00_0800_change_vm_device_null_plugged_values_to_false.sql 4 files changed, 15 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53064843f448d4ef75baed0d5811e207080257fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Missing replacement values for add cluster audit lo...
by mperina＠redhat.com 07 Jul '16

07 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Missing replacement values for add cluster audit log message ...................................................................... engine : Missing replacement values for add cluster audit log message Adding a new cluster generates audit log messages where the replacement values are missing and shows up as <UNKNOWN>. User/Group Everyone, Namespace *, Authorization provider: <UNKNOWN> was granted permission for Role CpuProfileOperator on Cpu Profile <UNKNOWN>, by admin@internal-authz. Change-Id: I82b936fabe938296a19857ba873953eca9696e8e Bug-Url: https://bugzilla.redhat.com/1350353 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60283 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82b936fabe938296a19857ba873953eca9696e8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Rename VM Pool related classes
by ahadas＠redhat.com 07 Jul '16

07 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Rename VM Pool related classes ...................................................................... core: Rename VM Pool related classes Renamed: * CommonVmPoolWithVmsCommand -> CommonVmPoolCommand * CommonVmPoolWithVmsCommandTestAbstract -> CommonVmPoolCommandTestAbstract * AddVmPoolWithVmsParameters -> AddVmPoolParameters Change-Id: I7c0ebcba8d0fc2c84f6a825e827acd4562747720 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolCommandTest.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 10 files changed, 35 insertions(+), 36 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c0ebcba8d0fc2c84f6a825e827acd4562747720 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Replacing jpackage repo for 3.6 dwh
by sbonazzo＠redhat.com 07 Jul '16

07 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Replacing jpackage repo for 3.6 dwh ...................................................................... Replacing jpackage repo for 3.6 dwh Change-Id: I1ff6e3a4ed3f7601efac690a801ad630c0aa8df3 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M jobs/confs/projects/ovirt-dwh/ovirt-dwh_create-rpms.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ff6e3a4ed3f7601efac690a801ad630c0aa8df3 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Place upgrade script in the right directory
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Place upgrade script in the right directory ...................................................................... core: Place upgrade script in the right directory Change-Id: I0daead1f0ae1f6bf16d349ccdc2294df182d7122 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- R packaging/dbscripts/upgrade/04_01_0130_change_vm_device_null_plugged_values_to_false.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0daead1f0ae1f6bf16d349ccdc2294df182d7122 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0