July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[master]: hosted-engine: prevent a race cond. between ha-agent and vdsm
by stirabos＠redhat.com 06 Jul '16

06 Jul '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: hosted-engine: prevent a race cond. between ha-agent and vdsm ...................................................................... hosted-engine: prevent a race cond. between ha-agent and vdsm Without this, host-deploy will first start ovirt-ha-agent that will bring up vdsm due to systemd dependencies but, just after that, host-deploy will (re)start vdsm. If ovirt-ha-agent is not quick enough, vdsm will be restarted in the middle of connectStorageServer that will not complete, because vdsm was stopped and does not continue such operations upon restart. On the other side, the timeout waiting for connectStorageServer to be completed is pretty long (900 seconds) so ovirt-ha-agent will take a lot of time to realize the issue. In the mean time, ovirt-ha-broker will fail accessing the shared storage and vdsm get the error and reports back a bad status to the engine and so adding the host from the webui could fail if ovirt-ha-agent is not fast enough. Reversing the start order of vdsm and ovirt-ha-agent will prevent this since ovirt-ha-agnet has Wants=vdsmd.service and After=vdsmd.service and both are met. Change-Id: I2e5dd0cb3c6cbfec00286b063558d379ade1def4 Bug-Url: https://bugzilla.redhat.com/1349532 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-common/hosted-engine/packages.py M src/plugins/ovirt-host-deploy/vdsm/packages.py 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e5dd0cb3c6cbfec00286b063558d379ade1def4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Add Hosted Engine VM detection
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Add Hosted Engine VM detection ...................................................................... packaging: Add Hosted Engine VM detection Add code to detect if we're running under Hosted Engine VM and abort the setup if the system is not currently in the Global Maintenance mode. An override key of 'OVESETUP_CONFIG/continueSetupOnHEVM' was added to allow skipping this test. Change-Id: I67d487c03f6791c3700f631977e6b4b4601f9f30 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1290073 --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/he.py 3 files changed, 122 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d487c03f6791c3700f631977e6b4b4601f9f30 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Add Cockpit to firewall
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Add Cockpit to firewall ...................................................................... packaging: setup: Add Cockpit to firewall Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098 Bug-Url: https://bugzilla.redhat.com/1335426 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/gr-he-setup/network/firewall.py M templates/Makefile.am A templates/hosted-cockpit.xml.in 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified Ryan Barry: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Conflict with python-daemon-2.1.0
by sbonazzo＠redhat.com 06 Jul '16

06 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Conflict with python-daemon-2.1.0 ...................................................................... core: Conflict with python-daemon-2.1.0 python-daemon-2.1.0 adds 'initgroups' parameter with default value True. That causes subsequential attempt of changing the process GID (in case the prameter is ommitted), which fails on insufficient privileges. This patch is an alternative approach to patch #58635 Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Bug-Url: https://bugzilla.redhat.com/1343155 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Allow passing of scheduling policy name for Update ...
by dfediuck＠redhat.com 06 Jul '16

06 Jul '16

Doron Fediuck has submitted this change and it was merged. Change subject: restapi: Allow passing of scheduling policy name for Update Cluster ...................................................................... restapi: Allow passing of scheduling policy name for Update Cluster This patch will enable auto-completion for the scheduling policy name in the SDK. Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315657 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Doron Fediuck: Passed CI tests Roy Golan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: jsonrpc: version bump
by tnisan＠redhat.com 06 Jul '16

06 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Change-Id: I12f0dd2759e046b241ac1790b15fb3384495b3c2 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Related-To: https://bugzilla.redhat.com/1349353 --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12f0dd2759e046b241ac1790b15fb3384495b3c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove redundant field from UpdateVmDiskCommand
by tnisan＠redhat.com 06 Jul '16

06 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant field from UpdateVmDiskCommand ...................................................................... core: Remove redundant field from UpdateVmDiskCommand Change-Id: I347c864fce8d255014e10113833b6b0b550a8b92 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I347c864fce8d255014e10113833b6b0b550a8b92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: after build dwh for 4.0.1
by Shirly Radco 06 Jul '16

06 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: after build dwh for 4.0.1 ...................................................................... build: after build dwh for 4.0.1 Change-Id: I95ed261ed9ef1ef4c362ae825a57f21e9c02418f Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95ed261ed9ef1ef4c362ae825a57f21e9c02418f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: update version for dwh build for 4.0.1
by Shirly Radco 06 Jul '16

06 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: update version for dwh build for 4.0.1 ...................................................................... build: update version for dwh build for 4.0.1 Change-Id: I66c0c053e6cec0c8221165ab540a8be1e1708ce1 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66c0c053e6cec0c8221165ab540a8be1e1708ce1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: remove hash from build name
by Shirly Radco 06 Jul '16

06 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: remove hash from build name ...................................................................... build: remove hash from build name Change-Id: Ia064b5d2ac938bb759948d07670eab40a7c7fc12 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M automation/build-artifacts.sh 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia064b5d2ac938bb759948d07670eab40a7c7fc12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0