July 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-engine_upgrade-db: drop 3.6.7 jobs
by sbonazzo＠redhat.com 07 Jul '16

07 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_upgrade-db: drop 3.6.7 jobs ...................................................................... ovirt-engine_upgrade-db: drop 3.6.7 jobs Change-Id: Ic399cef9e6612f70994b4fd7d42bf70179422f32 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Eyal Edri: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic399cef9e6612f70994b4fd7d42bf70179422f32 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: refresh fedora versions and release versions for ovirt-engine
by eedri＠redhat.com 07 Jul '16

07 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: refresh fedora versions and release versions for ovirt-engine ...................................................................... refresh fedora versions and release versions for ovirt-engine - remove 3.6.7 builds and jobs (released) - remove EOL fedora 22 - replace fedora 23 with new released fedora 24 for master - remove check-patch for fedora, while keeping it post merge Change-Id: Ie636859fd2bee9b484a792d2267c85929b0d5f76 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 45 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Eyal Edri: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie636859fd2bee9b484a792d2267c85929b0d5f76 Gerrit-PatchSet: 10 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Include disk plugged status in DiskVmElement
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Include disk plugged status in DiskVmElement ...................................................................... core: Include disk plugged status in DiskVmElement Change-Id: Iffac29dd8b075466356c4f2d116a8c7a3de1f32e Bug-Url: https://bugzilla.redhat.com/1352966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskVmElement.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/disk_vm_element_sp.sql 4 files changed, 36 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/60252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffac29dd8b075466356c4f2d116a8c7a3de1f32e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change VmDevice plugged property to a primitive boolean
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change VmDevice plugged property to a primitive boolean ...................................................................... core: Change VmDevice plugged property to a primitive boolean Since VmDevice.getIsPlugged always returns a value of true/false we can change all legacy null values in the DB to false and return them as is without the redundant check. Change-Id: I53064843f448d4ef75baed0d5811e207080257fc Bug-Url: https://bugzilla.redhat.com/1352966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A 04_01_0130_change_vm_device_null_plugged_values_to_false.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java 4 files changed, 15 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53064843f448d4ef75baed0d5811e207080257fc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move VdsmVm class
by ahadas＠redhat.com 07 Jul '16

07 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: move VdsmVm class ...................................................................... core: move VdsmVm class Move it to org.ovirt.engine.core.vdsbroker.monitoring package which is a more appropriate place for it. Change-Id: I12322041ac004bc00008bfab23c5d18b470d36da Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcherTest.java 14 files changed, 5 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12322041ac004bc00008bfab23c5d18b470d36da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add jobs for stable branches of API model and metamodel
by sbonazzo＠redhat.com 07 Jul '16

07 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add jobs for stable branches of API model and metamodel ...................................................................... Add jobs for stable branches of API model and metamodel This patch adds jobs to build artifacts and check patches for the stable branches of the API model and metamodel projects. Change-Id: I4a8056ad9a015480c198929bdadc04ad5ffa204c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-api-metamodel/ovirt-engine-api-metamodel_build.yaml M jobs/confs/projects/ovirt-engine-api-metamodel/ovirt-engine-api-metamodel_checks.yaml M jobs/confs/projects/ovirt-engine-api-model/ovirt-engine-api-model_build.yaml M jobs/confs/projects/ovirt-engine-api-model/ovirt-engine-api-model_checks.yaml 4 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a8056ad9a015480c198929bdadc04ad5ffa204c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add/update VM Pool commands refactoring
by ahadas＠redhat.com 07 Jul '16

07 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Add/update VM Pool commands refactoring ...................................................................... core: Add/update VM Pool commands refactoring Minor refactoring of add/update VM Pool commands: * Several fields and methods were renamed to more understandable names; * Access to several methods was restricted; * poolId is no more passed as argument; * getQuotaStorageConsumptionParameters() method now uses streams; * All conditions were moved from updatePoolVms() to isUpdateVmRequired(); * Unused diskSize field was removed from command parameters. Change-Id: I78167b8fb59faabe7217406f30e716c3050e91ea Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 10 files changed, 93 insertions(+), 108 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78167b8fb59faabe7217406f30e716c3050e91ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: webadmin: Sync file size and uploaded image's actual size.
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sync file size and uploaded image's actual size. ...................................................................... webadmin: Sync file size and uploaded image's actual size. When uploading an image, the actual image's size needs to be set, so the lv that is created in the storage will allocte enough size. currently, it is not being set, and the created LV is limited to 1GB. Change-Id: I486089be67439d950fad655f2a639d915d2fce4c Bug-Url: https://bugzilla.redhat.com/1353196 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486089be67439d950fad655f2a639d915d2fce4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Sync file size and uploaded image's actual size.
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sync file size and uploaded image's actual size. ...................................................................... webadmin: Sync file size and uploaded image's actual size. When uploading an image, the actual image's size needs to be set, so the lv that is created in the storage will allocte enough size. currently, it is not being set, and the created LV is limited to 1GB. Change-Id: I486089be67439d950fad655f2a639d915d2fce4c Bug-Url: https://bugzilla.redhat.com/1353196 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/60308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486089be67439d950fad655f2a639d915d2fce4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Sync file size and uploaded image's actual size.
by tnisan＠redhat.com 07 Jul '16

07 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sync file size and uploaded image's actual size. ...................................................................... webadmin: Sync file size and uploaded image's actual size. When uploading an image, the actual image's size needs to be set, so the lv that is created in the storage will allocte enough size. currently, it is not being set, and the created LV is limited to 1GB. Change-Id: I486089be67439d950fad655f2a639d915d2fce4c Bug-Url: https://bugzilla.redhat.com/1353196 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486089be67439d950fad655f2a639d915d2fce4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0