July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Teardown image after verifying upload.
by derez＠redhat.com 05 Jul '16

05 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: engine: Teardown image after verifying upload. ...................................................................... engine: Teardown image after verifying upload. When uploading an image finishes, the uploading session is revoked and the image is being verified in VDSM. currently in the revoking function (stopImageTransferSession) there's a call to teardown image, which makes it unreachable to VDSM when trying to verify it. Move the teardown call for after stopping the session. this way only when we finish using the image it will be teared down. If the stopImageTransferSession fails, don't tear down the image, as the session still alive, thus someone might still using it. Change-Id: I7b6587452c2d2879dd97ed2645dd4c348cb0175b Bug-Url: https://bugzilla.redhat.com/1352676 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/60192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b6587452c2d2879dd97ed2645dd4c348cb0175b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: ui: clarifying diskHotPlugNotSupported tool-tip message
by derez＠redhat.com 05 Jul '16

05 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: ui: clarifying diskHotPlugNotSupported tool-tip message ...................................................................... ui: clarifying diskHotPlugNotSupported tool-tip message Cluster version is not relevant any more for disk hot-plug support. Hence, amending the tool-tip message accordingly. Change-Id: Ibd31395fd566da4192122adf599da5c02d73ecd1 Bug-Url: https://bugzilla.redhat.com/1351636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60190 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd31395fd566da4192122adf599da5c02d73ecd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: restapi: Add support for generating random doubles
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add support for generating random doubles ...................................................................... restapi: Add support for generating random doubles Our testing framework generates random data for types, but it doesn't support the "double" type. This patch fixes that limitation. Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Related-To: https://bugzilla.redhat.com/1346918 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 1 file changed, 35 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60197 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: restapi: Support removing of vms/{vm_id}/disks from the API
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Support removing of vms/{vm_id}/disks from the API ...................................................................... restapi: Support removing of vms/{vm_id}/disks from the API Change-Id: Ied6664b2cbe31e3f5fea1d6264d671cb0d3b2a58 Bug-Url: https://bugzilla.redhat.com/1346918 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 72 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied6664b2cbe31e3f5fea1d6264d671cb0d3b2a58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: restapi: Update to model 4.0.26
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.26 ...................................................................... restapi: Update to model 4.0.26 The relevant changes in this version of the model are the following: * Removed the `disks` locator from the virtual machine service, as it has been replaced by `diskAttachments`. * Add the `host`, `destroy` and `format` parameters to the operation that removes a storage domain. Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/LinkHelperTest.java M pom.xml 4 files changed, 3 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Support removing of vms/{vm_id}/disks from the API
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Support removing of vms/{vm_id}/disks from the API ...................................................................... restapi: Support removing of vms/{vm_id}/disks from the API Change-Id: Ied6664b2cbe31e3f5fea1d6264d671cb0d3b2a58 Bug-Url: https://bugzilla.redhat.com/1346918 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 72 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied6664b2cbe31e3f5fea1d6264d671cb0d3b2a58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.26
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.26 ...................................................................... restapi: Update to model 4.0.26 The relevant changes in this version of the model are the following: * Removed the `disks` locator from the virtual machine service, as it has been replaced by `diskAttachments`. * Add the `host`, `destroy` and `format` parameters to the operation that removes a storage domain. Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/LinkHelperTest.java M pom.xml 4 files changed, 3 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Juan Hernandez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename add pool command
by ahadas＠redhat.com 05 Jul '16

05 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: rename add pool command ...................................................................... core: rename add pool command AddVmPoolWithVmsCommand -> AddVmPoolCommand Change-Id: Id21fe69aaaed1c4c9bd67f055e929958edc2cb85 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 11 files changed, 18 insertions(+), 18 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id21fe69aaaed1c4c9bd67f055e929958edc2cb85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rename update pool command
by ahadas＠redhat.com 05 Jul '16

05 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: rename update pool command ...................................................................... core: rename update pool command UpdateVmPoolWithVmsCommand -> UpdateVmPoolCommand Change-Id: I4f8d63dde45148a9e6f926d9751f7a76f725de30 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolCommand.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 8 files changed, 13 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f8d63dde45148a9e6f926d9751f7a76f725de30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix HE disk unassigned status
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix HE disk unassigned status ...................................................................... core: fix HE disk unassigned status Hosted engine disk status is unassigned although it is working correctly. fix : on hosted engine import VM - set the disk status to OK upgrade script : move all hosted engine disk images from unassigned status to OK when the VM is plugged. Change-Id: I0386843a7e23e89425c9bf5be075c1344c159eaf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1352462 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit 57f8b96) Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java A packaging/dbscripts/upgrade/03_06_2150_change_disk_status_to_ok.sql 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/60121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0386843a7e23e89425c9bf5be075c1344c159eaf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0