March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove redundant setTemplateId() calls
by Code Review 30 Mar '17

30 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Remove redundant setTemplateId() calls ...................................................................... core: Remove redundant setTemplateId() calls Removed redundant setTemplateId() calls in SealVmTemplateCommand, UpdateAllTemplateDisksCommand and UpdateAllTemplateDisksParameters, because they are already present in parent classes. Change-Id: Ic9bc9b8591cfdb3db917ca17138701986b438f8f Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SealVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateAllTemplateDisksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateAllTemplateDisksParameters.java 3 files changed, 1 insertion(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9bc9b8591cfdb3db917ca17138701986b438f8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Hosted-Engine PT_BR update
by Code Review 30 Mar '17

30 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Hosted-Engine PT_BR update ...................................................................... Hosted-Engine PT_BR update Change-Id: Icac28bfaa79330350c8f312b1d296a7f6f09f395 Signed-off-by: Wesley Morais de Oliveira <wesleymoraisdeoliveira18(a)gmail.com> --- M po/pt_BR.po 1 file changed, 261 insertions(+), 192 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac28bfaa79330350c8f312b1d296a7f6f09f395 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Wesley Morais de Oliveira <wesleymoraisdeoliveira18(a)gmail.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cdrom and scsi index collision
by Code Review 30 Mar '17

30 Mar '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: core: cdrom and scsi index collision ...................................................................... core: cdrom and scsi index collision Change-Id: I8900d3a4b9c21ca06f781ee50461bba9d26896e4 Bug-Url: https://bugzilla.redhat.com/1372516 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8900d3a4b9c21ca06f781ee50461bba9d26896e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Reset gluster uuid on reinstall
by Code Review 30 Mar '17

30 Mar '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: engine: Reset gluster uuid on reinstall ...................................................................... engine: Reset gluster uuid on reinstall If gluster UUID is detected as changed during a reinstall, update this in the database Bug-Url: https://bugzilla.redhat.com/1431529 Change-Id: If48f17a10fde6ccba98085c9d3568b3bb10f4369 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If48f17a10fde6ccba98085c9d3568b3bb10f4369 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <ramesh.mail2u(a)gmail.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: CreateImageVDSCommandParams - adding imageType to appendAttr...
by Code Review 30 Mar '17

30 Mar '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: CreateImageVDSCommandParams - adding imageType to appendAttributes() ...................................................................... CreateImageVDSCommandParams - adding imageType to appendAttributes() Change-Id: I1c1f30c1149ad761764d5e720b67caa9a9960c91 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateImageVDSCommandParameters.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c1f30c1149ad761764d5e720b67caa9a9960c91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: CopyImageGroup/CloneImageGroupVolumesStructure - volume format
by Code Review 30 Mar '17

30 Mar '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: CopyImageGroup/CloneImageGroupVolumesStructure - volume format ...................................................................... CopyImageGroup/CloneImageGroupVolumesStructure - volume format CopyImageGroupCommand generates a destination format for the target disk when performing a disk copy. This format is by the command when copying a disk with snapshot collapse by passing it to the CopyImage vdsm verb or when executing the CopyImageGroupWithData command (spdm flow). The CopyImageGroupWithData command used that format for creating a collapsed volume, but it passed it to CloneImageGroupVolumesStructure which is used when cloning the image structure without performing collapse. This patch changes CopyImageGroupWithData and CloneImageGroupVolumesStructure to not use the generated format when creating the target image without collapse, but use the original volume format. Change-Id: Ie70f847a069a80e3c8e5bc45223da51ef957ed30 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneImageGroupVolumesStructureCommandParameters.java 3 files changed, 3 insertions(+), 16 deletions(-) Approvals: Freddy Rolland: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie70f847a069a80e3c8e5bc45223da51ef957ed30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added python cache files to .gitignore
by Code Review 30 Mar '17

30 Mar '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Added python cache files to .gitignore ...................................................................... Added python cache files to .gitignore Also added the exported-artifacts directory Change-Id: I371a86355d3a1858d01d03bf63597631b99cd5e5 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M .gitignore 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I371a86355d3a1858d01d03bf63597631b99cd5e5 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in jenkins[master]: Added queue status graphical display
by Code Review 30 Mar '17

30 Mar '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Added queue status graphical display ...................................................................... Added queue status graphical display Change-Id: I8dd14dffb679cfb200e01c4d72eee7b6516c0e24 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077 --- M pipelines/change-queue.groovy M scripts/change_queue/__init__.py A scripts/change_queue/templates/queue-status.html.j2 3 files changed, 185 insertions(+), 2 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dd14dffb679cfb200e01c4d72eee7b6516c0e24 Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Set build names for queue jobs
by Code Review 30 Mar '17

30 Mar '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Set build names for queue jobs ...................................................................... Set build names for queue jobs Dynamically set build names on queue jobs to make is easier to know what they are doing. Change-Id: I9fdcfc8df2c4aae3b1e1d9d50b266c3292413650 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077 --- M jobs/confs/staging-projects/number-queue/number-queue.yaml M pipelines/change-queue.groovy M pipelines/numbers_change-queue-tester.groovy 3 files changed, 35 insertions(+), 2 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fdcfc8df2c4aae3b1e1d9d50b266c3292413650 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Creating POC change queue jobs in staging system
by Code Review 30 Mar '17

30 Mar '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Creating POC change queue jobs in staging system ...................................................................... Creating POC change queue jobs in staging system - Created a new 'projects' directory for the staging system - Created 'change creating', queue management and testing jobs - Created a generic pipeline-loader to allow putting most pipeline code out of JJB's reach - Added some more logging to the change queue library - Added some state cleanup code to prevent unneeded state from being preserved via dirty workspaces - Added some code to create dummy change objects for testing - Fixed bugs all over the place Change-Id: Ic91ca9aa39a6f9434cb316dff66da128cf868972 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077 --- A jobs/confs/groovy-scripts/pipeline-loader.groovy A jobs/confs/staging-projects/defaults.yaml A jobs/confs/staging-projects/number-queue/number-queue.yaml A pipelines/change-queue.groovy A pipelines/numbers_change-queue-tester.groovy M scripts/change_queue/__init__.py M scripts/change_queue/changes/__init__.py M test/test_change_queue.py 8 files changed, 457 insertions(+), 20 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic91ca9aa39a6f9434cb316dff66da128cf868972 Gerrit-PatchSet: 36 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0