June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: StorageModel Collections#singletonList usages
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel Collections#singletonList usages ...................................................................... webadmin: StorageModel Collections#singletonList usages Use the more efficient and more intuitive Collections#singletonList instead of the awkward Arrays#asList with a single argument. Change-Id: Ia90c027c69cfda7fe836ece925a6d5b43d0922d3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia90c027c69cfda7fe836ece925a6d5b43d0922d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel streams
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel streams ...................................................................... webadmin: StorageModel streams Change-Id: I42547fbae9880d70c2a78d4a1b7f8eae430a82c7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 22 insertions(+), 44 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42547fbae9880d70c2a78d4a1b7f8eae430a82c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel method references
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel method references ...................................................................... webadmin: StorageModel method references Change-Id: I51bcf7931a94c4a0ad66d8a7024ec55a977c2294 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51bcf7931a94c4a0ad66d8a7024ec55a977c2294 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageModel redundant static qualification
by Code Review 26 Jun '17

26 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageModel redundant static qualification ...................................................................... webadmin: StorageModel redundant static qualification Change-Id: I8feaf125026501e1af4849fa497e66031bfceb8a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8feaf125026501e1af4849fa497e66031bfceb8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Fix typo in EventType
by Code Review 26 Jun '17

26 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix typo in EventType ...................................................................... engine: Fix typo in EventType Change-Id: I6285bbb29430d60836acf273590c2ac33b18fb25 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6285bbb29430d60836acf273590c2ac33b18fb25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[refs/meta/config]: gerrit: Refine watched files
by Code Review 26 Jun '17

26 Jun '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: gerrit: Refine watched files ...................................................................... gerrit: Refine watched files The 'utils' and 'host' are too generic patterns and should be refined. Change-Id: I29f9b7ee8a82342da1013d964d58727e4d034b66 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M reviewers.config 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Shlomo Ben David: Looks good to me, approved; Passed CI tests Roy Golan: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/78339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29f9b7ee8a82342da1013d964d58727e4d034b66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: refs/meta/config Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shlomi Ben-David Gerrit-Reviewer: Shlomi Ben-David <shlomi.ben.david(a)gmail.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: build: post ovirt-hosted-engine-setup-2.1.3.2
by Code Review 26 Jun '17

26 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.1.3.2 ...................................................................... build: post ovirt-hosted-engine-setup-2.1.3.2 Change-Id: I9deddc1d3aa74aa1875681d37f4f7cf653307c4a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9deddc1d3aa74aa1875681d37f4f7cf653307c4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: build: ovirt-hosted-engine-setup-2.1.3.2
by Code Review 26 Jun '17

26 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.1.3.2 ...................................................................... build: ovirt-hosted-engine-setup-2.1.3.2 Change-Id: Ic327f928dcd4ca596d624960b437a477ab0ff49a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic327f928dcd4ca596d624960b437a477ab0ff49a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in jenkins[master]: publisher: restore publishing vdsm ppc64le 4.1 builds
by Code Review 26 Jun '17

26 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: publisher: restore publishing vdsm ppc64le 4.1 builds ...................................................................... publisher: restore publishing vdsm ppc64le 4.1 builds We don't have issues with multi arch anymore, Need to verify it works with OST 4.1 suite before merging. Change-Id: I4417f8c9f4e941e6a75053bcc0d5685eafbf980d Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4417f8c9f4e941e6a75053bcc0d5685eafbf980d Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Force mock to use 'chroot' in mock_runner.sh
by Code Review 26 Jun '17

26 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Force mock to use 'chroot' in mock_runner.sh ...................................................................... Force mock to use 'chroot' in mock_runner.sh The 'mock' default behaviour was changed in FC26 to use 'systemd-nspawn' instead of 'chroot'. This breaks various assumptions make in 'mock_runner.sh'. This patch makes 'mock_runner.sh' force 'mock' to use 'chroot'. Change-Id: Ie5d27e7ec17cade6484a83dbfe75565bf1948746 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1478 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Barak Korren: Verified; Ready for review Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d27e7ec17cade6484a83dbfe75565bf1948746 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0