October 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core:StorageDomainCommandBase.refreshAllVdssInPool

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core:StorageDomainCommandBase.refreshAllVdssInPool ...................................................................... core:StorageDomainCommandBase.refreshAllVdssInPool Moved the method refreshAllVdssInPool() from StorageDomainCommandBase to ActiveteStorageDomainCommand, which is currently the only place it is used (presumably, this is a leftover of some previous refactoring). In addition, removed the boolean parameter from the method, as it was not in use. Change-Id: I56f55bceee3c07826a3767e38554adf553ca2121 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 2 files changed, 24 insertions(+), 21 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56f55bceee3c07826a3767e38554adf553ca2121 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: StorageDomainCommandBase: suppress warnings

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: StorageDomainCommandBase: suppress warnings ...................................................................... core: StorageDomainCommandBase: suppress warnings Suppressed some warnings we knowingly aren't solving so they won't show up in IDEs and bother poor programmers. Change-Id: I7157fa9d05862155d413b87ecef29ece36b2d7cd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7157fa9d05862155d413b87ecef29ece36b2d7cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: StorageHandlingCommandBase static comperator

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBase static comperator ...................................................................... core: StorageHandlingCommandBase static comperator Created a static instance of the stateless LastTimeUsedAsMasterComp to avoid creating a useless new instance each time it's needed. Change-Id: I4509acc5f2ed8ec384ec562a4c73741214f1aeba Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4509acc5f2ed8ec384ec562a4c73741214f1aeba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: StorageDomainCommandBase cleanup - FQCNs

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: StorageDomainCommandBase cleanup - FQCNs ...................................................................... core: StorageDomainCommandBase cleanup - FQCNs Removed FQCNs and replaced with imports. Change-Id: Id66823bbebe315ee5b90457c2f124ba0c7187f5c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id66823bbebe315ee5b90457c2f124ba0c7187f5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: FB: StorageDomainCommandBase method names

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: FB: StorageDomainCommandBase method names ...................................................................... core: FB: StorageDomainCommandBase method names Fixed FindBugs NM_METHOD_NAMING_CONVENTION warnings regarding StorageDomainCommandBase's naming convention (i.e., not starting with a lowercase letter). Changes in other files are due to other classes using or overriding these methods. Change-Id: I730fdee95aceed27940f591f6f87c7c939457dce Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBaseTest.java 17 files changed, 41 insertions(+), 41 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730fdee95aceed27940f591f6f87c7c939457dce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine-sdk[master]: sdk: do not send /max header on name-based search

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: do not send /max header on name-based search ...................................................................... sdk: do not send /max header on name-based search Change-Id: I4285d18ceeb4f26816c200230eb78df1d93dae5a Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/collection.py M src/codegen/collection/collectionexceptions.py M src/ovirtsdk/infrastructure/brokers.py 3 files changed, 15 insertions(+), 15 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4285d18ceeb4f26816c200230eb78df1d93dae5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine-sdk[master]: sdk: Cannot fetch the disk using /alias #865407

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Cannot fetch the disk using /alias #865407 ...................................................................... sdk: Cannot fetch the disk using /alias #865407 problem caused by engine break of search-by-name paradigm renaming name to alias in both disk entity and search dialect. https://bugzilla.redhat.com/show_bug.cgi?id=865407 Change-Id: I2de5c7fcd8be7d2800a07b56b6171434bfa9be97 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/collection.py A src/codegen/collection/collectionexceptions.py M src/ovirtsdk/infrastructure/brokers.py 3 files changed, 97 insertions(+), 31 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2de5c7fcd8be7d2800a07b56b6171434bfa9be97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fixing checkstyle issue at QuotaManagerTest

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing checkstyle issue at QuotaManagerTest ...................................................................... core: Fixing checkstyle issue at QuotaManagerTest Change-id: I94f3c474c0209a9049d1d32487d049e1e161215a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f3c474c0209a9049d1d32487d049e1e161215a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: #854479 Attach Disk To VM - Return Disk In Response

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: #854479 Attach Disk To VM - Return Disk In Response ...................................................................... restapi: #854479 Attach Disk To VM - Return Disk In Response Change-Id: I1a50077886734f73842141262f5c338979dcae5c Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a50077886734f73842141262f5c338979dcae5c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: adapt to sdk restriction of .get() to id/name

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: adapt to sdk restriction of .get() to id/name ...................................................................... cli: adapt to sdk restriction of .get() to id/name latest sdk restricts .get() to id/name, **kwargs no longer supported. Change-Id: I6d26ed70154300793b8ea11af5b424148ca306b3 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/command.py M src/ovirtcli/shell/showcmdshell.py 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d26ed70154300793b8ea11af5b424148ca306b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2012