October 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: restapi: Size Missing From Add Vm-Pool Metadata

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: restapi: Size Missing From Add Vm-Pool Metadata ...................................................................... restapi: Size Missing From Add Vm-Pool Metadata Change-Id: I8868a895c8aca6fbf361cfdf1f09666d53024926 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8868a895c8aca6fbf361cfdf1f09666d53024926 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Get Capabilities in JSON Format fails

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: restapi: Get Capabilities in JSON Format fails ...................................................................... restapi: Get Capabilities in JSON Format fails Change-Id: I30a38ef6d247de993cc56492efeded058cf07eed Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30a38ef6d247de993cc56492efeded058cf07eed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Fix 500 response to bad RSDL url

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix 500 response to bad RSDL url ...................................................................... restapi: Fix 500 response to bad RSDL url Change-Id: Id2a9c1cdcb383002128f2e42e67e265f02f869bc Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a9c1cdcb383002128f2e42e67e265f02f869bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Schema API element - add min/max occurences

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: restapi: Schema API element - add min/max occurences ...................................................................... restapi: Schema API element - add min/max occurences Change-Id: I1208d0ba3355fbde74cd43cac4fd444058943f1a Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1208d0ba3355fbde74cd43cac4fd444058943f1a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Create LUN-Disk - empty response body

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: restapi: Create LUN-Disk - empty response body ...................................................................... restapi: Create LUN-Disk - empty response body Change-Id: I23c6b18b8f7276cfb69b85860bd994298410e303 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23c6b18b8f7276cfb69b85860bd994298410e303 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Run Once dialog ingores emtpy boot options (#857848)

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Run Once dialog ingores emtpy boot options (#857848) ...................................................................... engine: Run Once dialog ingores emtpy boot options (#857848) https://bugzilla.redhat.com/857848 When you set the linux boot options in Edit dialog, than in Run Once dialog remove this options, the run once will use the boot options set up in the Edit dialog. The problem was in RunVmCommand.refreshBootParameters method which expected, that when the parameter is empty, it is run VM, when it is not empty, it is run once VM, which is not true in this case. Fixed by moving the run once specific code to the RunVmOnceCommand. This patch contains also the following refactorings: - the refreshBootSequenceParameter inlined to the refreshBootParameters - setLastStartTime removed from the refreshBootSequenceParameter and moved to places where the refreshBootSequenceParameter has been called Change-Id: I32e59783d9c4d8e8b61ec96c6bae5577fc59756c Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 2 files changed, 29 insertions(+), 31 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32e59783d9c4d8e8b61ec96c6bae5577fc59756c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Include 'unattached' domains in domains for search vie...

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Include 'unattached' domains in domains for search view ...................................................................... core: Include 'unattached' domains in domains for search view Join unattached domains in the 'storage_domains_for_search' view, In case domain is unattached (has no status), set status to 2 (unattached, see StorageDomainStatus). Change-Id: I3faa0d0504520513ce0c565b2476779d0362edfb Bug-Url: https://bugzilla.redhat.com/852100 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3faa0d0504520513ce0c565b2476779d0362edfb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fixed error msg when adding a VM disk in diff pool.

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Fixed error msg when adding a VM disk in diff pool. ...................................................................... core: Fixed error msg when adding a VM disk in diff pool. When creating a new disk for a VM, specifying a different pool causes the following error message: "Cannot add Virtual Machine Disk. The target Data Center does not contain the Virtual Machine Disk" Obviously the disk does not exist yet. This patch changes the message to: "Cannot add Virtual Machine Disk. The target Data Center does not contain the Virtual Machine" Change-Id: I1740658f448d5281b6b406346ae41487f48915ba Bug-Url: https://bugzilla.redhat.com/845975 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1740658f448d5281b6b406346ae41487f48915ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: fix possible null exception in BooleanRenderer

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix possible null exception in BooleanRenderer ...................................................................... webadmin: fix possible null exception in BooleanRenderer Probelm: * there was a possibility of a null pointer excetion in BooleanRenderer Solution: * check for null and return an empty string Change-Id: I7915668091a11f1033b4ae37a20e8b1763d4f52e Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/BooleanRenderer.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7915668091a11f1033b4ae37a20e8b1763d4f52e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

12 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Snapshots sub-tab - Disks tab modifications

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Snapshots sub-tab - Disks tab modifications ...................................................................... webadmin: Snapshots sub-tab - Disks tab modifications * Renamed 'Name' column to 'Alias'. * Added 'Description' column. * Tweaked columns width. Change-Id: I664907d67a7cb9fd23fc332a18930737f9030a10 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I664907d67a7cb9fd23fc332a18930737f9030a10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

12 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2012