October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Start Gluster Volume Profile command
by ofrenkel＠redhat.com 30 Oct '12

30 Oct '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Start Gluster Volume Profile command ...................................................................... engine: Start Gluster Volume Profile command Includes following related to the command for "gluster volume profile start" - New Bll Command - New Vds Command - Audit Log Messages and Severities - App Errors - VDSM Errors - Junit test class Change-Id: Ia47f7033f080f75a6ebf8481ea4199ee32bbf4ab Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeProfileCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeProfileCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeProfileVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 22 files changed, 194 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/8261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia47f7033f080f75a6ebf8481ea4199ee32bbf4ab Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Dead store to tempVar in GetTagsByUserIdQuery.executeQ...
by masayag＠redhat.com 30 Oct '12

30 Oct '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Dead store to tempVar in GetTagsByUserIdQuery.executeQueryCommand() ...................................................................... core: Dead store to tempVar in GetTagsByUserIdQuery.executeQueryCommand() Fix findbugs issue - GetTagsByUserIdQuery.java:14, DLS_DEAD_LOCAL_STORE, Priority: Low Dead store to tempVar in org.ovirt.engine.core.bll.GetTagsByUserIdQuery.executeQueryCommand() This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add marks for key-value in sysprep handler log (#87010...
by ofrenkel＠redhat.com 30 Oct '12

30 Oct '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: add marks for key-value in sysprep handler log (#870100) ...................................................................... core: add marks for key-value in sysprep handler log (#870100) Added marks ('') for key and value in the log, to make the message more clear. also changed level to warn as flow continues with defaults. Bug-Url:https://bugzilla.redhat.com/870100 Change-Id: I3b0e4076e983a0d2bac60c4eaade5c84284c44d0 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b0e4076e983a0d2bac60c4eaade5c84284c44d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix localization issue in edit quota
by gchaplik＠redhat.com 30 Oct '12

30 Oct '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix localization issue in edit quota ...................................................................... webadmin: Fix localization issue in edit quota Edit Quota popup view had some hard coded strings which are imposible to localize to some languages. The string origin in the ApplicationConstants so they could not be formated. The issue was also relevant to SubTabQuotaClusterView and SubTabQuotaStorageView and was fix in those classes as well. New formated strings added to ApplicationMessages and the hard coded part was replaced with a message formating. This fix also handles a second localization issue in the EditQuotaClusterPopupView. The "vCpus" label was moved from EditQuotaClusterPopupView.ui.xml to ApplicationConstants to allow localization. Change-Id: I73146871d6ca7a8f91a190816df2c2dc684d9f5e Bug-Url: https://bugzilla.redhat.com/871042 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java 6 files changed, 66 insertions(+), 45 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73146871d6ca7a8f91a190816df2c2dc684d9f5e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Language selection misrendered on windows XP clien...
by oourfali＠redhat.com 30 Oct '12

30 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Language selection misrendered on windows XP client with IE8 ...................................................................... webadmin: Language selection misrendered on windows XP client with IE8 Bug-Id: https://bugzilla.redhat.com/866911 Change-Id: I267f6a9a5327dc0d783d671b5b833ba1de8eff46 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I267f6a9a5327dc0d783d671b5b833ba1de8eff46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: User Portal - auto-connect selected only works once ...
by tjelinek＠redhat.com 30 Oct '12

30 Oct '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: User Portal - auto-connect selected only works once per browser session ...................................................................... engine: User Portal - auto-connect selected only works once per browser session 1. Go to the user portal, where the user only has one VM that is up, have the Connect Automatically checkbox selected, and login. 2. Logout and repeat. The console doesn't pop up. The problem was caused by the alreadyOpened property of the ConnectAutomaticallyManager, which is set to true after the console is brought up for the first time. This value is not reset after the user logs out. Fixed by resetting the value on user's logout. Change-Id: If59f9874d1804e17788f8ef0dc82e4e786f55870 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=867134 --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If59f9874d1804e17788f8ef0dc82e4e786f55870 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Layout: fit Pools general sub-tab for JP locale
by oourfali＠redhat.com 30 Oct '12

30 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Layout: fit Pools general sub-tab for JP locale ...................................................................... webadmin: Layout: fit Pools general sub-tab for JP locale Change-Id: I84e02879fd65e47eba92223df0bd93237244e787 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=870270 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84e02879fd65e47eba92223df0bd93237244e787 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Layout: fit Manage-Events for JP Locale
by oourfali＠redhat.com 30 Oct '12

30 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Layout: fit Manage-Events for JP Locale ...................................................................... webadmin: Layout: fit Manage-Events for JP Locale Change-Id: I82d22a02149750a92fe1fa0c92d15153a9ff9526 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=870286 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82d22a02149750a92fe1fa0c92d15153a9ff9526 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Layout - make template dialog overlap with JP loca...
by oourfali＠redhat.com 30 Oct '12

30 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Layout - make template dialog overlap with JP locale ...................................................................... webadmin: Layout - make template dialog overlap with JP locale Change-Id: Ie9cbdb4025a5c1177d864f0d8aaa502979ffde61 Bug-Id: https://bugzilla.redhat.com/870161 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9cbdb4025a5c1177d864f0d8aaa502979ffde61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadin: layout: fix english new/edit pool layout
by oourfali＠redhat.com 29 Oct '12

29 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadin: layout: fix english new/edit pool layout ...................................................................... webadin: layout: fix english new/edit pool layout revert patch 8a0c9f4b0d8b753a80a9c38ff04680c78db83b0c Change-Id: Ica0201c1576515a696b30a278de46b5cc442004c Bug-Id: https://bugzilla.redhat.com/870251 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica0201c1576515a696b30a278de46b5cc442004c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0