October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: RFE: add smartcard support
by tjelinek＠redhat.com 29 Oct '12

29 Oct '12

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: RFE: add smartcard support ...................................................................... restapi: RFE: add smartcard support Added boolean flag "smartcard_enabled" to VM and template Change-Id: Ibddf2c606e80cd951fc5d82bc0413d96610f451a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 6 files changed, 19 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibddf2c606e80cd951fc5d82bc0413d96610f451a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Integrate smartcard support
by tjelinek＠redhat.com 29 Oct '12

29 Oct '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Integrate smartcard support ...................................................................... engine: Integrate smartcard support This patch integrates the smartcard support into the frontend and engine. The behavior on frontend: - the new/edit VM, pool, template dialogs contains in console side tab a new checkbox with label "Smartcard enabled" - this checkbox is enabled only for the Spice client, it is visible but disabled for VNC. - if the smartcard is enabled and gui is going to connect to the guest using spice, it sets the "Smartcard" option on the XPI client to true, else sets it to false (ignores this for the activex client because the activex client does not support the smartcard yet) - in (Power)UserPortal in Console Options popup the user can disable the smartcard even it is enabled for that VM (but can not enable when it is disabled) - in (not Power)UserPortal the VM detail part contains a notification when the smartcard is enabled: "Spice with Smartcard" is shown next to the "(Edit)" on the "Console" part. The behavior on the backend: - if the smartcard is enabled or not is persisted in the vm_static table under the boolean field "is_smartcard_enabled" - VmInfoBuilderBase adds a new parameter to VDSM: smartcardEnable ("true" if yes, "false" if no) - the export adds a new parameter "IsSmartcardEnabled" into the ovf This patch does not contain the support for REST - it will come in a different patch. Change-Id: Icaa874d6316c4040253231a7a301a17d8b69eb4b Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1470_add_smartcard.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/ConsoleUtils.java 47 files changed, 426 insertions(+), 303 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaa874d6316c4040253231a7a301a17d8b69eb4b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Type Safety GetVmTemplatesByNetworkIdQuery
by msalem＠redhat.com 29 Oct '12

29 Oct '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Type Safety GetVmTemplatesByNetworkIdQuery ...................................................................... engine: Type Safety GetVmTemplatesByNetworkIdQuery This patch adds type safety for GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery Change-Id: I9091beaee941815970e17902be7b12e0562e3ead Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9091beaee941815970e17902be7b12e0562e3ead Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed date display on br13 (#870720)
by ydary＠redhat.com 29 Oct '12

29 Oct '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed date display on br13 (#870720) ...................................................................... reports: fixed date display on br13 (#870720) Had missing field in date display that caused error. Changed query to contain the field required. bug-url: https://bugzilla.redhat.com/870720 Change-Id: Ia43c746403972bd6c461ab435955dead725595d4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/full details.jrxml.data 1 file changed, 33 insertions(+), 34 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia43c746403972bd6c461ab435955dead725595d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Enable addDisk with a locked disk (#870754)
by derez＠redhat.com 29 Oct '12

29 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Enable addDisk with a locked disk (#870754) ...................................................................... core: Enable addDisk with a locked disk (#870754) In AddDiskCommand - check only if the VM is locked and not any of its disks. This Fixes a regression entered in https://bugzilla.redhat.com/show_bug.cgi?id=865551 in patch http://gerrit.ovirt.org/#/c/8666/ . The original bug fixed an error message using a different flow than the original one. The new flow remains and a parameter to ImagesHandler.PerformImagesChecks() was altered. Change-Id: Ifb3714b8aa301fd12a2837e00d899b09cc0001f6 Bug-Url: https://bugzilla.redhat.com/870754 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb3714b8aa301fd12a2837e00d899b09cc0001f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: attach disk does not show the disk description [ch...
by alkaplan＠redhat.com 29 Oct '12

29 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: attach disk does not show the disk description [chrome only] (#834341) ...................................................................... webadmin: attach disk does not show the disk description [chrome only] (#834341) Not all columns were visible for the tables that display internal or external disks to be attached to VM. The reason was that the wrapper panel of the tables wasn't set to 100% width, so it was packed assuming that columns with no explicitly set width, have width=0. The solution is to change the width of the wrapper panel to 100%. The width of the "Actual Size" column was also changed to be fixed as the width of the "Virtual Size" column. Change-Id: I440503f71a4279108ee04b98b8932adb92ce280c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=834341 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I440503f71a4279108ee04b98b8932adb92ce280c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Handling active tasks during upgrade
by juan.hernandez＠redhat.com 29 Oct '12

29 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Handling active tasks during upgrade ...................................................................... packaging: Handling active tasks during upgrade Added a function call that checks that there are no running tasks nor compensations. If there are such tasks, we first try to stop them, and if there are still tasks after a certain timeout, we stop the upgrade and recommend clearing the tasks before they continue. This patch also adds functions that are used to configure the engine in maintenance mode during upgrades. (cherry picked from commit e37d4932fc47773c4a0a55dc4cad378f819f1770) Change-Id: I90abb3d1e6ad0ac5557485e40064e811fc87f491 Signed-off-by: Alex Lourie <alourie(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile A packaging/fedora/setup/add_fn_db_get_async_tasks_function.sql M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/output_messages.py M packaging/fedora/spec/ovirt-engine.spec.in 7 files changed, 293 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90abb3d1e6ad0ac5557485e40064e811fc87f491 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Add /etc/sysconfig/ovirt-engine.d
by juan.hernandez＠redhat.com 29 Oct '12

29 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add /etc/sysconfig/ovirt-engine.d ...................................................................... packaging: Add /etc/sysconfig/ovirt-engine.d This is an optional directory where additional configuration files (anything ending in .conf) can be placed. The engine will load them after the defaults and the main configuration file, so they can override the default configuration. Change-Id: I8742b8e056d1122ee4350eccb77bcba0b0d0657b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java M packaging/fedora/engine-service.py M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in 5 files changed, 94 insertions(+), 49 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8742b8e056d1122ee4350eccb77bcba0b0d0657b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: rephrase power off virtual machines dialog
by shavivi＠redhat.com 29 Oct '12

29 Oct '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: rephrase power off virtual machines dialog ...................................................................... webadmin: rephrase power off virtual machines dialog Change-Id: Ia4f458dd2d5655764c26101426a36f7b640a46ce Bug-id: https://bugzilla.redhat.com/869634 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f458dd2d5655764c26101426a36f7b640a46ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: missing enum translation
by gchaplik＠redhat.com 29 Oct '12

29 Oct '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: missing enum translation ...................................................................... webadmin: missing enum translation StoragePoolStatus___Contend = Contending Bug-Url: https://bugzilla.redhat.com/870939 Change-Id: If3e819899b49cdddcc1614cd683041e94970413d Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3e819899b49cdddcc1614cd683041e94970413d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0