Change in ovirt-engine[master]: webadmin: Layoout - fit VM and Template new/edit dialog to J...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Layoout - fit VM and Template new/edit dialog to JP locale
......................................................................
webadmin: Layoout - fit VM and Template new/edit dialog to JP locale
Change-Id: Ibc40466b61d3db300d84db8d3733a1d85af9eec9
Bug-id: https://bugzilla.redhat.com/870263
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateInterfacePopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmInterfacePopupView.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8861
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc40466b61d3db300d84db8d3733a1d85af9eec9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: engine: Type Safety for Network Queries
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Type Safety for Network Queries
......................................................................
engine: Type Safety for Network Queries
This patch adds type safety for:
GetVdsAndNetworkInterfacesByNetworkIdQuery
GetVmsAndNetworkInterfacesByNetworkIdQuery
Change-Id: I61fcd6c97cfbfe1cd90fe1377f8d7b3f2532f096
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsAndNetworkInterfacesByNetworkIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQuery.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61fcd6c97cfbfe1cd90fe1377f8d7b3f2532f096
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Adding UnitTest in VmNetworkInterfaceDao
by msalem@redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Adding UnitTest in VmNetworkInterfaceDao
......................................................................
core: Adding UnitTest in VmNetworkInterfaceDao
This patch adds a test for the new getAllForNetwork
method.
Change-Id: I3201bb0734f08d8e41e584fd45589e73867b281d
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8710
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3201bb0734f08d8e41e584fd45589e73867b281d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Adding Unit Test for GetVdsInterfacesByNetworkId
by msalem@redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Adding Unit Test for GetVdsInterfacesByNetworkId
......................................................................
core: Adding Unit Test for GetVdsInterfacesByNetworkId
Please refer to subject.
Change-Id: I9a8d47482288e8c9844313e5af4724afe7814d19
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a8d47482288e8c9844313e5af4724afe7814d19
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Adding getVdsInterfaceById
by msalem@redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Adding getVdsInterfaceById
......................................................................
core: Adding getVdsInterfaceById
This patch adds the above stored procedure to provide
data for the Vds subtab in the Network Main tab.
Change-Id: Ib993da030c145e25ec6b6b3f3d607dbd3d3774f1
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/dbscripts/network_sp.sql
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java
5 files changed, 54 insertions(+), 5 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib993da030c145e25ec6b6b3f3d607dbd3d3774f1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Vm Templates By Network Query
by msalem@redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Vm Templates By Network Query
......................................................................
core: Vm Templates By Network Query
This patch adds the GetVmTemplatesAndNetworkInterfacesByNetworkId
query as part of the Network Main Tab feature.
Change-Id: Ifc4ac77abf598b6e1fff1fa4318b39c9f3af5453
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/dbscripts/network_sp.sql
M backend/manager/dbscripts/vm_templates_sp.sql
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmTemplatesAndNetworkInterfacesByNetworkIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDAOTest.java
12 files changed, 214 insertions(+), 7 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc4ac77abf598b6e1fff1fa4318b39c9f3af5453
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: increment LiveStorageMigrationEnabled enum value
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: increment LiveStorageMigrationEnabled enum value
......................................................................
core: increment LiveStorageMigrationEnabled enum value
Incrementing LiveStorageMigrationEnabled enum value
to ensure uniqueness.
Change-Id: I168d4b97ceb19ae08a792e6eae46ec48207e4b4e
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8859
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I168d4b97ceb19ae08a792e6eae46ec48207e4b4e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: disable LiveStorageMigration on 3.1
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: disable LiveStorageMigration on 3.1
......................................................................
core: disable LiveStorageMigration on 3.1
'LiveStorageMigrationEnabled' configuration value
should be 'false' for 3.1.
Change-Id: Iafa6677910432ef076d9b1390434be8a8c52a5a9
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafa6677910432ef076d9b1390434be8a8c52a5a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: engine: Change vlan-id type to Integer
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Change vlan-id type to Integer
......................................................................
engine: Change vlan-id type to Integer
Modify the vlan-id type in the search-engine
to Integer so proper operators could be set to it.
Change-Id: I9a4175c615877728e4c13f6c5f4fb64a8adcb690
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a4175c615877728e4c13f6c5f4fb64a8adcb690
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: adding unlock_entity.sh script(#868638)
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: adding unlock_entity.sh script(#868638)
......................................................................
core: adding unlock_entity.sh script(#868638)
This patch adds a script to unlock disk objects in the db.
The script has 2 modes
1. unlock a VM/Template
2. unlock a VM/Template and all its associated disks (using the -r
flag)
3. unlock a specific disk
Only plugged disks are considered as candidates of this command.
The new script can be invoked basically by
unlock_entity.sh -t TYPE -i ID
where
TYPE is either "vm" or "template" or "disk"
ID is the entity name in case of VM/Tempalte, UUID is case of
a disk.
In order to display locked entities use:
unlock_entity.sh -t TYPE -q
The script supports all regular DB parameters as USER DATABASE
etc. including the option to run the script remotely.
The user is prompted to confirm that this is a dangerous operation and
he should contact GSS prior to this operation.
The operation is logged as an Alert in the audit_log with all relevant
details.
Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Bug-Url:https://bugzilla.redhat.com/868638
---
M backend/manager/dbscripts/common_sp.sql
M backend/manager/dbscripts/dbfunctions.sh
A backend/manager/dbscripts/unlock_entity.sh
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
4 files changed, 215 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months