November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Enhanced logging of HA VM failure recovery
by dfediuck＠redhat.com 25 Nov '12

25 Nov '12

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Enhanced logging of HA VM failure recovery ...................................................................... engine: Enhanced logging of HA VM failure recovery Added additional entry in the engine's log when a highly available VM fails and is restarted Change-Id: Iea83a09b824dcd391cd42b030fccc52ebc82c436 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea83a09b824dcd391cd42b030fccc52ebc82c436 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: use 'Engine' for username if fencing operation is done...
by emesika＠redhat.com 25 Nov '12

25 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: use 'Engine' for username if fencing operation is done internally ...................................................................... core: use 'Engine' for username if fencing operation is done internally If fencing is initiated internally (i.e - VdsManager -> NonResponsiveTreatment) Events will contain message with a string of <Unknown> instead we should indicate the operation (i.e - host was started) was carried out by the engine. Bug-Url: https://bugzilla.redhat.com/862797 Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae3ce Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae3ce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MockEJBStrategyRule
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: MockEJBStrategyRule ...................................................................... core: MockEJBStrategyRule Introducing MockEJBStrategyRule to provide an easy and straight forward way to mock EJBs and resources in bll tests. This patch includes the new @Rule and refactors all the tests with proprietary solutions for such mocking to use the new, standard way. Change-Id: Ib0ae1b2c56f2b189729883bf34da9a295a8ae9d6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExecuteTransactionAnswer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lock/InMemoryLockManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockEJBStrategyRule.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 10 files changed, 123 insertions(+), 173 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ae1b2c56f2b189729883bf34da9a295a8ae9d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove itests
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove itests ...................................................................... core: remove itests itest are an old testing effort that use an embedded JBoss 5.1 instance to run bll tests. Since the upgrade to JBoss 7.1.1, these tests no longer work and are no longer supported, so they are in effect "dead code". This patch removes those tests, the resources associated with them and several non-test classes that are not used in the production code, but were only used within the itests. Change-Id: I28cdcae73619f3c94912811d4855cfb869c3c3ff Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/README.itests M backend/manager/modules/bll/pom.xml D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/AbstractBackendTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BackendTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ClientHandshakeSequenceTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/PermissionTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/QueriesTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/RepoIsoFileTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/RoleActionGroupsTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/SearchTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/UserTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/VMTemplateTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/VdsGroupTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/VdsTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADGroupAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADGroupDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADPersonAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADPersonContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADPersonDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADRootDSEContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ContextSourceFactory.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/Group.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/GroupDao.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAGroupAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAGroupContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAGroupDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAPersonAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAPersonContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAPersonDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPARootDSEContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTester.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTestsSetup.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/Person.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/PersonDao.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/TransactionSupportTest.java D backend/manager/modules/bll/src/test/postgres-resources/postgres-ds.xml D backend/manager/modules/bll/src/test/resources/META-INF/ejb-jar.xml D backend/manager/modules/bll/src/test/resources/META-INF/persistence.properties D backend/manager/modules/bll/src/test/resources/conf/bootstrap-beans.xml D backend/manager/modules/bll/src/test/resources/conf/jboss-service.xml D backend/manager/modules/bll/src/test/resources/conf/jbossjta-properties.xml D backend/manager/modules/bll/src/test/resources/conf/login-config.xml D backend/manager/modules/bll/src/test/resources/conf/props/messaging-roles.properties D backend/manager/modules/bll/src/test/resources/conf/props/messaging-users.properties D backend/manager/modules/bll/src/test/resources/deploy/ejb3-interceptors-aop.xml D backend/manager/modules/bll/src/test/resources/deploy/hsqldb-ds.xml D backend/manager/modules/bll/src/test/resources/deploy/jboss-local-jdbc.rar/META-INF/ra.xml D backend/manager/modules/bll/src/test/resources/deploy/jboss-xa-jdbc.rar D backend/manager/modules/bll/src/test/resources/deploy/jms-ra.rar D backend/manager/modules/bll/src/test/resources/deploy/messaging/connection-factories-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/destinations-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/hsqldb-persistence-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/jms-ds.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/legacy-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/messaging-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/remoting-service.xml D backend/manager/modules/bll/src/test/resources/deploy/remoting-service.xml D backend/manager/modules/bll/src/test/resources/deployers/aspect-deployer-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/ejb-deployer-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/ejb3-deployers-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/jboss-aspect-library-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/jca-deployers-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/metadata-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/security-deployer-beans.xml D backend/manager/modules/bll/src/test/resources/jndi.properties D backend/manager/modules/bll/src/test/resources/ldap.integ/ldap-test.properties.sample D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/JBossEmbeddedEJBUtilsStrategy.java 68 files changed, 0 insertions(+), 7,407 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/9439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28cdcae73619f3c94912811d4855cfb869c3c3ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix a typo in dbscripts
by emesika＠redhat.com 25 Nov '12

25 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix a typo in dbscripts ...................................................................... core: Fix a typo in dbscripts There is an small typo in the engine-db-isntall.sh script, it puts line breaks in the middle of the descriptions of two options. Change-Id: I7d8b45da7dec35e21675eaae464cd2f8e2520b6f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/engine-db-install.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d8b45da7dec35e21675eaae464cd2f8e2520b6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Use configuration to generate paths
by juan.hernandez＠redhat.com 22 Nov '12

22 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Use configuration to generate paths ...................................................................... packaging: Use configuration to generate paths The service start/stop script still had some paths hardcoded, ignoring the values of the ENGINE_* settings in /etc/ovirt-engine/engine.conf.defaults and /etc/sysconfig/ovir-engine files. This affected mostly the location of the log files. This patch fixes that. Change-Id: I0c4aa730c7b58983f27c6e2f02701a34911f41ee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/conf/engine.conf.defaults R packaging/fedora/engine-service-logging.properties.in M packaging/fedora/engine-service.py M packaging/fedora/engine-service.xml.in 5 files changed, 37 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c4aa730c7b58983f27c6e2f02701a34911f41ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Gluster Peer Detach bll command
by ofrenkel＠redhat.com 22 Nov '12

22 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Gluster Peer Detach bll command ...................................................................... engine: Gluster Peer Detach bll command Includes following related to the command for "gluster peer detach" - New Bll Command - Audit Log Messages and Severities - App Errors - VDSM Errors - Junit test class - Execution Messages Changed existing "Host" to "Server" in Remove Gluster Server related sources Change-Id: I171f1b6eb9d01f1ffb2b4a0be52a15887f534c2d Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterServerCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterServerCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/RemoveGlusterServerParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHostRemoveVDSParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostRemoveVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/RemoveGlusterServerVDSCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 23 files changed, 247 insertions(+), 68 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/9044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I171f1b6eb9d01f1ffb2b4a0be52a15887f534c2d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: replace VdsInstallerSSH: with the SSHDialog
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog ...................................................................... gluster: replace VdsInstallerSSH: with the SSHDialog VdsInstallerSSH is going to retire. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQueryTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 6 files changed, 71 insertions(+), 94 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirt...
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade ...................................................................... bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade Currently we have 4 separate bootstrap methods: 1. Host. 2. Node registration. 3. Node installation. 4. Node upgrade. While there is something common between (1-3), node upgrade is totally different sequence: 1. Unlike bootstrap it is executing foreign code (not originated at engine machine. 2. Unlike bootstrap it is non-customizable. Current implementation shares the same VdsInstaller base class among bootstrap and node upgrade, as these are totally different, we detach the OVirtUpgrader from VdsInstaller. VdsInstaller is soon to be retired. Rename OVirtUpgrader to OVirtNodeUpgrade as it handles only ovirt-node. This change also introduces the SSHDialog class, which is a class that can be used to conduct a text dialog with a component at the other end of the ssh session. It is a key component in the future vdsm-bootstrap rewrite. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875529 Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtUpgrader.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java 8 files changed, 1,249 insertions(+), 110 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Adding null check for VDS in NewGlusterServersQuery
by ofrenkel＠redhat.com 22 Nov '12

22 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Adding null check for VDS in NewGlusterServersQuery ...................................................................... engine: Adding null check for VDS in NewGlusterServersQuery In case of an empty cluster we will not get any VDS to execute the command. So a null check is added before executing the corresponding command. Change-Id: I839589d239a3dec771fc9aad7a0ef8f8e1a195fe Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I839589d239a3dec771fc9aad7a0ef8f8e1a195fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0