November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Enhanced logging of HA VM failure recovery
by dfediuck＠redhat.com 25 Nov '12

25 Nov '12

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Enhanced logging of HA VM failure recovery ...................................................................... engine: Enhanced logging of HA VM failure recovery Added additional entry in the engine's log when a highly available VM fails and is restarted Change-Id: Iea83a09b824dcd391cd42b030fccc52ebc82c436 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea83a09b824dcd391cd42b030fccc52ebc82c436 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: use 'Engine' for username if fencing operation is done...
by emesika＠redhat.com 25 Nov '12

25 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: use 'Engine' for username if fencing operation is done internally ...................................................................... core: use 'Engine' for username if fencing operation is done internally If fencing is initiated internally (i.e - VdsManager -> NonResponsiveTreatment) Events will contain message with a string of <Unknown> instead we should indicate the operation (i.e - host was started) was carried out by the engine. Bug-Url: https://bugzilla.redhat.com/862797 Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae3ce Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae3ce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MockEJBStrategyRule
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: MockEJBStrategyRule ...................................................................... core: MockEJBStrategyRule Introducing MockEJBStrategyRule to provide an easy and straight forward way to mock EJBs and resources in bll tests. This patch includes the new @Rule and refactors all the tests with proprietary solutions for such mocking to use the new, standard way. Change-Id: Ib0ae1b2c56f2b189729883bf34da9a295a8ae9d6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExecuteTransactionAnswer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lock/InMemoryLockManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockEJBStrategyRule.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 10 files changed, 123 insertions(+), 173 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ae1b2c56f2b189729883bf34da9a295a8ae9d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove itests
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove itests ...................................................................... core: remove itests itest are an old testing effort that use an embedded JBoss 5.1 instance to run bll tests. Since the upgrade to JBoss 7.1.1, these tests no longer work and are no longer supported, so they are in effect "dead code". This patch removes those tests, the resources associated with them and several non-test classes that are not used in the production code, but were only used within the itests. Change-Id: I28cdcae73619f3c94912811d4855cfb869c3c3ff Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/README.itests M backend/manager/modules/bll/pom.xml D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/AbstractBackendTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BackendTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ClientHandshakeSequenceTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/PermissionTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/QueriesTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/RepoIsoFileTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/RoleActionGroupsTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/SearchTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/UserTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/VMTemplateTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/VdsGroupTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/VdsTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADGroupAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADGroupDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADPersonAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADPersonContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADPersonDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ADRootDSEContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/ContextSourceFactory.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/Group.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/GroupDao.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAGroupAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAGroupContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAGroupDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAPersonAttributes.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAPersonContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPAPersonDaoImpl.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/IPARootDSEContextMapper.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTester.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTestsSetup.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/Person.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/PersonDao.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/TransactionSupportTest.java D backend/manager/modules/bll/src/test/postgres-resources/postgres-ds.xml D backend/manager/modules/bll/src/test/resources/META-INF/ejb-jar.xml D backend/manager/modules/bll/src/test/resources/META-INF/persistence.properties D backend/manager/modules/bll/src/test/resources/conf/bootstrap-beans.xml D backend/manager/modules/bll/src/test/resources/conf/jboss-service.xml D backend/manager/modules/bll/src/test/resources/conf/jbossjta-properties.xml D backend/manager/modules/bll/src/test/resources/conf/login-config.xml D backend/manager/modules/bll/src/test/resources/conf/props/messaging-roles.properties D backend/manager/modules/bll/src/test/resources/conf/props/messaging-users.properties D backend/manager/modules/bll/src/test/resources/deploy/ejb3-interceptors-aop.xml D backend/manager/modules/bll/src/test/resources/deploy/hsqldb-ds.xml D backend/manager/modules/bll/src/test/resources/deploy/jboss-local-jdbc.rar/META-INF/ra.xml D backend/manager/modules/bll/src/test/resources/deploy/jboss-xa-jdbc.rar D backend/manager/modules/bll/src/test/resources/deploy/jms-ra.rar D backend/manager/modules/bll/src/test/resources/deploy/messaging/connection-factories-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/destinations-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/hsqldb-persistence-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/jms-ds.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/legacy-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/messaging-service.xml D backend/manager/modules/bll/src/test/resources/deploy/messaging/remoting-service.xml D backend/manager/modules/bll/src/test/resources/deploy/remoting-service.xml D backend/manager/modules/bll/src/test/resources/deployers/aspect-deployer-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/ejb-deployer-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/ejb3-deployers-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/jboss-aspect-library-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/jca-deployers-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/metadata-beans.xml D backend/manager/modules/bll/src/test/resources/deployers/security-deployer-beans.xml D backend/manager/modules/bll/src/test/resources/jndi.properties D backend/manager/modules/bll/src/test/resources/ldap.integ/ldap-test.properties.sample D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/JBossEmbeddedEJBUtilsStrategy.java 68 files changed, 0 insertions(+), 7,407 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/9439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28cdcae73619f3c94912811d4855cfb869c3c3ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix a typo in dbscripts
by emesika＠redhat.com 25 Nov '12

25 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix a typo in dbscripts ...................................................................... core: Fix a typo in dbscripts There is an small typo in the engine-db-isntall.sh script, it puts line breaks in the middle of the descriptions of two options. Change-Id: I7d8b45da7dec35e21675eaae464cd2f8e2520b6f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/engine-db-install.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d8b45da7dec35e21675eaae464cd2f8e2520b6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Use configuration to generate paths
by juan.hernandez＠redhat.com 22 Nov '12

22 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Use configuration to generate paths ...................................................................... packaging: Use configuration to generate paths The service start/stop script still had some paths hardcoded, ignoring the values of the ENGINE_* settings in /etc/ovirt-engine/engine.conf.defaults and /etc/sysconfig/ovir-engine files. This affected mostly the location of the log files. This patch fixes that. Change-Id: I0c4aa730c7b58983f27c6e2f02701a34911f41ee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/conf/engine.conf.defaults R packaging/fedora/engine-service-logging.properties.in M packaging/fedora/engine-service.py M packaging/fedora/engine-service.xml.in 5 files changed, 37 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c4aa730c7b58983f27c6e2f02701a34911f41ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Gluster Peer Detach bll command
by ofrenkel＠redhat.com 22 Nov '12

22 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Gluster Peer Detach bll command ...................................................................... engine: Gluster Peer Detach bll command Includes following related to the command for "gluster peer detach" - New Bll Command - Audit Log Messages and Severities - App Errors - VDSM Errors - Junit test class - Execution Messages Changed existing "Host" to "Server" in Remove Gluster Server related sources Change-Id: I171f1b6eb9d01f1ffb2b4a0be52a15887f534c2d Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterServerCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterServerCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/RemoveGlusterServerParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHostRemoveVDSParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostRemoveVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/RemoveGlusterServerVDSCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 23 files changed, 247 insertions(+), 68 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/9044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I171f1b6eb9d01f1ffb2b4a0be52a15887f534c2d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: replace VdsInstallerSSH: with the SSHDialog
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog ...................................................................... gluster: replace VdsInstallerSSH: with the SSHDialog VdsInstallerSSH is going to retire. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQueryTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 6 files changed, 71 insertions(+), 94 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirt...
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade ...................................................................... bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade Currently we have 4 separate bootstrap methods: 1. Host. 2. Node registration. 3. Node installation. 4. Node upgrade. While there is something common between (1-3), node upgrade is totally different sequence: 1. Unlike bootstrap it is executing foreign code (not originated at engine machine. 2. Unlike bootstrap it is non-customizable. Current implementation shares the same VdsInstaller base class among bootstrap and node upgrade, as these are totally different, we detach the OVirtUpgrader from VdsInstaller. VdsInstaller is soon to be retired. Rename OVirtUpgrader to OVirtNodeUpgrade as it handles only ovirt-node. This change also introduces the SSHDialog class, which is a class that can be used to conduct a text dialog with a component at the other end of the ssh session. It is a key component in the future vdsm-bootstrap rewrite. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875529 Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtUpgrader.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java 8 files changed, 1,249 insertions(+), 110 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Adding null check for VDS in NewGlusterServersQuery
by ofrenkel＠redhat.com 22 Nov '12

22 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Adding null check for VDS in NewGlusterServersQuery ...................................................................... engine: Adding null check for VDS in NewGlusterServersQuery In case of an empty cluster we will not get any VDS to execute the command. So a null check is added before executing the corresponding command. Change-Id: I839589d239a3dec771fc9aad7a0ef8f8e1a195fe Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I839589d239a3dec771fc9aad7a0ef8f8e1a195fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: use LocalConfig for engine http host and port
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: use LocalConfig for engine http host and port ...................................................................... bootstrap: use LocalConfig for engine http host and port This retires the VdcBootStrapUrl, PublicURLPort vdc_options in favour of the new configuration method. Change-Id: I01cd66cd83356c4dbaa0bae35ed0fe83c7c00852 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties M packaging/fedora/setup/engine-setup.py 5 files changed, 20 insertions(+), 18 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01cd66cd83356c4dbaa0bae35ed0fe83c7c00852 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Don't ask for password, before DNS SRV records are re...
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Don't ask for password, before DNS SRV records are returned. ...................................................................... tools: Don't ask for password, before DNS SRV records are returned. This patch first performs DNS SRV query to get ldap servers (and KDCs) for domain, and only if sucueesful, the user will be prompted to enter password Change-Id: I9c5132300eb1f1fd94f771cab17efe5246dbeca8 Bug-Url: https://bugzilla.redhat.com/871585 Bug-Url: https://bugzilla.redhat.com/871591 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResultEnum.java 4 files changed, 80 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c5132300eb1f1fd94f771cab17efe5246dbeca8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: some manage domains cleanup
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: some manage domains cleanup ...................................................................... tools: some manage domains cleanup During working on a bug, I discovered we have an enum we no longer use, so I removed it. Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca1 Bug-Url: https://bugzilla.redhat.com/871585 Bug-Url: https://bugzilla.redhat.com/871591 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Extract Vlan Id Validation (#871864)
by msalem＠redhat.com 22 Nov '12

22 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Extract Vlan Id Validation (#871864) ...................................................................... engine: Extract Vlan Id Validation (#871864) This patch extracts repetitive code to the mutual parent class of AddNetworkCommand and UpdateNetworkCommand. Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36 Bug-Url: https://bugzilla.redhat.com/871864 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java 3 files changed, 39 insertions(+), 45 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fix ownership of deployments and contents
by juan.hernandez＠redhat.com 21 Nov '12

21 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Fix ownership of deployments and contents ...................................................................... packaging: Fix ownership of deployments and contents A previous commit (9d5af3) changed the .spec so that the backups directory is owned by the setup sub package. This is needed, but we also need to make sure that the deployments and contents directories are still owned by the backend package, otherwise the directories are not created and the service will not start. Change-Id: Ibb4745cfc9898b43a164781fd5866cf2b1fa4f82 Bug-Url: https://bugzilla.redhat.com/876164 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4745cfc9898b43a164781fd5866cf2b1fa4f82 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: packaging: Minor bugfix release 3.1.0-4
by oschreib＠redhat.com 21 Nov '12

21 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Minor bugfix release 3.1.0-4 ...................................................................... packaging: Minor bugfix release 3.1.0-4 This prepares for a minor bug fix release to fix the bugs indicated below. Change-Id: Ic145444a0b979123944b0be175007c6d4c9cbce5 Bug-Url: https://bugzilla.redhat.com/869457 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified Moran Goldboim: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic145444a0b979123944b0be175007c6d4c9cbce5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: support python3 in make tarball
by juan.hernandez＠redhat.com 21 Nov '12

21 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: support python3 in make tarball ...................................................................... packaging: support python3 in make tarball This fix minor python3 related syntax change. Change-Id: Idec1402ff3eda6b4379b7a1562f8537f577fb994 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idec1402ff3eda6b4379b7a1562f8537f577fb994 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Messages grammar fixes
by amureini＠redhat.com 21 Nov '12

21 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Messages grammar fixes ...................................................................... core: Messages grammar fixes The main issues (in file AuditLogMessages.properties): 1. "finish to XXX" is changed to "finished XXXing" etc. 2. "XXXing the disk ${disk}" is changed to "XXing disk ${disk}" 3. "the the" sequence replaced by just one "the". 4. Removed trailing spaces. Change-Id: Ic0c03b8d5d27212679d519e12d7e7bcbad81fa91 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 20 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0c03b8d5d27212679d519e12d7e7bcbad81fa91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MoveDisk should support storage quota
by gchaplik＠redhat.com 21 Nov '12

21 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: MoveDisk should support storage quota ...................................................................... core: MoveDisk should support storage quota MoveDisk command encapsulate another command. we should support quota and call the commnad's getQuotaStorageConsumptionParameters(). Change-Id: I86c7bb9e86e0e5cd6811c5c037810dc86d1880e1 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDiskCommand.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86c7bb9e86e0e5cd6811c5c037810dc86d1880e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: fix date in ovirt-engine-sdk.spec.in
by mpastern＠redhat.com 21 Nov '12

21 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: fix date in ovirt-engine-sdk.spec.in ...................................................................... sdk: fix date in ovirt-engine-sdk.spec.in Change-Id: Iaffced84773a9d8f61ceeb36982267cc5efff1e5 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaffced84773a9d8f61ceeb36982267cc5efff1e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: release 3.2.0.5-1
by mpastern＠redhat.com 21 Nov '12

21 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.2.0.5-1 ...................................................................... sdk: release 3.2.0.5-1 Change-Id: If078e6ab7c797b8006502b3298999cf4ece7604c Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk.spec.in M setup.py 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If078e6ab7c797b8006502b3298999cf4ece7604c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: httpsconnection.source_address is not supported on pyth...
by mpastern＠redhat.com 21 Nov '12

21 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: httpsconnection.source_address is not supported on python26 #877897 ...................................................................... sdk: httpsconnection.source_address is not supported on python26 #877897 https://bugzilla.redhat.com/show_bug.cgi?id=877897 Change-Id: Ibc539087d509168347bb527eff3105b878ceffe6 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/web/httpsconnection.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc539087d509168347bb527eff3105b878ceffe6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove a dead code from VdsManager
by mkublin＠redhat.com 21 Nov '12

21 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Remove a dead code from VdsManager ...................................................................... engine: Remove a dead code from VdsManager The following condition was removed from VdsManager because it will never be true. _vdsUpdater is cleaned usually before realising a lock inside a VdsManager and exit of critical section. The method UpdateVmDynamic is usually called under lock of VdsManger, so always _vdsUpdater will be null. The method from VdsUpdateRuntimeInfo not in use anymore - that's why removed. Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 0 insertions(+), 13 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unneeded quartz job scheduling during run vm
by mkublin＠redhat.com 21 Nov '12

21 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removed unneeded quartz job scheduling during run vm ...................................................................... core: Removed unneeded quartz job scheduling during run vm The following patch is simple, I remove a scheduled quarzt job which should update the db. The main problem which is solved it is a job was scheduled each run vm, so under load we scheduled a number of jobs equals to number of run vms, it is similar to DDOS attack on internal quartz scheduler. Change-Id: I8d2365910f471bf01774d3ff7c7fb49520af5386 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 1 file changed, 11 insertions(+), 35 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d2365910f471bf01774d3ff7c7fb49520af5386 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: set storage domain format V3 for DC 3.2
by amureini＠redhat.com 20 Nov '12

20 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: set storage domain format V3 for DC 3.2 ...................................................................... core: set storage domain format V3 for DC 3.2 The automatic upgrade mechanism introduced in de5a415 didn't take in account future data center versions. Change-Id: I5fe0bde2616bb393b2d3c15da0b216531f58e54f Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fe0bde2616bb393b2d3c15da0b216531f58e54f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0