November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Re-run vm on other host if vm creation fail
by ofrenkel＠redhat.com 12 Nov '12

12 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Re-run vm on other host if vm creation fail ...................................................................... engine: Re-run vm on other host if vm creation fail When an error with error code different than 'Done' or 'exists' is returned from VDSM while trying to run a vm, there would be an attempt to re-run the vm on other host. Change-Id: I35569a2ebfbea3e8eb69b414c31748c49cb29841 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=680743 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/9085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35569a2ebfbea3e8eb69b414c31748c49cb29841 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: fix NPE in hosts tab
by shavivi＠redhat.com 11 Nov '12

11 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: engine: fix NPE in hosts tab ...................................................................... engine: fix NPE in hosts tab Change-Id: I6a912226a46ffabb5def3a4937c598e10e6961b7 Bug-id: https://bugzilla.redhat.com/871293 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Shahar Havivi: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a912226a46ffabb5def3a4937c598e10e6961b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: lsm - live snapshots rollback
by derez＠redhat.com 11 Nov '12

11 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: lsm - live snapshots rollback ...................................................................... core: lsm - live snapshots rollback * LiveMigrateDiskCommand: ** Marking taskGroupSuccesses as false when VM is UP. ** Overriding vdsId getter for nullity check. * LiveSnapshotTaskHandler: ** Executing only when taskGroupSuccess is true. ** CreateAllSnapshotsFromVmParameters - updating taskGroupSuccess (needed for CreateAllSnapshotsFromVmCommand -> endVmCommand). * AbstractSPMAsyncTaskHandler -> execute: ** Executing only when taskGroupSuccess is true. Change-Id: I24f9bc88623a9cd0addade874c7f2beeab67d423 Bug-Url: https://bugzilla.redhat.com/873329 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 3 files changed, 24 insertions(+), 26 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24f9bc88623a9cd0addade874c7f2beeab67d423 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: no compat version for exported vm
by gchaplik＠redhat.com 11 Nov '12

11 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: no compat version for exported vm ...................................................................... webadmin: no compat version for exported vm Due to a change in the backend side, while fetching an exported vm, the compatibility version is empty. Therefore the disks subtab in the export dialog was empty (there is a check for hot_plug_enabled which depends on compat_version, this subtab is reused also in the disk main tab). not showing any disk data, prevents the user from changing disk allocation policy, destination SD and quota. Change-Id: If72968b984ad1637e879eea5e64dbc38a58828ed Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 14 insertions(+), 12 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72968b984ad1637e879eea5e64dbc38a58828ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixing typo - changing "till" to "until"
by gchaplik＠redhat.com 11 Nov '12

11 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixing typo - changing "till" to "until" ...................................................................... webadmin: Fixing typo - changing "till" to "until" This patch fixes more typos of "till" in UI monitoring of async tasks. Although there is a constant of untilEndTime, after consulting with Gilad, we decided to provide more flexibility and add this consult to represent time between two values. Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c77 Bug-Url: https://bugzilla.redhat.com/863294 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/9145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing http connection leak at proxy for SPM
by mkublin＠redhat.com 11 Nov '12

11 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing http connection leak at proxy for SPM ...................................................................... core: Fixing http connection leak at proxy for SPM The following patch will fix a connection leak which we have during nullify of IrsProxy. A proxy is representating spm, each time that spm moved to maintaince or replaced we change a proxy, but coneection of http client was not closed. Also there are was some interesting code: set proxy to null and after that to call Dispose() method, where to shutdown connections when a proxy is not null - magic. Also I removed some one lines method, they don't help, and caused for a lot bugs especilaly at that class Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfee Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 22 insertions(+), 26 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove IsValidVDSCommand (Preporation for removing g...
by mkublin＠redhat.com 11 Nov '12

11 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Remove IsValidVDSCommand (Preporation for removing global lock on SPM ops) ...................................................................... engine: Remove IsValidVDSCommand (Preporation for removing global lock on SPM ops) The following patch will remove IsValidVDSCommand. The following command was used in order to check if pool is up and we have spm. First of all the using of command at canDoaction is wrong, a simple check for status of pool or status of domain should be enough. But the most exciting part is that the following command can trigger SPM election and it is done without any synchronization, so we can easilly have a couple spm elections simenteniously. The code at IsValidVDSCommand was getCurrentIrsProxyData().getIsValid(), which is actually code at IrsProxyData: getIrsProxy() != null, where getIrsProxy() is elect SPM if we have not one. Change-Id: I73c0fa0fd66f2f14132594a0b0450a7ecd7cf166 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsValidVDSCommand.java 14 files changed, 73 insertions(+), 159 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73c0fa0fd66f2f14132594a0b0450a7ecd7cf166 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix upgrade scripts gap validation
by emesika＠redhat.com 10 Nov '12

10 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix upgrade scripts gap validation ...................................................................... core: fix upgrade scripts gap validation Current implementation of upgrade mechanism does not allow subsequent scripts to have more than a 10 gap in their numbering. For example, if last installed script is 03011500 then a subsequent upgrade with 03011501 to 03011510 is OK while 03011511 03011512 and so forth will be rejected. This patch fix bug when moving to another major version , for example from 0301 to 0302. It adds a condition that checks for gaps between two subsequent versions only if their major version (first 4 digits) match. Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c78 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Generate UUIDs from engine
by emesika＠redhat.com 10 Nov '12

10 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Generate UUIDs from engine ...................................................................... core: Generate UUIDs from engine We used to generate UUIDs used as primary keys of bookmarks, tags, clusters hosts and pools in the database. This patch changes the engine so that it generates them directly and passes them as parameters to the stored procedures as needed. Note that some UUIDs can still be generated using the database function uuid_generate_v1 during first installation and upgrades, as upgrade scripts haven't been changed. Change-Id: Idecd3aa570017b4198243a9d3f9ebfdc7a777195 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/bookmarks_sp.sql M backend/manager/dbscripts/business_entity_snapshot_sp.sql M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/insert_data.sql M backend/manager/dbscripts/inst_sp.sql M backend/manager/dbscripts/tags_sp.sql M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/dbscripts/vm_pools_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitySnapshot.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BusinessEntitySnapshotDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsDAOImpl.java M packaging/fedora/setup/engine-setup.py 19 files changed, 81 insertions(+), 53 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/8990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idecd3aa570017b4198243a9d3f9ebfdc7a777195 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed getVmNetworkInterfaceDao
by lhornyak＠redhat.com 08 Nov '12

08 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed getVmNetworkInterfaceDao ...................................................................... core: removed getVmNetworkInterfaceDao getVmNetworkInterfaceDao is doing the same as getVmNetworkInterfaceDAO defined declared in superclass. Change-Id: I22fa3778a4540e35a826ed6ea3ee5153df4e17a1 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 12 files changed, 16 insertions(+), 21 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22fa3778a4540e35a826ed6ea3ee5153df4e17a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Get Gluster Volume Profile Info Query
by ofrenkel＠redhat.com 08 Nov '12

08 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Get Gluster Volume Profile Info Query ...................................................................... engine: Get Gluster Volume Profile Info Query - New entity classes for Gluster Volume Profile Info - New XmlRpc class for Profile Info - New bll and vds query - New Junit test for the query Change-Id: Ic47eb168bd4bcd5f3297a7e89a5ef46e643ed73e Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BlockStats.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProfileDetails.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/FopStats.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ProfileStatsType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StatsInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeQueriesParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeProfileInfoVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeProfileInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 21 files changed, 673 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic47eb168bd4bcd5f3297a7e89a5ef46e643ed73e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Integer reference comparison fix
by masayag＠redhat.com 08 Nov '12

08 Nov '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Integer reference comparison fix ...................................................................... core: Integer reference comparison fix Changed the comparison from reference comparison(==) to equals on Integer values, since higher values of Integer are not cached, and there is no varanty even with lower values. Change-Id: I001fcb6349b36ee22e49e003c8391ad44002e5ac Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I001fcb6349b36ee22e49e003c8391ad44002e5ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:PCI addresses are deleted when VM...(#873581)
by emesika＠redhat.com 07 Nov '12

07 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core:PCI addresses are deleted when VM...(#873581) ...................................................................... core:PCI addresses are deleted when VM...(#873581) PCI addresses are deleted when VM Template is imported When a VM or Template is imported, we must set the VM/Template device addresses as appears in the OVF. This patch adds another signature to addManagedDevice with an additional address parameter and uses it for imported managed objects. Change-Id: I41a0826a82aaec39425261c9030d99cd3b462832 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 35 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41a0826a82aaec39425261c9030d99cd3b462832 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmBase - diskList member - remove final
by derez＠redhat.com 07 Nov '12

07 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: VmBase - diskList member - remove final ...................................................................... core: VmBase - diskList member - remove final Removing 'final' keyword from diskList member in VmBase. GWT RPC doesn't serialize 'private final' members (i.e. diskList is returned as null to the UI). Change-Id: I6bb5fe3d0abfd15f3b38233309a3f468f7fafdbf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bb5fe3d0abfd15f3b38233309a3f468f7fafdbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Failed move disk should not set illegal disk.
by mlipchuk＠redhat.com 07 Nov '12

07 Nov '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Failed move disk should not set illegal disk. ...................................................................... core: Failed move disk should not set illegal disk. When disk failed to be moved to another storage domain, the engine set the disk status to Illegal with the destination storage domain. The proposed fix, set the disk state to OK, with the original storage domain if the move task fails. By doing that, the user can use the VM disks even if the move operation failed. As part of the fix, some of the code which updated the destination storage domain in the disk, moved from the execute part to the EndSuccesfully section. Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 2 files changed, 25 insertions(+), 24 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use String instead of StringBuilder in SysprepHandler ...
by ofrenkel＠redhat.com 07 Nov '12

07 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: use String instead of StringBuilder in SysprepHandler (#873742) ...................................................................... core: use String instead of StringBuilder in SysprepHandler (#873742) SysprepHandler uses StringBuilder as it is a string: it creates new instances for replacements. this patch changes StringBuilder to String to make it clear to the user it is regular string that need to be set. also added return value to populateSysPrepDomainProperties as it manipulates the string inside it as well, caused changes to domain, user and pass in the sysprep file to be lost. Change-Id: Ie447c30759d19e4d42a722deb550a6233becb490 Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=873742 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java 2 files changed, 27 insertions(+), 32 deletions(-) Approvals: Omer Frenkel: Verified Maor Lipchuk: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie447c30759d19e4d42a722deb550a6233becb490 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix fixtures.xml
by yzaslavs＠redhat.com 07 Nov '12

07 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix fixtures.xml ...................................................................... core: fix fixtures.xml Removed the hypervisor_type column from fixtures.xml to fix the DAO tests. Change-Id: I237ffd0eaebc6dffb90571ddcc8d702e4003ab3f Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Laszlo Hornyak: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I237ffd0eaebc6dffb90571ddcc8d702e4003ab3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume Brick - Advanced Details
by gchaplik＠redhat.com 07 Nov '12

07 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume Brick - Advanced Details ...................................................................... webadmin: Gluster Volume Brick - Advanced Details A new action 'Advanced Details' is added to the Bricks sub tab of volume, which will open Brick Advanced Details dialog when the user clicks. Brick Details dialog contains 4 sections named General, Clients, Memory Statistics and Memory Pools. General section will show the basic information about the selected brick. Clients section will list all the clients which are exchanged data with the brick. Change-Id: I6571020ed3a17df21eef40acf4cda2bbf4fb2374 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/BrickAdvancedDetailsModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/BrickPropertiesModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/MemoryStatisticsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/BrickAdvancedDetailsPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java 13 files changed, 978 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6571020ed3a17df21eef40acf4cda2bbf4fb2374 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding Gluster Services Sub Tab to Cluster
by gchaplik＠redhat.com 07 Nov '12

07 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding Gluster Services Sub Tab to Cluster ...................................................................... webadmin: Adding Gluster Services Sub Tab to Cluster A new sub tab named 'Services' is added to the Cluster Tab. This sub tab will be shown only if the cluster supports Gluster. NFS, SHD are the two different type of services. Hosts in the Cluster will have NFS, SHD services running. A filter panel is added to filter the results based on Service Type and host address. Change-Id: Iea624f12a07f4aa9b1c6ffa1548aaafb16a00a7a Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterServiceModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterPermissionPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterServicePresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.ui.xml 16 files changed, 557 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea624f12a07f4aa9b1c6ffa1548aaafb16a00a7a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: import cleanup in AlertDirector.java
by mkublin＠redhat.com 07 Nov '12

07 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: import cleanup in AlertDirector.java ...................................................................... core: import cleanup in AlertDirector.java Use fully qualified imports. Change-Id: If0c2a9f699b4b5e9227aeb9b6ef102ccfad72b0c Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c2a9f699b4b5e9227aeb9b6ef102ccfad72b0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: Fix attach/detach message
by mkublin＠redhat.com 07 Nov '12

07 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fix attach/detach message ...................................................................... core: Fix attach/detach message Fix VAR__ACTION__ATTACH_ACTION_TO: action substitution was faulty, and now is "attach". VAR__ACTION__DETACH_ACTION_TO: action substitution + fix "dettach" typo (detach). VAR__ACTION__ATTACHE_DESKTOP_TO changed to VAR__ACTION__ATTACH_DESKTOP_TO, as well as the action - attach instead of attache. Change-Id: If91484360ffa35b3c044695a8277cda491f37b3e Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_de.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_it.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_nl.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors_de.properties M backend/manager/modules/utils/src/test/resources/AppErrors_it.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties 22 files changed, 25 insertions(+), 25 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If91484360ffa35b3c044695a8277cda491f37b3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't use PostgreSQL UUID extension
by emesika＠redhat.com 06 Nov '12

06 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Don't use PostgreSQL UUID extension ...................................................................... core: Don't use PostgreSQL UUID extension Replace the uuid_generate_v1 function from the uuid-ossp extension with a custom function that generates UUIDs from a sequence. That way we don't need the extension any longer. Note that this is the first step to remove completely the generation of UUIDs in the database, as they should be generated by the engine. Change-Id: I819e37224288b202d2126cec475ee1d97f83a925 Bug-Url: https://bugzilla.redhat.com/870056 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/create_db.sh M backend/manager/dbscripts/create_db_devel.sh M backend/manager/dbscripts/create_functions.sql M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/engine-db-install.sh M packaging/fedora/setup/engine_validators.py M packaging/fedora/spec/ovirt-engine.spec.in 7 files changed, 43 insertions(+), 101 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I819e37224288b202d2126cec475ee1d97f83a925 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed unnecessary 'continue' statements
by lhornyak＠redhat.com 06 Nov '12

06 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Removed unnecessary 'continue' statements ...................................................................... engine: Removed unnecessary 'continue' statements Change-Id: I98b93b739db7d41384cf6455e43e0b4f3182d2ff Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java 2 files changed, 20 insertions(+), 33 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98b93b739db7d41384cf6455e43e0b4f3182d2ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SEAT - call startPollingAsyncTasks on revert
by derez＠redhat.com 06 Nov '12

06 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: SEAT - call startPollingAsyncTasks on revert ...................................................................... core: SEAT - call startPollingAsyncTasks on revert Calling startPollingAsyncTasks on internalEndWithFailure (needed for rollback when executing SEAT). Change-Id: I7c8fb8fdbf2b89eb6d3949c0eec233d9dc3535dc Bug-Url: https://bugzilla.redhat.com/872316 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c8fb8fdbf2b89eb6d3949c0eec233d9dc3535dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: localize number of VMs for Hosts Load
by ecohen＠redhat.com 06 Nov '12

06 Nov '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: localize number of VMs for Hosts Load ...................................................................... webadmin: localize number of VMs for Hosts Load In the Hosts grid (both in Hosts main tab and Hosts sub-tab in Clusters main tab), changed the string concatenation of "[x] VMs" to a localized full phrase, to ease localization of this phrase. Change-Id: I0c9e1a6115bf7a3ab7a8a018015335c6d87d3e24 Bug-Url: https://bugzilla.redhat.com/871293 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterHostView.java 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9e1a6115bf7a3ab7a8a018015335c6d87d3e24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0