November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: prevent clone VM while disk is locked
by derez＠redhat.com 06 Nov '12

06 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: prevent clone VM while disk is locked ...................................................................... core: prevent clone VM while disk is locked * Preventing clone VM from snapshot when one of the disks are locked. * Taking an exclusive lock on LockingGroup.VM Change-Id: I9899744859475b2d27ca858c21279fb439768f9b Bug-Url: https://bugzilla.redhat.com/872930 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9899744859475b2d27ca858c21279fb439768f9b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Continue reduce usage of getCurrentVdsId()
by mkublin＠redhat.com 06 Nov '12

06 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Continue reduce usage of getCurrentVdsId() ...................................................................... engine: Continue reduce usage of getCurrentVdsId() Reduced usage of getCurrentVdsId() and removed some unused commands The getCurrentVdsId() was used in order to check if there is an SPM, the following check is done before call to ExecuteIrsBrokerCommand() Change-Id: Icc8e06fd1814d272788c386ad36e168ec3a9d09d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetStorageDomainInfoVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetStorageDomainInfoVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetTaskInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetTaskStatusVDSCommand.java 6 files changed, 7 insertions(+), 77 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc8e06fd1814d272788c386ad36e168ec3a9d09d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Continue preparation for removing a global lock at S...
by mkublin＠redhat.com 06 Nov '12

06 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Continue preparation for removing a global lock at SPM calls ...................................................................... engine: Continue preparation for removing a global lock at SPM calls Removed usage of getmCurrentIrsHost() all over commands. For example, at FenceVdsManualyCommand it reduced one query to DB Change-Id: Iaa5b20da89594f0fd245cfb87794c29b31273193 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetIrsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommand.java 6 files changed, 23 insertions(+), 37 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa5b20da89594f0fd245cfb87794c29b31273193 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Preparation for removing a global lock on spm calls ...
by mkublin＠redhat.com 06 Nov '12

06 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Preparation for removing a global lock on spm calls at engine side ...................................................................... engine: Preparation for removing a global lock on spm calls at engine side The following patch is preporation for removing a global lock on spm operation at engine side. In order to do this as a first stage I am removing or reduce an usage of methods which can require additional synchronization. Thes patch is removing some usage of getCurrentVdsId() and removed unused commands Change-Id: I3044261122112b5557953c92dd80782d4edc444e Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CurrentVdsIdVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetIsoListVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsMonitorValidVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMClearTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksStatusesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetTaskInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMRevertTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMStopTaskVDSCommand.java 11 files changed, 46 insertions(+), 114 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3044261122112b5557953c92dd80782d4edc444e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools : engine-manage-domains location option no longer vali...
by yzaslavs＠redhat.com 06 Nov '12

06 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : engine-manage-domains location option no longer valid ...................................................................... tools : engine-manage-domains location option no longer valid In command line parameters for engine-manage-domains the -location (=remote/local) parameter is an obsolete option but the command gives no error when added to the command, and has no effect. This also appears with -action=list, prints that the domain is remote, but all domains are treated as "remote" so there is no point in printing that the domain is remote. Change-Id: I3384c6981d38b03d2f2856ff8af69ac9d1c65056 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=871085 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3384c6981d38b03d2f2856ff8af69ac9d1c65056 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Execute wasn't called after creating SaveNetworkCo...
by alkaplan＠redhat.com 06 Nov '12

06 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Execute wasn't called after creating SaveNetworkConfigAction ...................................................................... webadmin: Execute wasn't called after creating SaveNetworkConfigAction - It is not enough to create new instance of SaveNetworkConfigAction, in order to excecute the action, execute method should be called. - SaveNetworkConfigAction, should get the Host through the ctor. Change-Id: I580638cf8319876459a9bcdf5e9faa93c8b4ae5f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SaveNetworkConfigAction.java 3 files changed, 187 insertions(+), 179 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I580638cf8319876459a9bcdf5e9faa93c8b4ae5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: return SESSIONID header along with cookie
by mpastern＠redhat.com 06 Nov '12

06 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: return SESSIONID header along with cookie ...................................................................... restapi: return SESSIONID header along with cookie Change-Id: I26667239157be04afc6dc446e8c7ad98ec40c778 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26667239157be04afc6dc446e8c7ad98ec40c778 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: use empty string instead of empty constant
by shavivi＠redhat.com 06 Nov '12

06 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: use empty string instead of empty constant ...................................................................... webadmin: use empty string instead of empty constant Change-Id: I2bda325519c667733115b40d849ba67030296d73 Bug-Id: https://bugzilla.redhat.com/871380 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bda325519c667733115b40d849ba67030296d73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove OperationMode
by lhornyak＠redhat.com 06 Nov '12

06 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove OperationMode ...................................................................... core: remove OperationMode OperationMode is not used since Xen is not supported by oVirt. - modified DB schema - field removed from DAO's - field removed from beans - removed OperationMode enum Change-Id: I2ee660e92886649cd2b8e7220b6f7deff2fe262f Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1510_drop_operation_mode.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OperationMode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 17 files changed, 18 insertions(+), 87 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ee660e92886649cd2b8e7220b6f7deff2fe262f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine-cli[master]: cli: update README
by mpastern＠redhat.com 06 Nov '12

06 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: update README ...................................................................... cli: update README Change-Id: Iefbb902acf42c1fdf0704f3ae9d3b99b4a5d8579 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M README 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefbb902acf42c1fdf0704f3ae9d3b99b4a5d8579 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixing typo of compatibility level
by yzaslavs＠redhat.com 06 Nov '12

06 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Fixing typo of compatibility level ...................................................................... webadmin: Fixing typo of compatibility level The typo exists at the sub tab of clusters at datacenters tab Change-Id: I2bda325519c667733115b40d849ba67030296d71 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/873511 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bda325519c667733115b40d849ba67030296d71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Better warning message for LSM
by derez＠redhat.com 06 Nov '12

06 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Better warning message for LSM ...................................................................... webadmin: Better warning message for LSM Better warning messages for Live Storage Migration, representing the fact it's a tech review. Change-Id: I7d2e3382ec151d2b55475accf508487f00c9aaef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d2e3382ec151d2b55475accf508487f00c9aaef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove HypervisorType
by lhornyak＠redhat.com 06 Nov '12

06 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove HypervisorType ...................................................................... core: remove HypervisorType HypervisorType is not used in any decisionmaking logic in oVirt. This patch - removes it from db schema - removes field from DAO classes - removes field from data representation - removes the HyperVisor enum - clears it from gwt xml's and cloner - removes the fields from the restapi mappings Change-Id: Id04911545fe6ef9b98ce3898c4ecc160a83b2dcb Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1500_drop_hypervisor_type.sql M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HypervisorType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 26 files changed, 32 insertions(+), 151 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id04911545fe6ef9b98ce3898c4ecc160a83b2dcb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: lsm - prevent moving a shareable disk
by derez＠redhat.com 06 Nov '12

06 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: lsm - prevent moving a shareable disk ...................................................................... core: lsm - prevent moving a shareable disk * Preventing shareable disk move (since snapshots on shareable disks are not allowed and a creation of a snapshot is required for LSM). * Fixing error messages (shared -> shareable). * Fixing typo in error messages (opperation -> operation). Change-Id: Ibd235a4c0634f246d7613e520af7f245ccdbc779 Bug-Url: https://bugzilla.redhat.com/872969 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 15 insertions(+), 16 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd235a4c0634f246d7613e520af7f245ccdbc779 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improve error logging when there are LDAP queries erro...
by yzaslavs＠redhat.com 05 Nov '12

05 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improve error logging when there are LDAP queries errors ...................................................................... core: Improve error logging when there are LDAP queries errors The following patch improves logging of LDAP queries errors. It will try to get the root cause of the exception, and to return a friendly string for it Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8a Bug-Url: https://bugzilla.redhat.com/865098 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java 3 files changed, 32 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refresh gluster data periodically
by ofrenkel＠redhat.com 05 Nov '12

05 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Refresh gluster data periodically ...................................................................... engine: Refresh gluster data periodically Introducing GlusterManager, which will be initialized when application comes up. It fetches Gluster related data periodically and updates the database with it. Lightweight data (like volume properties) that doesn't add serious overhead on gluster processes is fetched more frequently (GlusterRefreshRateLight), and the data (like brick status) that adds significant overhead of Gluster processes is fetched less frequently (GlusterRefreshRateHeavy). Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql A backend/manager/dbscripts/upgrade/03_01_1490_gluster_refresh_event_map.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtil.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumesListVDSParameters.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtilTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 39 files changed, 2,343 insertions(+), 66 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Default VM display type overrides current VM displa...
by mpastern＠redhat.com 05 Nov '12

05 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Default VM display type overrides current VM display type in REST API(#864961) ...................................................................... restapi: Default VM display type overrides current VM display type in REST API(#864961) The api returns the default display type for a VM. When a VM is started with 'Run Once' and the display type is changed for just that session, the api should return the display type of the current VM session not the default display type. Change-Id: Ie838e8096909865647bed2d79e9571059f6095aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=864961 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie838e8096909865647bed2d79e9571059f6095aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Create ISCSI LUN Disk: Connection details should be...
by mpastern＠redhat.com 05 Nov '12

05 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Create ISCSI LUN Disk: Connection details should be mandatory #864840 ...................................................................... restapi: Create ISCSI LUN Disk: Connection details should be mandatory #864840 extra validation according to [1] [1] https://bugzilla.redhat.com/show_bug.cgi?id=864840#c7 Change-Id: Icfd508f225a1386f6a588c9d58cc1df286a82cbb Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java 3 files changed, 53 insertions(+), 15 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfd508f225a1386f6a588c9d58cc1df286a82cbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #872819 - RSDL Create Lun Disk params
by oliel＠redhat.com 05 Nov '12

05 Nov '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #872819 - RSDL Create Lun Disk params ...................................................................... restapi: #872819 - RSDL Create Lun Disk params RSDL metadata (.yaml file): for direct-LUN disk don't require size, but require lun id, lun type, and lun connection-details (address, target, port). https://bugzilla.redhat.com/872819 Change-Id: I5ed6caae3ed3a5bc49113febaf7df5ab612d57df Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ed6caae3ed3a5bc49113febaf7df5ab612d57df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: resatpi: #873194 - Disk.lunStorage - change field name
by oliel＠redhat.com 05 Nov '12

05 Nov '12

Ori Liel has submitted this change and it was merged. Change subject: resatpi: #873194 - Disk.lunStorage - change field name ...................................................................... resatpi: #873194 - Disk.lunStorage - change field name Change: <disk> <lunStorage>...</lunStorage> </disk> To: <disk> <lun_storage>...</lun_storage> </disk> https://bugzilla.redhat.com/show_bug.cgi?id=873194 Change-Id: I7d2a2747866c604bfda9e7da0578d83ea63e529e Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d2a2747866c604bfda9e7da0578d83ea63e529e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix events grid view to fix ES locale
by shavivi＠redhat.com 05 Nov '12

05 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: fix events grid view to fix ES locale ...................................................................... webadmin: fix events grid view to fix ES locale Change-Id: Ieddf96a782d0657b58f4b16c26f72a9823199b60 Bug-Id: https://bugzilla.redhat.com/871391 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieddf96a782d0657b58f4b16c26f72a9823199b60 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing reschedule of monitoring of vdsm by another v...
by mkublin＠redhat.com 05 Nov '12

05 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing reschedule of monitoring of vdsm by another vdsm ...................................................................... core: Removing reschedule of monitoring of vdsm by another vdsm The following patch will remove a reschedule of monitoring of vdsm, from other thread of monitoring. Such behaviour can cause to spending all quartz thread on reschedule of monitoring of the same vdsm. The use case: 1. We have 10 vdsms and 10 vms that are migrating to same vdsm 2. Each vdsm can schedule additional refresh of destination vdsm 3. Result : we has 10 quartz jobs that are trying to monitor the same vdsm and additional job which is regular monitoring (runs each 2 seconds) It is obvious that under load and in more big environment we will have a timeouts when all quartz threads will be busy by monitoring of the same vdsms Change-Id: I5534b3b627e992efbce152935ad207c978a7feed Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 4 insertions(+), 37 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5534b3b627e992efbce152935ad207c978a7feed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Get Volume Advanced Details Query
by ofrenkel＠redhat.com 05 Nov '12

05 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Get Volume Advanced Details Query ...................................................................... engine: Get Volume Advanced Details Query - New entity classes for Volume Advanced Details - New Gluster Volume Advanced Details parameter class - New XmlRpc class for volume status - New bll and vds query - New Gluster Volume Dao method to fetch Nfs enabled volumes - Added Junit test for the query Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickDetails.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProperties.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterClientInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeStatusOption.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/MallInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/MemoryStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/Mempool.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeAdvancedDetailsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtil.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtilTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeAdvancedDetailsVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeStatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 30 files changed, 1,482 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/7807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Ensure "upgrade" alert on host general tab appears...
by achub＠redhat.com 05 Nov '12

05 Nov '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Ensure "upgrade" alert on host general tab appears correctly (#839336) ...................................................................... webadmin: Ensure "upgrade" alert on host general tab appears correctly (#839336) https://bugzilla.redhat.com/839336 Change-Id: I57002308a192c81e84f9730564d41fb03309d006 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57002308a192c81e84f9730564d41fb03309d006 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove unnecessary if clause
by masayag＠redhat.com 05 Nov '12

05 Nov '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove unnecessary if clause ...................................................................... engine: Remove unnecessary if clause Modified an if-else statement of the following structure: if (A) { ... } else if (!A) { ... } To: if (A) { ... } else { ... } Change-Id: I1ea9acbf5dce7608660fa7a8055eb4c6f45c2526 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea9acbf5dce7608660fa7a8055eb4c6f45c2526 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove empty constant from storage general tab
by shavivi＠redhat.com 04 Nov '12

04 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: remove empty constant from storage general tab ...................................................................... webadmin: remove empty constant from storage general tab No need to use constant for a separation line. Change-Id: I3300aadbf25e3b5c0bc223a73fc6e72181b5e9ad Bug-Id: https://bugzilla.redhat.com/870998 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3300aadbf25e3b5c0bc223a73fc6e72181b5e9ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network Main Tab- cleanup
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network Main Tab- cleanup ...................................................................... webadmin: Network Main Tab- cleanup - Formatting the new classes. - Fix non-logic comments from previous reviews (data members names, methods order...) Change-Id: I8773ac1cb7131123fed4a91fe751308c3575abcd Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/NetworkSubTabPanelPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java 13 files changed, 389 insertions(+), 470 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8773ac1cb7131123fed4a91fe751308c3575abcd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: LSM - rollback on non-running VM
by derez＠redhat.com 04 Nov '12

04 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: LSM - rollback on non-running VM ...................................................................... core: LSM - rollback on non-running VM LiveMigrateDiskCommand: Initiating rollback if the VM stops during migration. On each step of the migration process a new command is created (in order to execute the next task), if the VM is no longer running the previous tasks should be reverted/cleared. LiveSnapshotTaskHandler: On compensation, image's status should be reverted to OK. Updating status using DestinationImageId since ImageId might be obsolete - depending on which step the failure occurred (when taking a snapshot, a new active image is generated). CreateImagePlaceholderTaskHandler: Rollback should be DeleteImage. VmReplicateDiskStartTaskHandler: No rollback for task. Change-Id: I7aafc5cd63f961470124c984afb2e7a9d74a0de2 Bug-Url: https://bugzilla.redhat.com/872316 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java 4 files changed, 35 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aafc5cd63f961470124c984afb2e7a9d74a0de2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated interaction with user on async tasks
by oschreib＠redhat.com 04 Nov '12

04 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated interaction with user on async tasks ...................................................................... packaging: Updated interaction with user on async tasks * The previous try/finally clause included the initial interaction with the user, where tasks were found and user was asked whether to continue (and if user continues, then restart engine in maintenance mode), as well as some operations that could end with an exception. If, for example, user chooses not to continue, 'finally' will kick in, and try to restore the engine configuration, although it didn't change yet. Additionally, the setting "zombie tasks" timeout could fail and raise an exception, which would also try to restore both an engine AND "zombie tasks timeout", which is not set yes, leading to an incorrect setting. This patch aims to solve these issues by moving try/finally block to the later code, beginning only with the final loop, when a user has agreed to it. * Also, added additional try/finally block to the configureForMaintenance function, so that in case the creation of the temp configuration fails, we would still try to cleanup the file if it was created and raise the exception. * Also, changed the return value in getRunningTasks and getCompensation functions from "return None" to empty string "return ''". This improves the printouts to the user, and instead of printing "None" in tasks, nothing is printed if no tasks are found. Change-Id: Ia1f1aaf7ac812d69dc81f3fb8dee5a626bc7634a Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/output_messages.py 3 files changed, 66 insertions(+), 35 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1f1aaf7ac812d69dc81f3fb8dee5a626bc7634a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: redundant comma at the end of disabled command but...
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: redundant comma at the end of disabled command button tootip. ...................................................................... webadmin: redundant comma at the end of disabled command button tootip. The disabled command button tootip is a list of comma separeated reason. There should be a "," after the last reason. Change-Id: I5c8f5a87bb75a4c73f7dffc24c259794321adde5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c8f5a87bb75a4c73f7dffc24c259794321adde5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add/Edit logical networks- tooltip for disables ch...
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add/Edit logical networks- tooltip for disables checkboxes ...................................................................... webadmin: Add/Edit logical networks- tooltip for disables checkboxes - If VM Networks checkbox is disabled, tooltip should be displayed- Non-VM networks are not supported for Cluster version x.x - If override MTU is disabled, tooltip should be displayed- Overriding MTU configuration is not supported for Cluster version x.x Change-Id: Ibf0f34d1dc6e9927e08a152c90c3748ccb536639 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0f34d1dc6e9927e08a152c90c3748ccb536639 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add/Edit network- Vlan tag before VM Network
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add/Edit network- Vlan tag before VM Network ...................................................................... webadmin: Add/Edit network- Vlan tag before VM Network Swap the locations of Vlan tag and VM Network. Change-Id: I40ceb004bd18837ead57435a010f619a6b3a443c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40ceb004bd18837ead57435a010f619a6b3a443c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network Main Tab- add remove vnic action
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network Main Tab- add remove vnic action ...................................................................... webadmin: Network Main Tab- add remove vnic action - Netwrok->VM,Template- adding action remove. - Moving the common code of remove vnic to RemoveVmInterfaceModel. Change-Id: I730eeb0597c56451908312fa20637df0ec3fedbd Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/RemoveConfirmationPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RemoveVmInterfaceModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RemoveVmTemplateInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java 12 files changed, 408 insertions(+), 145 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730eeb0597c56451908312fa20637df0ec3fedbd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Allow quota memory size to excceed 65535MB
by gchaplik＠redhat.com 04 Nov '12

04 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Allow quota memory size to excceed 65535MB ...................................................................... webadmin: Allow quota memory size to excceed 65535MB Removed faulty restriction Change-Id: I2b5f672b1785215af489461e390f0186a9385d43 Bug-Url: https://bugzilla.redhat.com/870213 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b5f672b1785215af489461e390f0186a9385d43 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: updated reports' localiztion
by ydary＠redhat.com 04 Nov '12

04 Nov '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: updated reports' localiztion ...................................................................... reports: updated reports' localiztion Change-Id: I66d6571410db6b6364d4a8cca4f59c21ece987e9 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_es.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_ja.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_pt_BR.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_zh_CN.properties.data 5 files changed, 314 insertions(+), 20 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d6571410db6b6364d4a8cca4f59c21ece987e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated VDC utilities to accept alternative binar...
by oschreib＠redhat.com 04 Nov '12

04 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated VDC utilities to accept alternative binary ...................................................................... packaging: Updated VDC utilities to accept alternative binary * Renamed several parameters from _RHEVM_ convention to _ENGINE_ * Added the optional parameter for engine-conf binary in getVdcOptions function * Added the optional parameters for engine-conf binary and configuration in updateVdcOptions function. * Updated the definition of configureTasksTimeout function to utilize the aforementioned parameters. * Updated the usage of configureTasksTimeout function. Change-Id: Ica1c009bffbcd956c64929050e9ebb806be006af Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 4 files changed, 31 insertions(+), 21 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica1c009bffbcd956c64929050e9ebb806be006af Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cannot unpause VM started in paused mode
by rgolan＠redhat.com 04 Nov '12

04 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: engine: cannot unpause VM started in paused mode ...................................................................... engine: cannot unpause VM started in paused mode Have 2 clusters, in each have one host. In one of this clusters create a VM. Run it in pause mode, wait until it starts in the pause mode and tham start it. The VM will not start. The problem was in VdsSelector in the check where it tried to find out, if the specific VM is migrating to the same host. This check makes sense for the migrating of the VM, but not for running it. Fixed by making the checks aware of if the VM is migrating or not. This patch also removes one duplication - one of the checks has been copy-pasted twice. There was also a workaround which ignored the situation that the VM would be migrated to the same host - it is already implmented in the HostValidator so removed. Change-Id: I8cca521f79bfb7d5762f2c996200916a10afc36a Bug-Url: https://bugzilla.redhat.com/872205 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PowerClientMigrateOnConnectCheckCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 4 files changed, 28 insertions(+), 49 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cca521f79bfb7d5762f2c996200916a10afc36a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added quering alternative DB in checking version
by oschreib＠redhat.com 04 Nov '12

04 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added quering alternative DB in checking version ...................................................................... packaging: Added quering alternative DB in checking version Added a dbName parameter to the unsupportedVersionsPresent() function that can be used to query an alternative DB. Change-Id: I9ac97021b568d370bb3a4bc22c330b2cbeda8ac0 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ac97021b568d370bb3a4bc22c330b2cbeda8ac0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: <placement_policy> should accept <host> by name (#7...
by mpastern＠redhat.com 04 Nov '12

04 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: <placement_policy> should accept <host> by name (#757115) ...................................................................... restapi: <placement_policy> should accept <host> by name (#757115) The addition of a VM by host name doesn't work as intended. The VM is being added without a host id. This patch fixes the issue by passing the computed host id from host name to the VmStatic class, which is used by the backend to create the VM. Change-Id: I09c9ad52db15e18813632598aca701e2b18af3d6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=757115 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09c9ad52db15e18813632598aca701e2b18af3d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Support loading a VM snapshot when conf is not avail...
by derez＠redhat.com 02 Nov '12

02 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: engine: Support loading a VM snapshot when conf is not available. ...................................................................... engine: Support loading a VM snapshot when conf is not available. Enhance GetVmConfigurationBySnapshotQuery query to support loading a VM snapshot when OVF configuration is not available. This is mainly to handle snapshots that were taken with older versions of engine that didn't store full VM configuration as an OVF. Change-Id: Iddfae10354603e2ec9acb61f91e1361dd7504da4 Bug-Url: https://bugzilla.redhat.com/866173 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java 1 file changed, 41 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddfae10354603e2ec9acb61f91e1361dd7504da4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix regression for statelessVM.
by mlipchuk＠redhat.com 02 Nov '12

02 Nov '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix regression for statelessVM. ...................................................................... core: Fix regression for statelessVM. Stateless VM cpuld not run since the parameter command was set in the parent parameters, instead in the command it self. Change-Id: I1c7bf292620f397ae47df748102bc1f226ef19a2 Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=872201 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c7bf292620f397ae47df748102bc1f226ef19a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added version dependency for dbscripts package
by juan.hernandez＠redhat.com 02 Nov '12

02 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Added version dependency for dbscripts package ...................................................................... packaging: Added version dependency for dbscripts package Change-Id: Ie71b7a6cc43534fc577e498ab1dd2e49726c6e2d Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alex Lourie: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie71b7a6cc43534fc577e498ab1dd2e49726c6e2d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: tools: Fix locale issue (BZ858918)
by oschreib＠redhat.com 02 Nov '12

02 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: tools: Fix locale issue (BZ858918) ...................................................................... tools: Fix locale issue (BZ858918) Removed md5sum check as it isn't really necessary. Change-Id: Iaa74a561bcc2e585e73d0a53cb0cea250e4eaa49 Signed-off-by: Keith Robertson <kroberts(a)redhat.com> --- M src/rhev/logcollector.py 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa74a561bcc2e585e73d0a53cb0cea250e4eaa49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed ou...
by tjelinek＠redhat.com 01 Nov '12

01 Nov '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed out on windows client ...................................................................... userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed out on windows client Steps to Reproduce: 1. Go to the RHEVM user portal (Basic or Extended) from a windows client 2. Go to console options of a running VM Pass Ctrl-Alt-Del to virtual machine is checked and grayed out. Expected result is that this option should be unchecked and grayed out. Fixed by adding check for windows client in the SpiceInterfaceImpl. Change-Id: I80b4144e31bf7cafa854945189dacff5fdc3a5af Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=868395 --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80b4144e31bf7cafa854945189dacff5fdc3a5af Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed exception on trash-icon (#872128)
by ydary＠redhat.com 01 Nov '12

01 Nov '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed exception on trash-icon (#872128) ...................................................................... reports: fixed exception on trash-icon (#872128) the resource pth was not correct, this patch fixes this. bug-url: https://bugzilla.redhat.com/872128 Change-Id: I360141c71fbd76656f26d75ae56e5c45c5f3cda4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/Hosts_Inventory_jrxml.data M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/full details br1.jrxml.data M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/full details.jrxml.data M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7_table.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/cluster_uptime_br7_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/single_host_uptime_br8_files/single_host_uptime_br8_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/report5.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14_table.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/virtual_servers_uptime_br14_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/datacenter_quality_of_service_hosts_br6b_files/datacenter_quality_of_service_hosts_br6b_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a_files/cluster_uptime_by_datacenter_br7a_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a_files/report5.jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/virtual_servers_uptime_by_cluster_br14a_files/virtual_servers_uptime_by_cluster_br14a_jrxml.data 20 files changed, 24 insertions(+), 24 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I360141c71fbd76656f26d75ae56e5c45c5f3cda4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: rhevm-manage-domains -passwordFile=<existing empty fi...
by yzaslavs＠redhat.com 01 Nov '12

01 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: rhevm-manage-domains -passwordFile=<existing empty file> throws exception ...................................................................... tools: rhevm-manage-domains -passwordFile=<existing empty file> throws exception When running rhevm-manage-domains with -passwordFile=pass, a NullPointerException is thrown when the passowrd file exists but is empty. Change-Id: Id3b6ffcad4ae402ffce2adcaf023068da024ee81 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=870052 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResultEnum.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3b6ffcad4ae402ffce2adcaf023068da024ee81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fixed usage of dbName param in getTasks and getCo...
by oschreib＠redhat.com 01 Nov '12

01 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Fixed usage of dbName param in getTasks and getCompensations ...................................................................... packaging: Fixed usage of dbName param in getTasks and getCompensations Change-Id: I95c3c2031f2ba3637032c0f36cd7574acacb2c6a Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95c3c2031f2ba3637032c0f36cd7574acacb2c6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: fix errors in setup.py
by mpastern＠redhat.com 01 Nov '12

01 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: fix errors in setup.py ...................................................................... sdk: fix errors in setup.py Change-Id: I810eb37666e2596e41ca84b83eceb9a55d7b6db8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M setup.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I810eb37666e2596e41ca84b83eceb9a55d7b6db8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: release 3.2.0.6-1
by mpastern＠redhat.com 01 Nov '12

01 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.6-1 ...................................................................... cli: release 3.2.0.6-1 Change-Id: Ia37156ea3f4f8dfde3709bb4bd21029d8c13ac60 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 9 insertions(+), 6 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia37156ea3f4f8dfde3709bb4bd21029d8c13ac60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: added localization values for enum translator table
by ydary＠redhat.com 01 Nov '12

01 Nov '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: added localization values for enum translator table ...................................................................... history: added localization values for enum translator table added languages files for: - es - fr - ja - pt_BR - zh_CN https://bugzilla.redhat.com/862370 https://bugzilla.redhat.com/866148 https://bugzilla.redhat.com/866149 https://bugzilla.redhat.com/866151 https://bugzilla.redhat.com/866152 Change-Id: Iebdcab9b2033f232a2e979bb22f1e562bf839d92 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/upgrade/03_00_0160_extend_enum_value_length.sql A data-warehouse/historydbscripts_postgres/upgrade/03_00_0170_add_localized_enum_values.sql 2 files changed, 377 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebdcab9b2033f232a2e979bb22f1e562bf839d92 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0